Patchwork arptables: build an libarptc.a archive

login
register
mail settings
Submitter Jonh Wendell
Date Feb. 21, 2013, 11:45 p.m.
Message ID <1361490336-4676-1-git-send-email-jonh.wendell@gmail.com>
Download mbox | patch
Permalink /patch/222442/
State Not Applicable
Headers show

Comments

Jonh Wendell - Feb. 21, 2013, 11:45 p.m.
From: Jonh Wendell <jonh.wendell@oiwifi.com.br>

this allows programs to statically link against libarptc.

Signed-off-by: Jonh Wendell <jonh.wendell@oiwifi.com.br>
---
 userspace/arptables/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Jan Engelhardt - Feb. 22, 2013, 8:50 a.m.
On Friday 2013-02-22 00:45, Jonh Wendell wrote:

>From: Jonh Wendell <jonh.wendell@oiwifi.com.br>
>
>this allows programs to statically link against libarptc.

A shared library, should anyone ever wish to develop against arptc 
(which I doubt), is much preferable.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bart De Schuymer - Feb. 24, 2013, 10:09 a.m.
Op 22/02/2013 9:50, Jan Engelhardt schreef:
> On Friday 2013-02-22 00:45, Jonh Wendell wrote:
>
>> From: Jonh Wendell <jonh.wendell@oiwifi.com.br>
>>
>> this allows programs to statically link against libarptc.
> A shared library, should anyone ever wish to develop against arptc
> (which I doubt), is much preferable.
I've applied the patch. It's pretty common in embedded systems not to 
use shared libraries. If anyone wants a shared library, they'll have to 
provide a patch...
Hopefully the new nftables or xtables2 will support arptables and 
provide for a better alternative :-)

cheers,
Bart

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/userspace/arptables/Makefile b/userspace/arptables/Makefile
index 9a7bea4..38158d9 100644
--- a/userspace/arptables/Makefile
+++ b/userspace/arptables/Makefile
@@ -19,7 +19,7 @@  endif
 
 include extensions/Makefile
 
-all: arptables
+all: arptables libarptc/libarptc.a
 
 arptables.o: arptables.c
 	$(CC) $(CFLAGS) -c -o $@ $<
@@ -30,6 +30,9 @@  arptables-standalone.o: arptables-standalone.c
 libarptc/libarptc.o: libarptc/libarptc.c libarptc/libarptc_incl.c
 	$(CC) $(CFLAGS) -c -o $@ $<
 
+libarptc/libarptc.a: libarptc/libarptc.o
+	$(AR) rcs $@ $<
+
 arptables: arptables-standalone.o arptables.o libarptc/libarptc.o $(EXT_OBJS)
 	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^
 
@@ -62,7 +65,7 @@  clean:
 	rm -f arptables
 	rm -f *.o *~
 	rm -f extensions/*.o extensions/*~
-	rm -f libarptc/*.o libarptc/*~
+	rm -f libarptc/*.o libarptc/*~ libarptc/*.a
 	rm -f include/*~ include/libarptc/*~
 
 DIR:=arptables-v$(ARPTABLES_VERSION)