Patchwork new package: network-manager-applet

login
register
mail settings
Submitter Stefan Fröberg
Date Feb. 21, 2013, 7:22 p.m.
Message ID <1361474534-6070-1-git-send-email-stefan.froberg@petroprogram.com>
Download mbox | patch
Permalink /patch/222406/
State Changes Requested
Headers show

Comments

Stefan Fröberg - Feb. 21, 2013, 7:22 p.m.
GTK+ applet for NetworkManager

Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
---

 package/Config.in                                  |    1 +
 package/network-manager-applet/Config.in           |   13 +++++++++
 .../network-manager-applet.mk                      |   28 ++++++++++++++++++++
 3 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100644 package/network-manager-applet/Config.in
 create mode 100644 package/network-manager-applet/network-manager-applet.mk
Yann E. MORIN - Feb. 21, 2013, 10:11 p.m.
Stefan, All,

On Thursday 21 February 2013 Stefan Fröberg wrote:
> GTK+ applet for NetworkManager

Oh, nice! Did you finally managed to make it work?

> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
[--SNIP--]
> diff --git a/package/network-manager-applet/Config.in b/package/network-manager-applet/Config.in
> new file mode 100644
> index 0000000..03cf0e7
> --- /dev/null
> +++ b/package/network-manager-applet/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_NETWORK_MANAGER_APPLET
> +	bool "network-manager-applet"
> +	depends on BR2_PACKAGE_NETWORK_MANAGER
> +	depends on BR2_PACKAGE_ISO_CODES
> +	select BR2_PACKAGE_LIBTASN1

We do not currently have libtasn1 in the packages (although I've seen
a patch to add it float by recently, maybe your patch? If so, say that
it needs to be applied before this one).

> +	select BR2_PACKAGE_GNOME_KEYRING
> +	select BR2_PACKAGE_NOTIFICATION_DAEMON
> +	select BR2_PACKAGE_CONSOLEKIT

Be careful to properly inherit dependencies from packages you 'select'.

> diff --git a/package/network-manager-applet/network-manager-applet.mk b/package/network-manager-applet/network-manager-applet.mk
> new file mode 100644
> index 0000000..51834b5
> --- /dev/null
> +++ b/package/network-manager-applet/network-manager-applet.mk
> @@ -0,0 +1,28 @@
> +#############################################################
> +#
> +# network-manager-applet
> +#
> +#############################################################
> +
> +NETWORK_MANAGER_APPLET_VERSION = 0.9.2.0
> +NETWORK_MANAGER_APPLET_SOURCE = network-manager-applet-$(NETWORK_MANAGER_APPLET_VERSION).tar.xz
> +NETWORK_MANAGER_APPLET_SITE = http://ftp.gnome.org/pub/GNOME/sources/network-manager-applet/0.9/
> +NETWORK_MANAGER_APPLET_INSTALL_STAGING = YES
> +NETWORK_MANAGER_APPLET_DEPENDENCIES = network-manager iso-codes libtasn1 \
> +				     gnome-keyring notification-daemon \
> +				     consolekit
> +NETWORK_MANAGER_APPLET_CONF_OPT += --disable-more-warnings \
> +				   --localstatedir=/var --enable-migration \
> +				   --with-gtkver=2
> +NETWORK_MANAGER_APPLET_AUTORECONF = YES

Why autoreconf?

> +define	NETWORK_MANAGER_APPLET_FIXUP
> +	# This file adds that annoying -Werror even if told *no*. Kick it out
> +	rm -f $(@D)/m4/compiler_warnings.m4
> +endef
> +
> +NETWORK_MANAGER_APPLET_PRE_CONFIGURE_HOOKS += NETWORK_MANAGER_APPLET_FIXUP

Make this a post-extract hook, not a pre-configure hook.
(Unless it is added by autoreconf?)

Regards,
Yann E. MORIN.
Stefan Fröberg - Feb. 21, 2013, 10:28 p.m.
22.2.2013 0:11, Yann E. MORIN kirjoitti:
> Stefan, All,
>
> On Thursday 21 February 2013 Stefan Fröberg wrote:
>> GTK+ applet for NetworkManager
> Oh, nice! Did you finally managed to make it work?

Well, sort of ... I think I know what's the problem now. It's that damn
consolekit.

When I do ck-list-session in terminal under Xorg it list "active =
FALSE" and  "is local = FALSE".

Found out just now that kernel config needs to have CONFIG_AUDIT=y and
CONFIG_AUDITSYSCALL=y
enabled which, of course, I was missing ....
Maybe just enough time to recompile kernel and try it one more time
before dropping to bed.


>> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
> [--SNIP--]
>> diff --git a/package/network-manager-applet/Config.in b/package/network-manager-applet/Config.in
>> new file mode 100644
>> index 0000000..03cf0e7
>> --- /dev/null
>> +++ b/package/network-manager-applet/Config.in
>> @@ -0,0 +1,13 @@
>> +config BR2_PACKAGE_NETWORK_MANAGER_APPLET
>> +	bool "network-manager-applet"
>> +	depends on BR2_PACKAGE_NETWORK_MANAGER
>> +	depends on BR2_PACKAGE_ISO_CODES
>> +	select BR2_PACKAGE_LIBTASN1
> We do not currently have libtasn1 in the packages (although I've seen
> a patch to add it float by recently, maybe your patch? If so, say that
> it needs to be applied before this one).
>
>> +	select BR2_PACKAGE_GNOME_KEYRING
>> +	select BR2_PACKAGE_NOTIFICATION_DAEMON
>> +	select BR2_PACKAGE_CONSOLEKIT
> Be careful to properly inherit dependencies from packages you 'select'.
>
>> diff --git a/package/network-manager-applet/network-manager-applet.mk b/package/network-manager-applet/network-manager-applet.mk
>> new file mode 100644
>> index 0000000..51834b5
>> --- /dev/null
>> +++ b/package/network-manager-applet/network-manager-applet.mk
>> @@ -0,0 +1,28 @@
>> +#############################################################
>> +#
>> +# network-manager-applet
>> +#
>> +#############################################################
>> +
>> +NETWORK_MANAGER_APPLET_VERSION = 0.9.2.0
>> +NETWORK_MANAGER_APPLET_SOURCE = network-manager-applet-$(NETWORK_MANAGER_APPLET_VERSION).tar.xz
>> +NETWORK_MANAGER_APPLET_SITE = http://ftp.gnome.org/pub/GNOME/sources/network-manager-applet/0.9/
>> +NETWORK_MANAGER_APPLET_INSTALL_STAGING = YES
>> +NETWORK_MANAGER_APPLET_DEPENDENCIES = network-manager iso-codes libtasn1 \
>> +				     gnome-keyring notification-daemon \
>> +				     consolekit
>> +NETWORK_MANAGER_APPLET_CONF_OPT += --disable-more-warnings \
>> +				   --localstatedir=/var --enable-migration \
>> +				   --with-gtkver=2
>> +NETWORK_MANAGER_APPLET_AUTORECONF = YES
> Why autoreconf?

Umm, I not sure anymore (too dizzy).
Maybe it was because that  compiler_warnings.m4 thing below or something
else
Will sort it out tomorrow...

>> +define	NETWORK_MANAGER_APPLET_FIXUP
>> +	# This file adds that annoying -Werror even if told *no*. Kick it out
>> +	rm -f $(@D)/m4/compiler_warnings.m4
>> +endef
>> +
>> +NETWORK_MANAGER_APPLET_PRE_CONFIGURE_HOOKS += NETWORK_MANAGER_APPLET_FIXUP
> Make this a post-extract hook, not a pre-configure hook.
> (Unless it is added by autoreconf?)

Ill try and see

> Regards,
> Yann E. MORIN.
>


Thanks

Stefan

Patch

diff --git a/package/Config.in b/package/Config.in
index 55c99bb..266f487 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -678,6 +678,7 @@  source "package/netplug/Config.in"
 source "package/netsnmp/Config.in"
 source "package/netstat-nat/Config.in"
 source "package/network-manager/Config.in"
+source "package/network-manager-applet/Config.in"
 source "package/nfacct/Config.in"
 source "package/noip/Config.in"
 source "package/ngircd/Config.in"
diff --git a/package/network-manager-applet/Config.in b/package/network-manager-applet/Config.in
new file mode 100644
index 0000000..03cf0e7
--- /dev/null
+++ b/package/network-manager-applet/Config.in
@@ -0,0 +1,13 @@ 
+config BR2_PACKAGE_NETWORK_MANAGER_APPLET
+	bool "network-manager-applet"
+	depends on BR2_PACKAGE_NETWORK_MANAGER
+	depends on BR2_PACKAGE_ISO_CODES
+	select BR2_PACKAGE_LIBTASN1
+	select BR2_PACKAGE_GNOME_KEYRING
+	select BR2_PACKAGE_NOTIFICATION_DAEMON
+	select BR2_PACKAGE_CONSOLEKIT
+	help
+	  GTK+ applet for NetworkManager
+
+	  http://projects.gnome.org/NetworkManager/
+
diff --git a/package/network-manager-applet/network-manager-applet.mk b/package/network-manager-applet/network-manager-applet.mk
new file mode 100644
index 0000000..51834b5
--- /dev/null
+++ b/package/network-manager-applet/network-manager-applet.mk
@@ -0,0 +1,28 @@ 
+#############################################################
+#
+# network-manager-applet
+#
+#############################################################
+
+NETWORK_MANAGER_APPLET_VERSION = 0.9.2.0
+NETWORK_MANAGER_APPLET_SOURCE = network-manager-applet-$(NETWORK_MANAGER_APPLET_VERSION).tar.xz
+NETWORK_MANAGER_APPLET_SITE = http://ftp.gnome.org/pub/GNOME/sources/network-manager-applet/0.9/
+NETWORK_MANAGER_APPLET_INSTALL_STAGING = YES
+NETWORK_MANAGER_APPLET_DEPENDENCIES = network-manager iso-codes libtasn1 \
+				     gnome-keyring notification-daemon \
+				     consolekit
+NETWORK_MANAGER_APPLET_CONF_OPT += --disable-more-warnings \
+				   --localstatedir=/var --enable-migration \
+				   --with-gtkver=2
+NETWORK_MANAGER_APPLET_AUTORECONF = YES
+
+define	NETWORK_MANAGER_APPLET_FIXUP
+	# This file adds that annoying -Werror even if told *no*. Kick it out
+	rm -f $(@D)/m4/compiler_warnings.m4
+endef
+
+NETWORK_MANAGER_APPLET_PRE_CONFIGURE_HOOKS += NETWORK_MANAGER_APPLET_FIXUP
+
+$(eval $(autotools-package))
+
+