Patchwork ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv

login
register
mail settings
Submitter Rado Vrbovsky
Date Feb. 21, 2013, 7:01 p.m.
Message ID <774443881.7195405.1361473310424.JavaMail.root@redhat.com>
Download mbox | patch
Permalink /patch/222401/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Rado Vrbovsky - Feb. 21, 2013, 7:01 p.m.
From: Andrew Brownfield <abrownfi@redhat.com>

In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c 
"ata_piix: defer disks to the Hyper-V drivers by default",
this trivial patch adds a description to prefer_ms_hyperv.

[rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]

Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>
Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>

---
 drivers/ata/ata_piix.c | 4 ++++
 1 file changed, 4 insertions(+)
Sergei Shtylyov - Feb. 22, 2013, 2:43 p.m.
Hello.

On 21-02-2013 23:01, Rado Vrbovsky wrote:

> From: Andrew Brownfield <abrownfi@redhat.com>

> In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
> "ata_piix: defer disks to the Hyper-V drivers by default",
> this trivial patch adds a description to prefer_ms_hyperv.

> [rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]

> Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>

    Note that you can't jus mechanically add Andrew's signoff to the patch, 
you have to ask him to sign it off... I hope you did.

> Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rado Vrbovsky - Feb. 22, 2013, 3:41 p.m.
> Hello.

Hi Sergei,
 
> On 21-02-2013 23:01, Rado Vrbovsky wrote:
> 
> > From: Andrew Brownfield <abrownfi@redhat.com>
> 
> > In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
> > "ata_piix: defer disks to the Hyper-V drivers by default",
> > this trivial patch adds a description to prefer_ms_hyperv.
> 
> > [rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting
> > modified]
> 
> > Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>
> 
>     Note that you can't jus mechanically add Andrew's signoff to the
>     patch,
> you have to ask him to sign it off... I hope you did.

It was in the original patch and I erased by mistake.

> > Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>
> 
> MBR, Sergei
> 

Brg,

Rado
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - March 4, 2013, 10:15 p.m.
On 02/21/2013 02:01 PM, Rado Vrbovsky wrote:
> From: Andrew Brownfield <abrownfi@redhat.com>
>
> In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
> "ata_piix: defer disks to the Hyper-V drivers by default",
> this trivial patch adds a description to prefer_ms_hyperv.
>
> [rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]
>
> Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>
> Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>
>
> ---
>   drivers/ata/ata_piix.c | 4 ++++
>   1 file changed, 4 insertions(+)

applied [manually]



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 174eca6..b9bf99a 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1530,6 +1530,10 @@  static bool piix_broken_system_poweroff(struct pci_dev *pdev)
 
 static int prefer_ms_hyperv = 1;
 module_param(prefer_ms_hyperv, int, 0); 
+MODULE_PARM_DESC(prefer_ms_hyperv,
+       "Prefer Hyper-V paravirtualization drivers instead of ATA, "
+       "0 - Use ATA drivers, "
+       "1 (Default) - Use the paravirtualization drivers.");
 
 static void piix_ignore_devices_quirk(struct ata_host *host)
 {