Patchwork new package: libcanberra

login
register
mail settings
Submitter Stefan Fröberg
Date Feb. 21, 2013, 6:28 p.m.
Message ID <1361471297-23210-1-git-send-email-stefan.froberg@petroprogram.com>
Download mbox | patch
Permalink /patch/222394/
State Changes Requested
Headers show

Comments

Stefan Fröberg - Feb. 21, 2013, 6:28 p.m.
libcanberra

Portable sound event library

Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
---
 package/Config.in                  |    1 +
 package/libcanberra/Config.in      |   10 ++++++++++
 package/libcanberra/libcanberra.mk |   17 +++++++++++++++++
 3 files changed, 28 insertions(+), 0 deletions(-)
 create mode 100644 package/libcanberra/Config.in
 create mode 100644 package/libcanberra/libcanberra.mk
Yann E. MORIN - Feb. 21, 2013, 9:41 p.m.
Stefan, All,

On Thursday 21 February 2013 Stefan Fröberg wrote:
> libcanberra
  ^^^
Useless line.

> Portable sound event library
> 
> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
[--SNIP--]
> diff --git a/package/libcanberra/Config.in b/package/libcanberra/Config.in
> new file mode 100644
> index 0000000..59accd0
> --- /dev/null
> +++ b/package/libcanberra/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_LIBCANBERRA
> +	bool "libcanberra"
> +	select	BR2_PACKAGE_ALSA_LIB

You need to inherit the depndencies of alsa-lib:
    depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib

(add a comment when it's not availalbe.)

Also, single-space between 'select' and the symbol name.

> +	select	BR2_PACKAGE_LIBGTK2

Ditto the previous patch: I'd prefer a 'depends on' rather than a
'select'

> +	select	BR2_PACKAGE_LIBVORBIS
> +	help
> +	  Portable sound event library
> +
> +	  http://0pointer.de/lennart/projects/libcanberra

Ah-ah! Yet another poetteringy lib. ;-)

Regards,
Yann E. MORIN.

Patch

diff --git a/package/Config.in b/package/Config.in
index 51e92a2..28bb55c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -350,6 +350,7 @@  source "package/alsa-lib/Config.in"
 source "package/audiofile/Config.in"
 source "package/celt051/Config.in"
 source "package/libao/Config.in"
+source "package/libcanberra/Config.in"
 source "package/libcdaudio/Config.in"
 source "package/libcue/Config.in"
 source "package/libcuefile/Config.in"
diff --git a/package/libcanberra/Config.in b/package/libcanberra/Config.in
new file mode 100644
index 0000000..59accd0
--- /dev/null
+++ b/package/libcanberra/Config.in
@@ -0,0 +1,10 @@ 
+config BR2_PACKAGE_LIBCANBERRA
+	bool "libcanberra"
+	select	BR2_PACKAGE_ALSA_LIB
+	select	BR2_PACKAGE_LIBGTK2
+	select	BR2_PACKAGE_LIBVORBIS
+	help
+	  Portable sound event library
+
+	  http://0pointer.de/lennart/projects/libcanberra
+
diff --git a/package/libcanberra/libcanberra.mk b/package/libcanberra/libcanberra.mk
new file mode 100644
index 0000000..9394294
--- /dev/null
+++ b/package/libcanberra/libcanberra.mk
@@ -0,0 +1,17 @@ 
+#############################################################
+#
+# libcanberra
+#
+#############################################################
+
+LIBCANBERRA_VERSION = 0.27
+LIBCANBERRA_SITE = http://0pointer.de/lennart/projects/libcanberra
+LIBCANBERRA_INSTALL_STAGING = YES
+LIBCANBERRA_DEPENDENCIES = libvorbis libtool alsa-lib libgtk2
+LIBCANBERRA_CONF_OPT += --disable-oss --enable-gtk
+LIBCANBERRA_LICENSE = LGPLv2.1+
+LIBCANBERRA_LICENSE_FILES = LGPL
+
+$(eval $(autotools-package))
+
+