Patchwork new package: libwnck

login
register
mail settings
Submitter Stefan Fröberg
Date Feb. 21, 2013, 6:06 p.m.
Message ID <1361469999-9963-1-git-send-email-stefan.froberg@petroprogram.com>
Download mbox | patch
Permalink /patch/222388/
State Changes Requested
Headers show

Comments

Stefan Fröberg - Feb. 21, 2013, 6:06 p.m.
libwnck

A window navigation construction kit

Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
---
 package/Config.in          |    1 +
 package/libwnck/Config.in  |   13 +++++++++++++
 package/libwnck/libwnck.mk |   19 +++++++++++++++++++
 3 files changed, 33 insertions(+), 0 deletions(-)
 create mode 100644 package/libwnck/Config.in
 create mode 100644 package/libwnck/libwnck.mk
Yann E. MORIN - Feb. 21, 2013, 9:30 p.m.
Stefan, All,

On Thursday 21 February 2013 Stefan Fröberg wrote:
> libwnck
  ^^^
Useless line.

> A window navigation construction kit
> 
> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
[--SNIP--]
> diff --git a/package/libwnck/Config.in b/package/libwnck/Config.in
> new file mode 100644
> index 0000000..42ca4fc
> --- /dev/null
> +++ b/package/libwnck/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBWNCK
> +	bool "libwnck"
> +	select	BR2_PACKAGE_LIBGTK2

You have to inherit the dependencies for libgtk2:
    depends on BR2_PACKAGE_XORG7||BR2_PACKAGE_DIRECTFB # libgtk2
    depends on BR2_USE_WCHAR # glib2
    depends on BR2_INSTALL_LIBSTDCPP # pango

But I'd prefer it it were a 'depends on BR2_PACKAGE_LIBGTK2' rather than
a 'select'.

And add a comment anyway to state why libwnck is not available.

> +	select	BR2_PACKAGE_STARTUP_NOTIFICATION

Ditto, you need to forward startyup-notification's dependencies.

Regards,
Yann E. MORIN, getting a bit tired of only doing reviews, tonight... ;-)
Arnout Vandecappelle - Feb. 23, 2013, 9:20 a.m.
On 21/02/13 22:30, Yann E. MORIN wrote:
> But I'd prefer it it were a 'depends on BR2_PACKAGE_LIBGTK2' rather than
> a 'select'.
>
> And add a comment anyway to state why libwnck is not available.

  The other packages that depend on libgtk2 don't have a comment...

  Actually, I think all of them should be sorted under libgtk2, so 
they're nicely indented and fold open when libgtk2 is selected.

  Regards,
  Arnout

Patch

diff --git a/package/Config.in b/package/Config.in
index 8588951..51e92a2 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -433,6 +433,7 @@  source "package/libraw/Config.in"
 source "package/librsvg/Config.in"
 source "package/libsvgtiny/Config.in"
 source "package/libungif/Config.in"
+source "package/libwnck/Config.in"
 source "package/opencv/Config.in"
 source "package/pango/Config.in"
 source "package/pixman/Config.in"
diff --git a/package/libwnck/Config.in b/package/libwnck/Config.in
new file mode 100644
index 0000000..42ca4fc
--- /dev/null
+++ b/package/libwnck/Config.in
@@ -0,0 +1,13 @@ 
+config BR2_PACKAGE_LIBWNCK
+	bool "libwnck"
+	select	BR2_PACKAGE_LIBGTK2
+	select	BR2_PACKAGE_STARTUP_NOTIFICATION
+	help
+	  libwnck is the Window Navigator Construction Kit, a library for use
+	  in writing pagers, tasklists, and more generally applications that 
+	  are dealing with window management.
+	  It tries hard to respect the Extended Window Manager Hints 
+	  specification (EMWH).
+
+	  http://www.gnome.org
+
diff --git a/package/libwnck/libwnck.mk b/package/libwnck/libwnck.mk
new file mode 100644
index 0000000..54d1866
--- /dev/null
+++ b/package/libwnck/libwnck.mk
@@ -0,0 +1,19 @@ 
+#############################################################
+#
+# libwnck
+#
+#############################################################
+
+LIBWNCK_MAJOR_VERSION = 2.30
+LIBWNCK_MINOR_VERSION = 7
+LIBWNCK_VERSION = $(LIBWNCK_MAJOR_VERSION).$(LIBWNCK_MINOR_VERSION)
+LIBWNCK_SOURCE = libwnck-$(LIBWNCK_VERSION).tar.xz
+LIBWNCK_SITE = http://ftp.gnome.org/pub/gnome/sources/libwnck/$(LIBWNCK_MAJOR_VERSION)
+LIBWNCK_INSTALL_STAGING = YES
+LIBWNCK_LICENSE = LGPLv2.1+
+LIBWNCK_LICENSE_FILES = COPYING
+LIBWNCK_DEPENDENCIES = libgtk2 startup-notification
+
+$(eval $(autotools-package))
+
+