Patchwork [U-Boot] cmd_fat.c: Note in fatread help about alignment requirements

login
register
mail settings
Submitter Tom Rini
Date Feb. 21, 2013, 4:55 p.m.
Message ID <1361465741-24985-1-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/222364/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Tom Rini - Feb. 21, 2013, 4:55 p.m.
When using the partial read feature of fatwrite the buffer we read into
can become unaligned not just due to initial location but the size of
our partial reads as well.  Make this clear in the help text.

Signed-off-by: Tom Rini <trini@ti.com>
---
 common/cmd_fat.c |    3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/common/cmd_fat.c b/common/cmd_fat.c
index 86be044..0487438 100644
--- a/common/cmd_fat.c
+++ b/common/cmd_fat.c
@@ -49,6 +49,9 @@  U_BOOT_CMD(
 	"      If 'pos' is omitted, 0 is used. 'pos' requires 'bytes'.\n"
 	"      'bytes' gives the size to load. If 'bytes' is 0 or omitted,\n"
 	"      the load stops on end of file.\n"
+	"      If either 'pos' or 'bytes' are not aligned to\n"
+	"      ARCH_DMA_MINALIGN then a misaligned buffer warning will\n"
+	"      be printed and performance will suffer for the load.\n"
 	"      All numeric parameters are assumed to be hex."
 );