Patchwork [12/13] tinyxml: new package

login
register
mail settings
Submitter Maxime Hadjinlian
Date Feb. 21, 2013, 2:58 p.m.
Message ID <ad24f17c066c0f28873e76aaf0f69b08ca205e36.1361458625.git.maxime.hadjinlian@gmail.com>
Download mbox | patch
Permalink /patch/222318/
State Changes Requested
Headers show

Comments

Maxime Hadjinlian - Feb. 21, 2013, 2:58 p.m.
Tiny XML Parser.
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <ebsi4711@gmail.com>

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in          |    1 +
 package/tinyxml/Config.in  |   12 ++++++++++++
 package/tinyxml/tinyxml.mk |   12 ++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100644 package/tinyxml/Config.in
 create mode 100644 package/tinyxml/tinyxml.mk
Yann E. MORIN - Feb. 21, 2013, 8:40 p.m.
Maxime, All,

On Thursday 21 February 2013 Maxime Hadjinlian wrote:
> Tiny XML Parser.
> This package was originally found at : https://github.com/huceke/buildroot-rbp
> By gimli <ebsi4711@gmail.com>
[--SNIP--]
> diff --git a/package/tinyxml/Config.in b/package/tinyxml/Config.in
> new file mode 100644
> index 0000000..b549d00
> --- /dev/null
> +++ b/package/tinyxml/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_TINYXML
> +	bool "tinyxml"
> +        depends on BR2_INSTALL_LIBSTDCPP

Indent-damage. Leading tabs, please.

> diff --git a/package/tinyxml/tinyxml.mk b/package/tinyxml/tinyxml.mk
> new file mode 100644
> index 0000000..f4f042b
> --- /dev/null
> +++ b/package/tinyxml/tinyxml.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# tinyxml
> +#
> +#############################################################
> +
> +TINYXML_VERSION = 2.6.2_2
> +TINYXML_SITE = http://mirrors.xbmc.org/build-deps/sources
> +TINYXML_AUTORECONF = YES
> +TINYXML_INSTALL_STAGING = YES

License is the Zlib license:
    https://github.com/leethomason/tinyxml2/blob/master/tinyxml2.cpp
    https://spdx.org/licenses/Zlib

Regards,
Yann E. MORIN.
Yann E. MORIN - Feb. 21, 2013, 8:53 p.m.
Maxime, All,

Sorry, I forgot something in the previous review...

On Thursday 21 February 2013 Maxime Hadjinlian wrote:
[--SNIP--]
> diff --git a/package/tinyxml/tinyxml.mk b/package/tinyxml/tinyxml.mk
> new file mode 100644
> index 0000000..f4f042b
> --- /dev/null
> +++ b/package/tinyxml/tinyxml.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# tinyxml
> +#
> +#############################################################
> +
> +TINYXML_VERSION = 2.6.2_2
> +TINYXML_SITE = http://mirrors.xbmc.org/build-deps/sources
> +TINYXML_AUTORECONF = YES

Explain why it needs autoreconf.

As you point the help text to the git repository, I looked there, and
there is *no* configure.{ac,in}.

But looking at the download URL, I downloaded the tarball, and it seems
the XBMC folks have added a configure.ac in their distribution of tinyxml2.

But looking even more closely, it seems XBMC is using tinyxml, and *not*
tinyxml2. Specifically, they are using tinyxml 2.6.2, originally available
there (not to say that's the one we should use):
    http://sourceforge.net/projects/tinyxml/

So, Id 'update the help text to refer to tinyxml, not tinyxml2.

Regards,
Yann E. MORIN.

Patch

diff --git a/package/Config.in b/package/Config.in
index d798137..7db8ba9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -604,6 +604,7 @@  source "package/libxml2/Config.in"
 source "package/libxslt/Config.in"
 source "package/libyaml/Config.in"
 source "package/mxml/Config.in"
+source "package/tinyxml/Config.in"
 source "package/xerces/Config.in"
 source "package/yajl/Config.in"
 endmenu
diff --git a/package/tinyxml/Config.in b/package/tinyxml/Config.in
new file mode 100644
index 0000000..b549d00
--- /dev/null
+++ b/package/tinyxml/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_TINYXML
+	bool "tinyxml"
+        depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  TinyXML is a simple, small, C++ XML parser that can be
+	  easily integrating into other programs.
+
+	  https://github.com/leethomason/tinyxml2
+
+comment "tinyxml requires C++ support in toolchain"
+        depends on !BR2_INSTALL_LIBSTDCPP
+	
diff --git a/package/tinyxml/tinyxml.mk b/package/tinyxml/tinyxml.mk
new file mode 100644
index 0000000..f4f042b
--- /dev/null
+++ b/package/tinyxml/tinyxml.mk
@@ -0,0 +1,12 @@ 
+#############################################################
+#
+# tinyxml
+#
+#############################################################
+
+TINYXML_VERSION = 2.6.2_2
+TINYXML_SITE = http://mirrors.xbmc.org/build-deps/sources
+TINYXML_AUTORECONF = YES
+TINYXML_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))