From patchwork Thu Feb 21 08:37:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 222206 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vc0-f190.google.com (mail-vc0-f190.google.com [209.85.220.190]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 5C0E02C0090 for ; Thu, 21 Feb 2013 19:37:19 +1100 (EST) Received: by mail-vc0-f190.google.com with SMTP id fw7sf3627022vcb.27 for ; Thu, 21 Feb 2013 00:37:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=HRFt+01whn4qR1gQu3J+4WN9JLYZInNu5mcKLSDhJyY=; b=PaGotylu5SEKE1XvZawe5kFsIWf+SCyHQF2S35n6JHJIZpEnfx7c4Z1V43rHWNMnRi llWZW7O0SpB9JG4ZP/TB+uvsdZSwXEuYX8F4KuJBFPOHX1z2K5CoOQ8rLo5EPs/ysMn+ Fe609tx6TLXvoyrOS9MvLa15K0KJXTD2dR6/gSvT68OefSFpUZmXRIvUkw+tJhBpCcE2 5p/62WbZIl1ae84MQA7uh6pGp7Wf7eApy0KqKBT3aH9jsg6WupYsTwdAW3bafhqeXTDa 7o5QqMGfyq97PjOLmEtSzsV0WgRVCujAkQx7aeh5i9rsPbvmkF2FXk814sNzHK4mn1RZ Dx+A== X-Received: by 10.50.196.227 with SMTP id ip3mr3136265igc.10.1361435836835; Thu, 21 Feb 2013 00:37:16 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.36.168 with SMTP id r8ls163142igj.40.canary; Thu, 21 Feb 2013 00:37:16 -0800 (PST) X-Received: by 10.66.80.41 with SMTP id o9mr3530408pax.4.1361435836611; Thu, 21 Feb 2013 00:37:16 -0800 (PST) X-Received: by 10.66.80.41 with SMTP id o9mr3530407pax.4.1361435836597; Thu, 21 Feb 2013 00:37:16 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id tj3si4408275pbc.0.2013.02.21.00.37.16; Thu, 21 Feb 2013 00:37:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIK00F8HAKVMKJ0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:37:11 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id D7.D6.03448.7BCD5215; Thu, 21 Feb 2013 17:37:11 +0900 (KST) X-AuditID: cbfee68f-b7f656d000000d78-44-5125dcb79c11 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7F.D3.03880.7BCD5215; Thu, 21 Feb 2013 17:37:11 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIK0059AALZDJ40@mmp2.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:37:11 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> In-reply-to: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> Subject: [rtc-linux] [PATCH 10/12] rtc: rtc-max8907: use devm_request_threaded_irq() Date: Thu, 21 Feb 2013 17:37:11 +0900 Message-id: <00d501ce100e$a4554000$ecffc000$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4QDe9M0/OnFjrjTvSUwIYm7R1WAgAAKaNQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t8zfd3td1QDDbqu6lvs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxpEJcxgLDnBUdLdMZGtgbGbvYuTkkBAwkdjacZYRwhaTuHBv PVsXIxeHkMAyRol1v/eywRSt+fODFSIxnVHi289JUFUzmSQWLP0O1s4moCbx5cthoLEcHCIC +hJtLRogNcwCvYwSZ3p3g60TErCVmPPhGjOIzSlgJ3F52xdWEFtYwENiyf9zYDUsAqoSt04+ BovzAtW/2DgRyhaU+DH5HguIzSygJbF+53EmCFteYvOat8wgeyUE1CUe/dUFCYsIGEm83z+N GaJERGLfi3eMIPdICKxilzix/g4TxC4BiW+TD7FA9MpKbDrADPGwpMTBFTdYJjBKzEKyeRaS zbOQbJ6FZMUCRpZVjKKpBckFxUnpRcZ6xYm5xaV56XrJ+bmbGCHR1b+D8e4B60OMyUDrJzJL iSbnA6MzryTe0NjYxMzE1MTc0tTclDRhJXFe+UsygUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4 pRoYhdbIHtNYEaf8YqHs1Gh7n6mPQ5epsh3/8HvKEfaZX00jOWxYw4L2N7xZlXwriFFr6c2w VUWRWS/f60T+WRE5cf9ELtaNsQs6JyyNPSd8xfZHjJP3aolbx1+GbfLM/NWoFjLBaVZjh9n9 tkahty7TjtwOfbl03q2iyaw3q525lsZqir6c835dsxJLcUaioRZzUXEiAGe3GR3EAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xoO72O6qBBk1ztC32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePIhDmMBQc4KrpbJrI1 MDazdzFyckgImEis+fODFcIWk7hwbz1bFyMXh5DAdEaJbz8nQTkzmSQWLP3OCFLFJqAm8eXL YaBuDg4RAX2JthYNkBpmgV5GiTO9u8GmCgnYSsz5cI0ZxOYUsJO4vO0L2AZhAQ+JJf/PgdWw CKhK3Dr5GCzOC1T/YuNEKFtQ4sfkeywgNrOAlsT6nceZIGx5ic1r3jKD7JUQUJd49FcXJCwi YCTxfv80ZogSEYl9L94xTmAUmoVk0iwkk2YhmTQLScsCRpZVjKKpBckFxUnpuUZ6xYm5xaV5 6XrJ+bmbGMGx+0x6B+OqBotDjAIcjEo8vAteqgQKsSaWFVfmHmKU4GBWEuFVvK0aKMSbklhZ lVqUH19UmpNafIgxGejRicxSosn5wLSSVxJvaGxiZmRpZGZhZGJuTpqwkjgv46knAUIC6Ykl qdmpqQWpRTBbmDg4pRoYpxtZMV3Z5/D4pvdrL/dthRmnpsq+nX50I0P35eyF7Oqm+3133P3w /9yTBZufiSuKqzhE/K7fflkkhONvSsahhfkFTj1znjT4ma+RCDi66d5z9q8afsJHyz4tT+qa 9mRpgcSqoz+nmZ77O/UI07V9bZbHNq3ovXzf5v6kDYuW5vHPfv/nZte0Jb5KLMUZiYZazEXF iQAVw4TLIQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Use devm_request_threaded_irq() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-max8907.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-max8907.c b/drivers/rtc/rtc-max8907.c index 1d049da..31ca8fa 100644 --- a/drivers/rtc/rtc-max8907.c +++ b/drivers/rtc/rtc-max8907.c @@ -205,8 +205,9 @@ static int max8907_rtc_probe(struct platform_device *pdev) goto err_unregister; } - ret = request_threaded_irq(rtc->irq, NULL, max8907_irq_handler, - IRQF_ONESHOT, "max8907-alarm0", rtc); + ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, + max8907_irq_handler, + IRQF_ONESHOT, "max8907-alarm0", rtc); if (ret < 0) { dev_err(&pdev->dev, "Failed to request IRQ%d: %d\n", rtc->irq, ret); @@ -224,7 +225,6 @@ static int max8907_rtc_remove(struct platform_device *pdev) { struct max8907_rtc *rtc = platform_get_drvdata(pdev); - free_irq(rtc->irq, rtc); rtc_device_unregister(rtc->rtc_dev); return 0;