From patchwork Thu Feb 21 08:34:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [05/12] rtc: rtc-lp8788: use devm_request_threaded_irq() Date: Wed, 20 Feb 2013 22:34:47 -0000 From: Jingoo Han X-Patchwork-Id: 222202 Message-Id: <00d001ce100e$4ed96660$ec8c3320$%han@samsung.com> To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' Use devm_request_threaded_irq() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-lp8788.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-lp8788.c b/drivers/rtc/rtc-lp8788.c index 4a4e78e..9a46312 100644 --- a/drivers/rtc/rtc-lp8788.c +++ b/drivers/rtc/rtc-lp8788.c @@ -278,16 +278,11 @@ static int lp8788_alarm_irq_register(struct platform_device *pdev, rtc->irq = irq_create_mapping(irqdm, irq); - return request_threaded_irq(rtc->irq, NULL, lp8788_alarm_irq_handler, + return devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, + lp8788_alarm_irq_handler, 0, LP8788_ALM_IRQ, rtc); } -static void lp8788_alarm_irq_unregister(struct lp8788_rtc *rtc) -{ - if (rtc->irq) - free_irq(rtc->irq, rtc); -} - static int lp8788_rtc_probe(struct platform_device *pdev) { struct lp8788 *lp = dev_get_drvdata(pdev->dev.parent); @@ -321,7 +316,6 @@ static int lp8788_rtc_remove(struct platform_device *pdev) { struct lp8788_rtc *rtc = platform_get_drvdata(pdev); - lp8788_alarm_irq_unregister(rtc); rtc_device_unregister(rtc->rdev); platform_set_drvdata(pdev, NULL);