From patchwork Thu Feb 21 08:34:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 222202 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pa0-f56.google.com (mail-pa0-f56.google.com [209.85.220.56]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id ACB442C008E for ; Thu, 21 Feb 2013 19:34:51 +1100 (EST) Received: by mail-pa0-f56.google.com with SMTP id kq12sf3577614pab.11 for ; Thu, 21 Feb 2013 00:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=5/iZ8oYTmeaDTa2Pi+D8SSiabEkIhfOVzjI07JSg1zc=; b=l8yFJBiGjjPTa0p6paMO2h9YIC4ZwV4hNFWmJZlQadcAWPdB/GV2QYqXJdo5/8G8J8 Qz+ztbDXYZzeS0Q+4z3aRK2m5lVC8oHuc19KW28rNzjEUHVfv3eQppNRSpYb18mSmarO d5Qah7xiWzJm/1IBCTu3MXfxCANYlzua03xdvGhO24e/ibfsxfolwsonOBNDMsnqL7tL CejAWMre/L9r6K4X8SjAZE0DGwzXpF7jkFHVoE3KsGm25byv2t7Vj4eJ9lDzLMh78RAy U4Gp9nI5vM8DsyB60Fp9Ri1unE2P3crJV1GHIUY7ijLD9+GzHpIxVZoMvQvdHoaNYrBu q0+A== X-Received: by 10.50.163.41 with SMTP id yf9mr3037301igb.3.1361435689719; Thu, 21 Feb 2013 00:34:49 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.94.130 with SMTP id dc2ls217818igb.4.canary; Thu, 21 Feb 2013 00:34:49 -0800 (PST) X-Received: by 10.66.72.3 with SMTP id z3mr4320023pau.40.1361435689504; Thu, 21 Feb 2013 00:34:49 -0800 (PST) X-Received: by 10.66.72.3 with SMTP id z3mr4320022pau.40.1361435689491; Thu, 21 Feb 2013 00:34:49 -0800 (PST) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id tj3si4406693pbc.0.2013.02.21.00.34.49; Thu, 21 Feb 2013 00:34:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIK00BY8AHYW130@mailout3.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:34:48 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id FD.A5.03448.82CD5215; Thu, 21 Feb 2013 17:34:48 +0900 (KST) X-AuditID: cbfee68f-b7f656d000000d78-6d-5125dc28f234 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 2C.13.03880.82CD5215; Thu, 21 Feb 2013 17:34:48 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIK0054ZAI0DJ30@mmp2.samsung.com> for rtc-linux@googlegroups.com; Thu, 21 Feb 2013 17:34:48 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> In-reply-to: <00cc01ce100d$f42fddc0$dc8f9940$%han@samsung.com> Subject: [rtc-linux] [PATCH 05/12] rtc: rtc-lp8788: use devm_request_threaded_irq() Date: Thu, 21 Feb 2013 17:34:47 +0900 Message-id: <00d001ce100e$4ed96660$ec8c3320$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4QDe9M0/OnFjrjTvSUwIYm7R1WAgAAFB0A X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t8zfV2NO6qBBs+miljs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxqLHa5kLnnBWtL38yNLAuJCji5GTQ0LAROJn23I2CFtM4sK9 9UA2F4eQwDJGiZ6FfYwwRX+efWOBSExnlLi/bx0ThDOTSeLzpBfsIFVsAmoSX74cBrI5OEQE 9CXaWjRAapgFehklzvTuBqsRErCVmPPhGjOIzSlgJ3F52xdWEFtYwF3iypofYDaLgKpE+4nJ YCfxAtUv+AGyGcQWlPgx+R6YzSygJbF+53EmCFteYvOat8wgeyUE1CUe/dUFCYsIGEl0PDnA DFEiIrHvxTtGkHskBFaxS2x/2cQOsUtA4tvkQywQvbISmyDqJQQkJQ6uuMEygVFiFpLNs5Bs noVk8ywkKxYwsqxiFE0tSC4oTkovMtYrTswtLs1L10vOz93ECImu/h2Mdw9YH2JMBlo/kVlK NDkfGJ15JfGGxsYmZiamJuaWpuampAkrifPKX5IJFBJITyxJzU5NLUgtii8qzUktPsTIxMEp 1cCYc91WunfXmg9rjwv8OqXzzcnQbFVz7n+GycuWf+MRry5u7Q5ae+RZinOKzt6n2yY6C0xt MkqLqZm4nenJTya7JRY9qeW2WhLuiXfXz6g/XbAmQ+DpBr3KFWc+XHNjDlwwIViG9bjm3+lO J0y5T3m7nbeYkHZeylSroOH4kWfn72ZLBOdZ7nuhxFKckWioxVxUnAgA5/bK7cQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xoK7GHdVAg01zBCz2d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPR47XMBU84K9pefmRp YFzI0cXIySEhYCLx59k3FghbTOLCvfVsXYxcHEIC0xkl7u9bxwThzGSS+DzpBTtIFZuAmsSX L4eBbA4OEQF9ibYWDZAaZoFeRokzvbvBaoQEbCXmfLjGDGJzCthJXN72hRXEFhZwl7iy5geY zSKgKtF+YjIbiM0LVL/gB8QVvAKCEj8m3wOzmQW0JNbvPM4EYctLbF7zlhlkr4SAusSjv7og YREBI4mOJweYIUpEJPa9eMc4gVFoFpJJs5BMmoVk0iwkLQsYWVYxiqYWJBcUJ6XnGukVJ+YW l+al6yXn525iBMfuM+kdjKsaLA4xCnAwKvHwLnipEijEmlhWXJl7iFGCg1lJhFfxtmqgEG9K YmVValF+fFFpTmrxIcZkoEcnMkuJJucD00peSbyhsYmZkaWRmYWRibk5acJK4ryMp54ECAmk J5akZqemFqQWwWxh4uCUamAUu+G7tU3gcGSuQBbb++dfXecXtIS85Fhu/a/uSPTus9fKztou 4DpsYGbt/HlBIKNXfNO9AzV/+VPuV+bo8kxiMzlQ3Zb76XCPqnLSEoMj9zIv3Uhy3Xj98Nuk zBnRJe1+e5VPLpo95ZfOBx5pJv2z1qGPg2ZOs/75yyV360HDIE3P6X/a9FuUWIozEg21mIuK EwGdtjTmIQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Use devm_request_threaded_irq() to make cleanup paths more simple. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-lp8788.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-lp8788.c b/drivers/rtc/rtc-lp8788.c index 4a4e78e..9a46312 100644 --- a/drivers/rtc/rtc-lp8788.c +++ b/drivers/rtc/rtc-lp8788.c @@ -278,16 +278,11 @@ static int lp8788_alarm_irq_register(struct platform_device *pdev, rtc->irq = irq_create_mapping(irqdm, irq); - return request_threaded_irq(rtc->irq, NULL, lp8788_alarm_irq_handler, + return devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, + lp8788_alarm_irq_handler, 0, LP8788_ALM_IRQ, rtc); } -static void lp8788_alarm_irq_unregister(struct lp8788_rtc *rtc) -{ - if (rtc->irq) - free_irq(rtc->irq, rtc); -} - static int lp8788_rtc_probe(struct platform_device *pdev) { struct lp8788 *lp = dev_get_drvdata(pdev->dev.parent); @@ -321,7 +316,6 @@ static int lp8788_rtc_remove(struct platform_device *pdev) { struct lp8788_rtc *rtc = platform_get_drvdata(pdev); - lp8788_alarm_irq_unregister(rtc); rtc_device_unregister(rtc->rdev); platform_set_drvdata(pdev, NULL);