Patchwork [U-Boot,2/2,V2] EXYNOS5: Snow: Add a configuration file

login
register
mail settings
Submitter Rajeshwari Birje
Date Feb. 21, 2013, 6:43 a.m.
Message ID <1361429010-9092-3-git-send-email-rajeshwari.s@samsung.com>
Download mbox | patch
Permalink /patch/222189/
State Superseded
Delegated to: Minkyu Kang
Headers show

Comments

Rajeshwari Birje - Feb. 21, 2013, 6:43 a.m.
This patch adds the configuration file for Snow Board and
defines the same in boards.cfg.

Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
Changes in V2:
	- Added Maintainer
 MAINTAINERS            |    4 ++++
 boards.cfg             |    1 +
 include/configs/snow.h |   33 +++++++++++++++++++++++++++++++++
 3 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/snow.h
Minkyu Kang - Feb. 25, 2013, 4:19 a.m.
Dear Rajeshwari,

On 21/02/13 15:43, Rajeshwari Shinde wrote:
> This patch adds the configuration file for Snow Board and
> defines the same in boards.cfg.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
> Changes in V2:
> 	- Added Maintainer
>  MAINTAINERS            |    4 ++++
>  boards.cfg             |    1 +
>  include/configs/snow.h |   33 +++++++++++++++++++++++++++++++++
>  3 files changed, 38 insertions(+), 0 deletions(-)
>  create mode 100644 include/configs/snow.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 45e2dd4..5fc5b4d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -736,6 +736,10 @@ Chander Kashyap <k.chander@samsung.com>
>  	SMDKV310		ARM ARMV7 (EXYNOS4210 SoC)
>  	SMDK5250		ARM ARMV7 (EXYNOS5250 SoC)
>  
> +Rajeshwari Shinde <rajeshwari.s@samsung.com>

Please keep this list to alphabetically.
your name should be moved to "S" section.

> +
> +	snow			ARM ARMV7 (EXYNOS5250 SoC)
> +
>  Lukasz Majewski <l.majewski@samsung.com>
>  
>  	trats			ARM ARMV7 (EXYNOS4210 SoC)
> diff --git a/boards.cfg b/boards.cfg
> index b1319aa..54357eb 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -286,6 +286,7 @@ s5p_goni                     arm         armv7       goni                samsung
>  smdkc100                     arm         armv7       smdkc100            samsung        s5pc1xx
>  origen			     arm	 armv7	     origen		 samsung	exynos
>  s5pc210_universal            arm         armv7       universal_c210      samsung        exynos
> +snow			     arm	 armv7	     smdk5250		 samsung	exynos
>  smdk5250		     arm	 armv7	     smdk5250		 samsung	exynos
>  smdkv310		     arm	 armv7	     smdkv310		 samsung	exynos
>  trats                        arm         armv7       trats               samsung        exynos
> diff --git a/include/configs/snow.h b/include/configs/snow.h
> new file mode 100644
> index 0000000..b8460fd
> --- /dev/null
> +++ b/include/configs/snow.h
> @@ -0,0 +1,33 @@
> +/*
> + * Copyright (C) 2013 Samsung Electronics
> + *
> + * Configuration settings for the SAMSUNG EXYNOS5 Snow board.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __CONFIG_SNOW_H
> +#define __CONFIG_SNOW_H
> +
> +#include <configs/exynos5250-dt.h>
> +
> +#undef CONFIG_DEFAULT_DEVICE_TREE
> +#define CONFIG_DEFAULT_DEVICE_TREE	exynos5250-snow
> +
> +#endif	/* __CONFIG_SNOW_H */
> 

Thanks,
Minkyu Kang.
Rajeshwari Birje - Feb. 25, 2013, 10:35 a.m.
Hi Minkyu Kang,

Thank you for comments.

On Mon, Feb 25, 2013 at 9:49 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
>
> Dear Rajeshwari,
>
> On 21/02/13 15:43, Rajeshwari Shinde wrote:
> > This patch adds the configuration file for Snow Board and
> > defines the same in boards.cfg.
> >
> > Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> > ---
> > Changes in V2:
> >       - Added Maintainer
> >  MAINTAINERS            |    4 ++++
> >  boards.cfg             |    1 +
> >  include/configs/snow.h |   33 +++++++++++++++++++++++++++++++++
> >  3 files changed, 38 insertions(+), 0 deletions(-)
> >  create mode 100644 include/configs/snow.h
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 45e2dd4..5fc5b4d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -736,6 +736,10 @@ Chander Kashyap <k.chander@samsung.com>
> >       SMDKV310                ARM ARMV7 (EXYNOS4210 SoC)
> >       SMDK5250                ARM ARMV7 (EXYNOS5250 SoC)
> >
> > +Rajeshwari Shinde <rajeshwari.s@samsung.com>
>
> Please keep this list to alphabetically.
> your name should be moved to "S" section.
I am sorry but I did not find any alphabetical order in MAINTAINERS,
had placed it there because all exynos based board are mentioned
there.
>
> > +
> > +     snow                    ARM ARMV7 (EXYNOS5250 SoC)
> > +
> >  Lukasz Majewski <l.majewski@samsung.com>
> >
> >       trats                   ARM ARMV7 (EXYNOS4210 SoC)
> > diff --git a/boards.cfg b/boards.cfg
> > index b1319aa..54357eb 100644
> > --- a/boards.cfg
> > +++ b/boards.cfg
> > @@ -286,6 +286,7 @@ s5p_goni                     arm         armv7       goni                samsung
> >  smdkc100                     arm         armv7       smdkc100            samsung        s5pc1xx
> >  origen                            arm         armv7       origen              samsung        exynos
> >  s5pc210_universal            arm         armv7       universal_c210      samsung        exynos
> > +snow                      arm         armv7       smdk5250            samsung        exynos
> >  smdk5250                  arm         armv7       smdk5250            samsung        exynos
> >  smdkv310                  arm         armv7       smdkv310            samsung        exynos
> >  trats                        arm         armv7       trats               samsung        exynos
> > diff --git a/include/configs/snow.h b/include/configs/snow.h
> > new file mode 100644
> > index 0000000..b8460fd
> > --- /dev/null
> > +++ b/include/configs/snow.h
> > @@ -0,0 +1,33 @@
> > +/*
> > + * Copyright (C) 2013 Samsung Electronics
> > + *
> > + * Configuration settings for the SAMSUNG EXYNOS5 Snow board.
> > + *
> > + * See file CREDITS for list of people who contributed to this
> > + * project.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> > +#ifndef __CONFIG_SNOW_H
> > +#define __CONFIG_SNOW_H
> > +
> > +#include <configs/exynos5250-dt.h>
> > +
> > +#undef CONFIG_DEFAULT_DEVICE_TREE
> > +#define CONFIG_DEFAULT_DEVICE_TREE   exynos5250-snow
> > +
> > +#endif       /* __CONFIG_SNOW_H */
> >
>
> Thanks,
> Minkyu Kang.
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot




--
Regards,
Rajeshwari Shinde
Minkyu Kang - Feb. 25, 2013, 10:44 a.m.
On 25/02/13 19:35, Rajeshwari Birje wrote:
> Hi Minkyu Kang,
> 
> Thank you for comments.
> 
> On Mon, Feb 25, 2013 at 9:49 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
>>
>> Dear Rajeshwari,
>>
>> On 21/02/13 15:43, Rajeshwari Shinde wrote:
>>> This patch adds the configuration file for Snow Board and
>>> defines the same in boards.cfg.
>>>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>>> ---
>>> Changes in V2:
>>>       - Added Maintainer
>>>  MAINTAINERS            |    4 ++++
>>>  boards.cfg             |    1 +
>>>  include/configs/snow.h |   33 +++++++++++++++++++++++++++++++++
>>>  3 files changed, 38 insertions(+), 0 deletions(-)
>>>  create mode 100644 include/configs/snow.h
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 45e2dd4..5fc5b4d 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -736,6 +736,10 @@ Chander Kashyap <k.chander@samsung.com>
>>>       SMDKV310                ARM ARMV7 (EXYNOS4210 SoC)
>>>       SMDK5250                ARM ARMV7 (EXYNOS5250 SoC)
>>>
>>> +Rajeshwari Shinde <rajeshwari.s@samsung.com>
>>
>> Please keep this list to alphabetically.
>> your name should be moved to "S" section.
> I am sorry but I did not find any alphabetical order in MAINTAINERS,
> had placed it there because all exynos based board are mentioned
> there.
>>

sorted by last name. (Kang -> Kashyap -> Koschorrek...)
Lukasz's position is wrong also.
"Rajeshwari Shinde" should be positioned next to "Bo Shen".

Thanks.
Minkyu Kang.

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 45e2dd4..5fc5b4d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -736,6 +736,10 @@  Chander Kashyap <k.chander@samsung.com>
 	SMDKV310		ARM ARMV7 (EXYNOS4210 SoC)
 	SMDK5250		ARM ARMV7 (EXYNOS5250 SoC)
 
+Rajeshwari Shinde <rajeshwari.s@samsung.com>
+
+	snow			ARM ARMV7 (EXYNOS5250 SoC)
+
 Lukasz Majewski <l.majewski@samsung.com>
 
 	trats			ARM ARMV7 (EXYNOS4210 SoC)
diff --git a/boards.cfg b/boards.cfg
index b1319aa..54357eb 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -286,6 +286,7 @@  s5p_goni                     arm         armv7       goni                samsung
 smdkc100                     arm         armv7       smdkc100            samsung        s5pc1xx
 origen			     arm	 armv7	     origen		 samsung	exynos
 s5pc210_universal            arm         armv7       universal_c210      samsung        exynos
+snow			     arm	 armv7	     smdk5250		 samsung	exynos
 smdk5250		     arm	 armv7	     smdk5250		 samsung	exynos
 smdkv310		     arm	 armv7	     smdkv310		 samsung	exynos
 trats                        arm         armv7       trats               samsung        exynos
diff --git a/include/configs/snow.h b/include/configs/snow.h
new file mode 100644
index 0000000..b8460fd
--- /dev/null
+++ b/include/configs/snow.h
@@ -0,0 +1,33 @@ 
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ *
+ * Configuration settings for the SAMSUNG EXYNOS5 Snow board.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_SNOW_H
+#define __CONFIG_SNOW_H
+
+#include <configs/exynos5250-dt.h>
+
+#undef CONFIG_DEFAULT_DEVICE_TREE
+#define CONFIG_DEFAULT_DEVICE_TREE	exynos5250-snow
+
+#endif	/* __CONFIG_SNOW_H */