Patchwork [2/4] ARM: tegra: add SDHCI support for Dalmore

login
register
mail settings
Submitter Rhyland Klein
Date Feb. 20, 2013, 6:35 p.m.
Message ID <1361385317-6020-3-git-send-email-rklein@nvidia.com>
Download mbox | patch
Permalink /patch/222137/
State Accepted, archived
Headers show

Comments

Rhyland Klein - Feb. 20, 2013, 6:35 p.m.
Based on changes by: Pritesh Raithatha <praithatha@nvidia.com>
Signed-off-by: Rhyland Klein <rklein@nvidia.com>
---
 arch/arm/boot/dts/tegra114-dalmore.dts |   11 +++++++++++
 1 file changed, 11 insertions(+)
Stephen Warren - Feb. 20, 2013, 7:07 p.m.
On 02/20/2013 11:35 AM, Rhyland Klein wrote:
> Based on changes by: Pritesh Raithatha <praithatha@nvidia.com>
> Signed-off-by: Rhyland Klein <rklein@nvidia.com>

A patch description would be useful here. Something simple like:

Dalmore has a built-in eMMC device and a user-accessible SD card slot.
Add device tree nodes to enable these.

The same rebasing comment will apply here too.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rhyland Klein - Feb. 20, 2013, 7:14 p.m.
On 2/20/2013 2:07 PM, Stephen Warren wrote:
> On 02/20/2013 11:35 AM, Rhyland Klein wrote:
>> Based on changes by: Pritesh Raithatha <praithatha@nvidia.com>
>> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
> A patch description would be useful here. Something simple like:
>
> Dalmore has a built-in eMMC device and a user-accessible SD card slot.
> Add device tree nodes to enable these.
>
> The same rebasing comment will apply here too.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Will update patch description for next series.

I can rebase on the cpp usage, but for some stuff like the #define 
replacements, it sounded like things were still being hashed out (like 
.h location, include paths, etc) so I figured its safer not to base on 
those initially. If they are settled by the time i send this out again, 
i can use them as a base.

-rhyland
Stephen Warren - Feb. 20, 2013, 7:16 p.m.
On 02/20/2013 12:14 PM, Rhyland Klein wrote:
> On 2/20/2013 2:07 PM, Stephen Warren wrote:
>> On 02/20/2013 11:35 AM, Rhyland Klein wrote:
>>> Based on changes by: Pritesh Raithatha <praithatha@nvidia.com>
>>> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
>> A patch description would be useful here. Something simple like:
>>
>> Dalmore has a built-in eMMC device and a user-accessible SD card slot.
>> Add device tree nodes to enable these.
>>
>> The same rebasing comment will apply here too.
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Will update patch description for next series.
> 
> I can rebase on the cpp usage, but for some stuff like the #define
> replacements, it sounded like things were still being hashed out (like
> .h location, include paths, etc) so I figured its safer not to base on
> those initially. If they are settled by the time i send this out again,
> i can use them as a base.

Yes, it's not all 100% settled yet; I pointed it out more as a heads-up
that I might ask you to rebase later. There's no need to actively rebase
just yet.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren - March 6, 2013, 9:19 p.m.
On 02/20/2013 12:07 PM, Stephen Warren wrote:
> On 02/20/2013 11:35 AM, Rhyland Klein wrote:
>> Based on changes by: Pritesh Raithatha <praithatha@nvidia.com>
>> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
> 
> A patch description would be useful here. Something simple like:
> 
> Dalmore has a built-in eMMC device and a user-accessible SD card slot.
> Add device tree nodes to enable these.
> 
> The same rebasing comment will apply here too.

I went ahead and applied patches 1/2 and 2/2 to Tegra's for-3.10/dt
branch. I added the commit description I mentioned above.

I think what I'll do for the dtc+cpp usage is to apply patches that come
in before all the dependencies for dtc+cpp are in place, then rebase and
repost my series that converts to use dtc+cpp. That'll save blocking any
other patches on dtc+cpp availability, and save everyone rebasing.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index a30aca6..7be8bd2 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -15,6 +15,17 @@ 
 		clock-frequency = <408000000>;
 	};
 
+	sdhci@78000400 {
+		cd-gpios = <&gpio 170 1>; /* gpio PV2 */
+		bus-width = <4>;
+		status = "okay";
+	};
+
+	sdhci@78000600 {
+		bus-width = <8>;
+		status = "okay";
+	};
+
 	pmc {
 		nvidia,invert-interrupt;
 	};