Patchwork [5/5] qtest: Add boot order test

login
register
mail settings
Submitter Markus Armbruster
Date Feb. 20, 2013, 4:55 p.m.
Message ID <1361379337-15044-6-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/222124/
State New
Headers show

Comments

Markus Armbruster - Feb. 20, 2013, 4:55 p.m.
So far covers only PC, and only -boot order and -no-fd-bootchk, not
option -boot once.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 tests/Makefile          |  2 ++
 tests/boot-order-test.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+)
 create mode 100644 tests/boot-order-test.c

Patch

diff --git a/tests/Makefile b/tests/Makefile
index 567e36e..1305642 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -65,6 +65,7 @@  check-qtest-i386-y = tests/fdc-test$(EXESUF)
 gcov-files-i386-y = hw/fdc.c
 check-qtest-i386-y += tests/hd-geo-test$(EXESUF)
 gcov-files-i386-y += hw/hd-geometry.c
+check-qtest-i386-y += tests/boot-order-test$(EXESUF)
 check-qtest-i386-y += tests/rtc-test$(EXESUF)
 check-qtest-x86_64-y = $(check-qtest-i386-y)
 gcov-files-i386-y += i386-softmmu/hw/mc146818rtc.c
@@ -132,6 +133,7 @@  tests/rtc-test$(EXESUF): tests/rtc-test.o
 tests/m48t59-test$(EXESUF): tests/m48t59-test.o
 tests/fdc-test$(EXESUF): tests/fdc-test.o
 tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o
+tests/boot-order-test$(EXESUF): tests/boot-order-test.o
 tests/tmp105-test$(EXESUF): tests/tmp105-test.o
 
 # QTest rules
diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c
new file mode 100644
index 0000000..0ded010
--- /dev/null
+++ b/tests/boot-order-test.c
@@ -0,0 +1,72 @@ 
+/*
+ * Boot order test cases.
+ *
+ * Copyright (c) 2013 Red Hat Inc.
+ *
+ * Authors:
+ *  Markus Armbruster <armbru@redhat.com>,
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+/*
+ * Covers only PC.  Better than nothing.  Improvements welcome.
+ */
+
+#include <glib.h>
+#include "libqtest.h"
+
+static void test_cmos_byte(int reg, int expected)
+{
+    int actual;
+
+    outb(0x70 + 0, reg);
+    actual = inb(0x71);
+    g_assert(actual == expected);
+}
+
+static void test_cmos(uint8_t boot1, uint8_t boot2)
+{
+    test_cmos_byte(0x38, boot1);
+    test_cmos_byte(0x3d, boot2);
+}
+
+static void test_with_args(const char *args, uint8_t boot1, uint8_t boot2)
+{
+    char *extra_args = g_strdup_printf("-nodefaults -display none %s -S",
+                                             args);
+    qtest_start(extra_args);
+    test_cmos(boot1, boot2);
+    qtest_qmp(global_qtest, "{ 'execute': 'system_reset' }");
+    qtest_quit(global_qtest);
+    g_free(extra_args);
+}
+
+static void test_boot_order(void)
+{
+    test_with_args("", 0x30, 0x12);
+    test_with_args("-no-fd-bootchk", 0x31, 0x12);
+    test_with_args("-boot c", 0, 0x02);
+    test_with_args("-boot nda", 0x10, 0x34);
+    test_with_args("-boot order=", 0, 0);
+    test_with_args("-boot order= -boot order=c", 0, 0x02);
+#if 0
+    /*
+     * FIXME Doesn't work, because qemu resets when qtest_init()
+     * connects to the qtest character device, and that reverts back
+     * to normal boot order.
+     */
+    test_with_args("-boot once=a", 0, 0x01);
+    /* TODO Test that reset changes boot order in CMOS */
+#endif
+}
+
+int main(int argc, char *argv[])
+{
+    g_test_init(&argc, &argv, NULL);
+
+    qtest_add_func("boot-order", test_boot_order);
+
+    return g_test_run();
+}