Patchwork [FWTS-TEST] method-0001: Update because of backlight test code change

login
register
mail settings
Submitter Keng-Yu Lin
Date Feb. 20, 2013, 2:05 p.m.
Message ID <1361369148-7956-1-git-send-email-kengyu@canonical.com>
Download mbox | patch
Permalink /patch/222092/
State Rejected
Headers show

Comments

Keng-Yu Lin - Feb. 20, 2013, 2:05 p.m.
fwts now prints the _BCL levels detail rather than dumping the values
in the package. So udpate to sync up with it too.

Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
---
 method-0001/method-0001.log |   30 ++++++++----------------------
 1 file changed, 8 insertions(+), 22 deletions(-)
Keng-Yu Lin - Feb. 20, 2013, 2:27 p.m.
NAK this one. This is a duplicate patch. Colin already sent a one.

On Wed, Feb 20, 2013 at 10:05 PM, Keng-Yu Lin <kengyu@canonical.com> wrote:
> fwts now prints the _BCL levels detail rather than dumping the values
> in the package. So udpate to sync up with it too.
>
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
> ---
>  method-0001/method-0001.log |   30 ++++++++----------------------
>  1 file changed, 8 insertions(+), 22 deletions(-)
>
> diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log
> index 52cb2d1..da8781e 100644
> --- a/method-0001/method-0001.log
> +++ b/method-0001/method-0001.log
> @@ -938,30 +938,16 @@ method          an integer.
>  method
>  method          Test 132 of 144: Check _BCL (Query List of Brightness
>  method          Control Levels Supported).
> -method            Package has 10 elements:
> -method              00: INTEGER: 0x00000046
> -method              01: INTEGER: 0x00000028
> -method              02: INTEGER: 0x00000000
> -method              03: INTEGER: 0x0000000a
> -method              04: INTEGER: 0x00000014
> -method              05: INTEGER: 0x0000001e
> -method              06: INTEGER: 0x00000028
> -method              07: INTEGER: 0x00000032
> -method              08: INTEGER: 0x0000003c
> -method              09: INTEGER: 0x00000046
> +method          Brightness levels for \_SB_.PCI0.PEGP.VGA_.LCD_._BCL:
> +method            Level on full power   : 70
> +method            Level on battery power: 40
> +method            Brightness Levels     : 0, 10, 20, 30, 40, 50, 60, 70
>  method          PASSED: Test 132, \_SB_.PCI0.PEGP.VGA_.LCD_._BCL returned
>  method          a sane package of 10 integers.
> -method            Package has 10 elements:
> -method              00: INTEGER: 0x00000046
> -method              01: INTEGER: 0x00000028
> -method              02: INTEGER: 0x00000000
> -method              03: INTEGER: 0x0000000a
> -method              04: INTEGER: 0x00000014
> -method              05: INTEGER: 0x0000001e
> -method              06: INTEGER: 0x00000028
> -method              07: INTEGER: 0x00000032
> -method              08: INTEGER: 0x0000003c
> -method              09: INTEGER: 0x00000046
> +method          Brightness levels for \_SB_.PCI0.GFX0.DD03._BCL:
> +method            Level on full power   : 70
> +method            Level on battery power: 40
> +method            Brightness Levels     : 0, 10, 20, 30, 40, 50, 60, 70
>  method          PASSED: Test 132, \_SB_.PCI0.GFX0.DD03._BCL returned a
>  method          sane package of 10 integers.
>  method
> --
> 1.7.9.5
>
Colin King - Feb. 20, 2013, 2:32 p.m.
On 20/02/13 14:27, Keng-Yu Lin wrote:
> NAK this one. This is a duplicate patch. Colin already sent a one.

Sorry, I should have informed you earlier that I was preparing this. 
Thanks anyhow.

Colin

>
> On Wed, Feb 20, 2013 at 10:05 PM, Keng-Yu Lin <kengyu@canonical.com> wrote:
>> fwts now prints the _BCL levels detail rather than dumping the values
>> in the package. So udpate to sync up with it too.
>>
>> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
>> ---
>>   method-0001/method-0001.log |   30 ++++++++----------------------
>>   1 file changed, 8 insertions(+), 22 deletions(-)
>>
>> diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log
>> index 52cb2d1..da8781e 100644
>> --- a/method-0001/method-0001.log
>> +++ b/method-0001/method-0001.log
>> @@ -938,30 +938,16 @@ method          an integer.
>>   method
>>   method          Test 132 of 144: Check _BCL (Query List of Brightness
>>   method          Control Levels Supported).
>> -method            Package has 10 elements:
>> -method              00: INTEGER: 0x00000046
>> -method              01: INTEGER: 0x00000028
>> -method              02: INTEGER: 0x00000000
>> -method              03: INTEGER: 0x0000000a
>> -method              04: INTEGER: 0x00000014
>> -method              05: INTEGER: 0x0000001e
>> -method              06: INTEGER: 0x00000028
>> -method              07: INTEGER: 0x00000032
>> -method              08: INTEGER: 0x0000003c
>> -method              09: INTEGER: 0x00000046
>> +method          Brightness levels for \_SB_.PCI0.PEGP.VGA_.LCD_._BCL:
>> +method            Level on full power   : 70
>> +method            Level on battery power: 40
>> +method            Brightness Levels     : 0, 10, 20, 30, 40, 50, 60, 70
>>   method          PASSED: Test 132, \_SB_.PCI0.PEGP.VGA_.LCD_._BCL returned
>>   method          a sane package of 10 integers.
>> -method            Package has 10 elements:
>> -method              00: INTEGER: 0x00000046
>> -method              01: INTEGER: 0x00000028
>> -method              02: INTEGER: 0x00000000
>> -method              03: INTEGER: 0x0000000a
>> -method              04: INTEGER: 0x00000014
>> -method              05: INTEGER: 0x0000001e
>> -method              06: INTEGER: 0x00000028
>> -method              07: INTEGER: 0x00000032
>> -method              08: INTEGER: 0x0000003c
>> -method              09: INTEGER: 0x00000046
>> +method          Brightness levels for \_SB_.PCI0.GFX0.DD03._BCL:
>> +method            Level on full power   : 70
>> +method            Level on battery power: 40
>> +method            Brightness Levels     : 0, 10, 20, 30, 40, 50, 60, 70
>>   method          PASSED: Test 132, \_SB_.PCI0.GFX0.DD03._BCL returned a
>>   method          sane package of 10 integers.
>>   method
>> --
>> 1.7.9.5
>>
>

Patch

diff --git a/method-0001/method-0001.log b/method-0001/method-0001.log
index 52cb2d1..da8781e 100644
--- a/method-0001/method-0001.log
+++ b/method-0001/method-0001.log
@@ -938,30 +938,16 @@  method          an integer.
 method          
 method          Test 132 of 144: Check _BCL (Query List of Brightness
 method          Control Levels Supported).
-method            Package has 10 elements:
-method              00: INTEGER: 0x00000046
-method              01: INTEGER: 0x00000028
-method              02: INTEGER: 0x00000000
-method              03: INTEGER: 0x0000000a
-method              04: INTEGER: 0x00000014
-method              05: INTEGER: 0x0000001e
-method              06: INTEGER: 0x00000028
-method              07: INTEGER: 0x00000032
-method              08: INTEGER: 0x0000003c
-method              09: INTEGER: 0x00000046
+method          Brightness levels for \_SB_.PCI0.PEGP.VGA_.LCD_._BCL:
+method            Level on full power   : 70
+method            Level on battery power: 40
+method            Brightness Levels     : 0, 10, 20, 30, 40, 50, 60, 70
 method          PASSED: Test 132, \_SB_.PCI0.PEGP.VGA_.LCD_._BCL returned
 method          a sane package of 10 integers.
-method            Package has 10 elements:
-method              00: INTEGER: 0x00000046
-method              01: INTEGER: 0x00000028
-method              02: INTEGER: 0x00000000
-method              03: INTEGER: 0x0000000a
-method              04: INTEGER: 0x00000014
-method              05: INTEGER: 0x0000001e
-method              06: INTEGER: 0x00000028
-method              07: INTEGER: 0x00000032
-method              08: INTEGER: 0x0000003c
-method              09: INTEGER: 0x00000046
+method          Brightness levels for \_SB_.PCI0.GFX0.DD03._BCL:
+method            Level on full power   : 70
+method            Level on battery power: 40
+method            Brightness Levels     : 0, 10, 20, 30, 40, 50, 60, 70
 method          PASSED: Test 132, \_SB_.PCI0.GFX0.DD03._BCL returned a
 method          sane package of 10 integers.
 method