From patchwork Wed Feb 20 07:26:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 221975 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7A2B32C007A for ; Wed, 20 Feb 2013 18:26:59 +1100 (EST) Received: from localhost ([::1]:38747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U844v-0003bv-HE for incoming@patchwork.ozlabs.org; Wed, 20 Feb 2013 02:26:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U844T-0002s0-FZ for qemu-devel@nongnu.org; Wed, 20 Feb 2013 02:26:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U844P-0002zs-9a for qemu-devel@nongnu.org; Wed, 20 Feb 2013 02:26:29 -0500 Received: from mail-da0-f51.google.com ([209.85.210.51]:52755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U844P-0002zm-3h for qemu-devel@nongnu.org; Wed, 20 Feb 2013 02:26:25 -0500 Received: by mail-da0-f51.google.com with SMTP id n15so3382033dad.24 for ; Tue, 19 Feb 2013 23:26:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:in-reply-to:references:x-gm-message-state; bh=zER4amukxtTPJhtw8KxZyAIM1xcuLNhnwSlOyfaYU/w=; b=nb2n3ycHtLL8zEMP6lYsIBiL06acU5000rYU9p4jOk+iOOPLjTc3uB53iFmPH3581Z dNkphU5xA7cMCia5Qg4mVE9ekXWEMWZKjgBK6jzziRPZmAR1rPfpVdpg1ik2lCWqGEKO NwOQPHEXFUI4a5O+dT4S4jbh9A3cnkMLrr1gPUIFq0vGQmveBkfvw/ws9WWfLQDAn4TY ZX8xlxL+zoTkL45ASibX5M8i/tvoKUbHQ3MzlU5hXTXWdySB1DKGhTloYoI1Cza4po1T fAMVz0J7ZMdl2cMdKDeHRxoKbfb7oMMfhmqokexmc2ejJMe1VbPHZSLjnoB9spnhawSJ N0Fg== X-Received: by 10.68.238.103 with SMTP id vj7mr985391pbc.181.1361345184409; Tue, 19 Feb 2013 23:26:24 -0800 (PST) Received: from localhost ([1.133.224.226]) by mx.google.com with ESMTPS id y10sm20753171pbf.39.2013.02.19.23.26.20 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Tue, 19 Feb 2013 23:26:23 -0800 (PST) From: Peter Crosthwaite To: qemu-devel@nongnu.org Date: Wed, 20 Feb 2013 17:26:01 +1000 Message-Id: X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQkKcq1JjVRSbZyfQObQ89V3DiAeL84xfKToJbxmGtepNcZ3uAHv3EADCuvmGsOhEBLHsCoA X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.210.51 Cc: edgar.iglesias@gmail.com, Peter Crosthwaite , peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH v1 1/5] xilinx_spips: Set unused IRQs to NULL X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Unused CS lines should init to 0 to avoid segfaulting when accessing an unattached QSPI controller. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c index 42e019d..3eee828 100644 --- a/hw/xilinx_spips.c +++ b/hw/xilinx_spips.c @@ -497,7 +497,7 @@ static int xilinx_spips_init(SysBusDevice *dev) s->spi[i] = ssi_create_bus(&dev->qdev, bus_name); } - s->cs_lines = g_new(qemu_irq, s->num_cs * s->num_busses); + s->cs_lines = g_new0(qemu_irq, s->num_cs * s->num_busses); ssi_auto_connect_slaves(DEVICE(s), s->cs_lines, s->spi[0]); ssi_auto_connect_slaves(DEVICE(s), s->cs_lines, s->spi[1]); sysbus_init_irq(dev, &s->irq);