From patchwork Tue Feb 19 17:39:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 221889 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E24C42C0079 for ; Wed, 20 Feb 2013 08:00:44 +1100 (EST) Received: from localhost ([::1]:37566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7rCl-0006Y8-6y for incoming@patchwork.ozlabs.org; Tue, 19 Feb 2013 12:42:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7rCF-00063w-Ou for qemu-devel@nongnu.org; Tue, 19 Feb 2013 12:42:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7rC2-00086Y-II for qemu-devel@nongnu.org; Tue, 19 Feb 2013 12:41:39 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:38494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7rC2-00084M-AH for qemu-devel@nongnu.org; Tue, 19 Feb 2013 12:41:26 -0500 Received: by mail-pb0-f46.google.com with SMTP id uo15so2350737pbc.19 for ; Tue, 19 Feb 2013 09:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=VZzpcpzRSab3kEkWha0S7OoGhDTohZi7BAuBabdV9m8=; b=QQtwOVmte4h55Yh4UaCTU3fLr17eDFAGbq5KKmCZsK0/AZKKp1OaK6D8tIIfqsXcys ozPoYryifM2W4zEybN6Bta5Rc0MOji4ZSEiF14ZmkmNwh7BGcEPNUUmiHQxsJXATwNHH 4poMzFV8/4pYmsKLuiL6tdPnSgyo3rJ1MI7AhQek0yFMpnlEaIK34Qt/QG0ZZYwmJ2Cn G94F7NYGGLYbwSkhwnrfWCEANs5P5PdCWbSg4sMh5EAMs3xNE39v3VuPNlzCI9eQbwG4 cLTQ7A0FVwoL0eqhPIWt1Xa5nNJ0MkhHfUzDOoeZM0TjEcif5hqykdL28QT1Npxo8kmH af8A== X-Received: by 10.66.190.226 with SMTP id gt2mr26015585pac.62.1361295682940; Tue, 19 Feb 2013 09:41:22 -0800 (PST) Received: from anchor.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPS id 1sm18659295pbg.18.2013.02.19.09.41.21 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 19 Feb 2013 09:41:22 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 19 Feb 2013 09:39:59 -0800 Message-Id: <1361295631-21316-26-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1361295631-21316-1-git-send-email-rth@twiddle.net> References: <1361295631-21316-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.160.46 Cc: blauwirbel@gmail.com, pbonzini@redhat.com, afaerber@suse.de, aurelien@aurel32.net Subject: [Qemu-devel] [PATCH 25/57] target-i386: optimize setbe X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This is looking at EFLAGS, but it can do so more efficiently with setcond. Reviewed-by: Blue Swirl Signed-off-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target-i386/translate.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index c510732..dab6983 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -1060,10 +1060,9 @@ static void gen_setcc_slow(DisasContext *s, int jcc_op, TCGv reg, bool inv) break; case JCC_BE: gen_compute_eflags(s); - tcg_gen_shri_tl(reg, cpu_cc_src, 6); - tcg_gen_or_tl(reg, reg, cpu_cc_src); - tcg_gen_andi_tl(reg, reg, 1); - break; + tcg_gen_andi_tl(reg, cpu_cc_src, CC_Z | CC_C); + tcg_gen_setcondi_tl(inv ? TCG_COND_EQ : TCG_COND_NE, reg, reg, 0); + return; case JCC_S: gen_compute_eflags_s(s, reg, inv); inv = false;