From patchwork Tue Feb 19 18:48:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [36/81] mm/hugetlb: set PTE as huge in hugetlb_change_protection and remove_migration_pte From: Herton Ronaldo Krzesinski X-Patchwork-Id: 221806 Message-Id: <1361299784-8830-37-git-send-email-herton.krzesinski@canonical.com> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com Cc: Andrew Morton , Linus Torvalds , Zhigang Lu , Chris Metcalf Date: Tue, 19 Feb 2013 15:48:59 -0300 3.5.7.6 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Tony Lu commit be7517d6ab9722f0abad6ba5ffd39cfced95549c upstream. When setting a huge PTE, besides calling pte_mkhuge(), we also need to call arch_make_huge_pte(), which we indeed do in make_huge_pte(), but we forget to do in hugetlb_change_protection() and remove_migration_pte(). Signed-off-by: Zhigang Lu Signed-off-by: Chris Metcalf Reviewed-by: Michal Hocko Acked-by: Hillf Danton Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds [ herton: adjust context ] Signed-off-by: Herton Ronaldo Krzesinski --- mm/hugetlb.c | 1 + mm/migrate.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 9c34eb5..33d8b38 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2972,6 +2972,7 @@ void hugetlb_change_protection(struct vm_area_struct *vma, if (!huge_pte_none(huge_ptep_get(ptep))) { pte = huge_ptep_get_and_clear(mm, address, ptep); pte = pte_mkhuge(pte_modify(pte, newprot)); + pte = arch_make_huge_pte(pte, vma, NULL, 0); set_huge_pte_at(mm, address, ptep, pte); } } diff --git a/mm/migrate.c b/mm/migrate.c index be26d5c..2e03986 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -142,8 +142,10 @@ static int remove_migration_pte(struct page *new, struct vm_area_struct *vma, if (is_write_migration_entry(entry)) pte = pte_mkwrite(pte); #ifdef CONFIG_HUGETLB_PAGE - if (PageHuge(new)) + if (PageHuge(new)) { pte = pte_mkhuge(pte); + pte = arch_make_huge_pte(pte, vma, new, 0); + } #endif flush_cache_page(vma, addr, pte_pfn(pte)); set_pte_at(mm, addr, ptep, pte);