From patchwork Tue Feb 19 17:39:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 221767 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 87F4D2C0090 for ; Wed, 20 Feb 2013 05:40:04 +1100 (EST) Received: from localhost ([::1]:48287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7s6k-0004aV-HG for incoming@patchwork.ozlabs.org; Tue, 19 Feb 2013 13:40:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7rCE-00063t-UC for qemu-devel@nongnu.org; Tue, 19 Feb 2013 12:41:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7rC1-00085u-W0 for qemu-devel@nongnu.org; Tue, 19 Feb 2013 12:41:38 -0500 Received: from mail-da0-f53.google.com ([209.85.210.53]:61519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7rC0-000822-QV for qemu-devel@nongnu.org; Tue, 19 Feb 2013 12:41:25 -0500 Received: by mail-da0-f53.google.com with SMTP id w3so3044710dad.26 for ; Tue, 19 Feb 2013 09:41:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=H/64x7mspmwNUo52zUqny6hTJg22xMRwj9k4pdqAn5U=; b=I31UbxsI+czMd4BmzoFLMLpq7ylvkYlSlvN+5lkRcxSZS4tryoanQF9nhO7ob+Z1bv YTAxtANYn0/gInxVCKNKyMdMrdNMcbHYXir9+TsnEyIjD0RlK98RNA9BxB5vnLzMCGMg f0oNru/sV3FfAmsBfup5ZdAoDAauaI4ANH01Shh9F3I9Eto0tXRpR8WH/6qeGY2M2Ctl fFB8hTvyTtBiJw4teSFmkV/KTBOkoS1/29rpWjWZOXDuCJj2drqpHX/OeJppK1onsa8E bdGikC2XJ6YYhx4pwIoUhYmfo++1UOWgO7LXMpVOrhRQ/3mlULJlwZNQpBiR9j/DWBPe NBXw== X-Received: by 10.68.189.169 with SMTP id gj9mr42997338pbc.67.1361295672212; Tue, 19 Feb 2013 09:41:12 -0800 (PST) Received: from anchor.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPS id 1sm18659295pbg.18.2013.02.19.09.41.10 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 19 Feb 2013 09:41:11 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 19 Feb 2013 09:39:53 -0800 Message-Id: <1361295631-21316-20-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1361295631-21316-1-git-send-email-rth@twiddle.net> References: <1361295631-21316-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.210.53 Cc: blauwirbel@gmail.com, pbonzini@redhat.com, afaerber@suse.de, aurelien@aurel32.net Subject: [Qemu-devel] [PATCH 19/57] target-i386: no need to flush out cc_op before gen_eob X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This makes code more similar to the other callers of gen_eob, especially loopz/loopnz/jcxz. Signed-off-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target-i386/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 6204764..71104fb 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -2303,8 +2303,8 @@ static inline void gen_jcc(DisasContext *s, int b, { int l1, l2; - gen_update_cc_op(s); if (s->jmp_opt) { + gen_update_cc_op(s); l1 = gen_new_label(); gen_jcc1(s, b, l1); set_cc_op(s, CC_OP_DYNAMIC); @@ -2315,11 +2315,9 @@ static inline void gen_jcc(DisasContext *s, int b, gen_goto_tb(s, 1, val); s->is_jmp = DISAS_TB_JUMP; } else { - l1 = gen_new_label(); l2 = gen_new_label(); gen_jcc1(s, b, l1); - set_cc_op(s, CC_OP_DYNAMIC); gen_jmp_im(next_eip); tcg_gen_br(l2);