Patchwork [2/6] qcow2: flush refcount cache correctly in qcow2_write_snapshots()

login
register
mail settings
Submitter Stefan Hajnoczi
Date Feb. 19, 2013, 3:45 p.m.
Message ID <1361288706-13929-3-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/221716/
State New
Headers show

Comments

Stefan Hajnoczi - Feb. 19, 2013, 3:45 p.m.
Since qcow2 metadata is cached we need to flush the caches, not just the
underlying file.  Use bdrv_flush(bs) instead of bdrv_flush(bs->file).

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 block/qcow2-snapshot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index eb8fcd5..429bbff 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
@@ -180,7 +180,7 @@  static int qcow2_write_snapshots(BlockDriverState *bs)
 
     /* Allocate space for the new snapshot list */
     snapshots_offset = qcow2_alloc_clusters(bs, snapshots_size);
-    bdrv_flush(bs->file);
+    bdrv_flush(bs);
     offset = snapshots_offset;
     if (offset < 0) {
         return offset;