From patchwork Tue Feb 19 14:12:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 221705 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6B5362C007E for ; Wed, 20 Feb 2013 01:13:25 +1100 (EST) Received: from localhost ([::1]:59341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7nwh-000414-HH for incoming@patchwork.ozlabs.org; Tue, 19 Feb 2013 09:13:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7nwX-0003xO-Br for qemu-devel@nongnu.org; Tue, 19 Feb 2013 09:13:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7nwQ-0004Ov-Sx for qemu-devel@nongnu.org; Tue, 19 Feb 2013 09:13:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7nwQ-0004Ob-Kw for qemu-devel@nongnu.org; Tue, 19 Feb 2013 09:13:06 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1JECcnd022099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Feb 2013 09:12:39 -0500 Received: from localhost (ovpn-112-41.ams2.redhat.com [10.36.112.41]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1JECbE6020476; Tue, 19 Feb 2013 09:12:38 -0500 From: Stefan Hajnoczi To: Date: Tue, 19 Feb 2013 15:12:34 +0100 Message-Id: <1361283154-11534-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Michael Roth , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH] qemu-ga: fix confusing GAChannelMethod comparison X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In commit 7868e26e5930f49ca942311885776b938dcf3b77 ("qemu-ga: add initial win32 support") support was added for qemu-ga on Windows using virtio-serial. Other channel methods (ISA serial and UNIX domain socket) are not supported on Windows. Signed-off-by: Stefan Hajnoczi --- qga/channel-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 16bf44a..7ed98d7 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -287,7 +287,7 @@ GIOStatus ga_channel_write_all(GAChannel *c, const char *buf, size_t size) static gboolean ga_channel_open(GAChannel *c, GAChannelMethod method, const gchar *path) { - if (!method == GA_CHANNEL_VIRTIO_SERIAL) { + if (method != GA_CHANNEL_VIRTIO_SERIAL) { g_critical("unsupported communication method"); return false; }