Patchwork [2/2] coroutine: trim down nesting level in perf_nesting test

login
register
mail settings
Submitter Paolo Bonzini
Date Feb. 19, 2013, 10:59 a.m.
Message ID <1361271550-18519-2-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/221665/
State New
Headers show

Comments

Paolo Bonzini - Feb. 19, 2013, 10:59 a.m.
20000 nested coroutines require 20 GB of virtual address space.
Only nest 1000 of them so that the test (only enabled with
"-m perf" on the command line) runs on 32-bit machines too.

Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/test-coroutine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefan Hajnoczi - Feb. 20, 2013, 9:20 a.m.
On Tue, Feb 19, 2013 at 11:59:10AM +0100, Paolo Bonzini wrote:
> 20000 nested coroutines require 20 GB of virtual address space.
> Only nest 1000 of them so that the test (only enabled with
> "-m perf" on the command line) runs on 32-bit machines too.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/test-coroutine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Okay, 20000 nesting level was unrealistic and QEMU will never approach
that in reality.  1000 is fine.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Patch

diff --git a/tests/test-coroutine.c b/tests/test-coroutine.c
index 4c6cc81..39be046 100644
--- a/tests/test-coroutine.c
+++ b/tests/test-coroutine.c
@@ -183,7 +183,7 @@  static void perf_nesting(void)
     double duration;
 
     maxcycles = 100000000;
-    maxnesting = 20000;
+    maxnesting = 1000;
     Coroutine *root;
     NestData nd = {
         .n_enter  = 0,