Patchwork ext4: fix a warning from sparse check for ext4_dir_llseek

login
register
mail settings
Submitter Zheng Liu
Date Feb. 19, 2013, 9:08 a.m.
Message ID <1361264926-8908-1-git-send-email-wenqing.lz@taobao.com>
Download mbox | patch
Permalink /patch/221649/
State Accepted
Headers show

Comments

Zheng Liu - Feb. 19, 2013, 9:08 a.m.
From: Zheng Liu <wenqing.lz@taobao.com>

ext4_dir_llseek is only used as a callback function, and no one calls
it directly.  So make it as a static function in order to remove a
warning message from sparse check.

Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
 fs/ext4/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Theodore Ts'o - March 2, 2013, 10:25 p.m.
On Tue, Feb 19, 2013 at 05:08:46PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
> 
> ext4_dir_llseek is only used as a callback function, and no one calls
> it directly.  So make it as a static function in order to remove a
> warning message from sparse check.
> 
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index 80a28b2..39460ac 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -333,7 +333,7 @@  static inline loff_t ext4_get_htree_eof(struct file *filp)
  *
  * For non-htree, ext4_llseek already chooses the proper max offset.
  */
-loff_t ext4_dir_llseek(struct file *file, loff_t offset, int whence)
+static loff_t ext4_dir_llseek(struct file *file, loff_t offset, int whence)
 {
 	struct inode *inode = file->f_mapping->host;
 	int dx_dir = is_dx_dir(inode);