Patchwork [RFC,4/4] block: add vhdx to Makefile.obj for compile

login
register
mail settings
Submitter Jeff Cody
Date Feb. 18, 2013, 11:03 p.m.
Message ID <a6a87f1375374cdb0dea1bdac4a69c22e7600fe0.1361228069.git.jcody@redhat.com>
Download mbox | patch
Permalink /patch/221549/
State New
Headers show

Comments

Jeff Cody - Feb. 18, 2013, 11:03 p.m.
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/Makefile.objs | 1 +
 1 file changed, 1 insertion(+)
Kevin Wolf - Feb. 19, 2013, 2:23 p.m.
On Mon, Feb 18, 2013 at 06:03:32PM -0500, Jeff Cody wrote:
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  block/Makefile.objs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index c067f38..a819577 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -2,6 +2,7 @@ block-obj-y += raw.o cow.o qcow.o vdi.o vmdk.o cloop.o dmg.o bochs.o vpc.o vvfat
>  block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o qcow2-snapshot.o qcow2-cache.o
>  block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cluster.o
>  block-obj-y += qed-check.o
> +block-obj-y += vhdx.o
>  block-obj-y += parallels.o blkdebug.o blkverify.o
>  block-obj-$(CONFIG_WIN32) += raw-win32.o win32-aio.o
>  block-obj-$(CONFIG_POSIX) += raw-posix.o

There's no reason for this to be a separate patch. Please merge it with
patch 3.

I think the series may well grow to a point where splitting it into
multiple patches becomes necessary, but even then it should be split
by adding a piece of functionality in each step, not by putting each
file in a separate patch.

Kevin
Jeff Cody - Feb. 19, 2013, 2:41 p.m.
On Tue, Feb 19, 2013 at 03:23:35PM +0100, Kevin Wolf wrote:
> On Mon, Feb 18, 2013 at 06:03:32PM -0500, Jeff Cody wrote:
> > 
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > ---
> >  block/Makefile.objs | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/block/Makefile.objs b/block/Makefile.objs
> > index c067f38..a819577 100644
> > --- a/block/Makefile.objs
> > +++ b/block/Makefile.objs
> > @@ -2,6 +2,7 @@ block-obj-y += raw.o cow.o qcow.o vdi.o vmdk.o cloop.o dmg.o bochs.o vpc.o vvfat
> >  block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o qcow2-snapshot.o qcow2-cache.o
> >  block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cluster.o
> >  block-obj-y += qed-check.o
> > +block-obj-y += vhdx.o
> >  block-obj-y += parallels.o blkdebug.o blkverify.o
> >  block-obj-$(CONFIG_WIN32) += raw-win32.o win32-aio.o
> >  block-obj-$(CONFIG_POSIX) += raw-posix.o
> 
> There's no reason for this to be a separate patch. Please merge it with
> patch 3.
>

OK.

> I think the series may well grow to a point where splitting it into
> multiple patches becomes necessary, but even then it should be split
> by adding a piece of functionality in each step, not by putting each
> file in a separate patch.
> 
> Kevin

I agree.  I am thinking something like: add in each parsing step
individually (header section, region tables, then metadata) and then
all the normal read/write support. And I also think it may end up a
good idea to split vhdx.c it up into more than one source file (like
e.q. qcow2 & qed).

Thanks, Jeff

Patch

diff --git a/block/Makefile.objs b/block/Makefile.objs
index c067f38..a819577 100644
--- a/block/Makefile.objs
+++ b/block/Makefile.objs
@@ -2,6 +2,7 @@  block-obj-y += raw.o cow.o qcow.o vdi.o vmdk.o cloop.o dmg.o bochs.o vpc.o vvfat
 block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o qcow2-snapshot.o qcow2-cache.o
 block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cluster.o
 block-obj-y += qed-check.o
+block-obj-y += vhdx.o
 block-obj-y += parallels.o blkdebug.o blkverify.o
 block-obj-$(CONFIG_WIN32) += raw-win32.o win32-aio.o
 block-obj-$(CONFIG_POSIX) += raw-posix.o