From patchwork Mon Feb 18 19:54:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 221460 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 224092C0294 for ; Tue, 19 Feb 2013 06:55:34 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1361822135; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Subject:Message-ID:Mail-Followup-To:MIME-Version: Content-Type:Content-Disposition:User-Agent:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=nzuj7Kciq369FKQeq/SfpoeBVuc=; b=uwqG8hKL6sEg631tV1LG8rIJhq9H9qBtF/y19/x8Zblb5c/t+uAozLVIUmeDGn ZOeqypA0Bb0kBzREr0u5FDq43PEfj8lThEmTxF5GTxz3CUsGc9t52c1L8o8n1XMH SQGrDG+gLABD3rZmZ0StaaJmQgZ5pEqzojxC6Y+SzRhFY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Subject:Message-ID:Mail-Followup-To:MIME-Version:Content-Type:Content-Disposition:User-Agent:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=kTGR8N1k2jQS5iwXlMWA2OtNyB8/CMkKuIQMSBFuJJ1gpvB3Z0G0pan8vLVSNm 0tExsKMbd1wa73xQQCG+MLEwGLpAMzBh2qMqAkN4sc7HFixUlGANcyKdIX2/n5lD W2LCD+eIdhemQchU1T7dpZeUnLsiR2mjjns7UY9/HAH50=; Received: (qmail 20774 invoked by alias); 18 Feb 2013 19:54:47 -0000 Received: (qmail 20720 invoked by uid 22791); 18 Feb 2013 19:54:45 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Feb 2013 19:54:37 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C9834A398F for ; Mon, 18 Feb 2013 20:54:35 +0100 (CET) Date: Mon, 18 Feb 2013 20:54:35 +0100 From: Martin Jambor To: GCC Patches Subject: [PATCH] Fix a thinko in dumping in ipa-cp.c Message-ID: <20130218195435.GA19120@virgil.suse> Mail-Followup-To: GCC Patches MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, in ipa-cp there is a dumping condition that was intended to trigger for non-aliases and non-thunks but I have lost the negations somewhere when introducing the code. This probably shows this particular dumping is not very crucial but I think it summarizes the initialization well and decided to keep it. The following patch has successfully bootstrapped and passed testsuite on x86_64-linux, I intend to commit it as obvious tomorrow unless someone objects. Thanks, Martin 2013-02-07 Martin Jambor * ipa-cp.c (initialize_node_lattices): Fix dumping condition. Index: src/gcc/ipa-cp.c =================================================================== --- src.orig/gcc/ipa-cp.c +++ src/gcc/ipa-cp.c @@ -725,7 +725,7 @@ initialize_node_lattices (struct cgraph_ set_all_contains_variable (plats); } if (dump_file && (dump_flags & TDF_DETAILS) - && node->alias && node->thunk.thunk_p) + && !node->alias && !node->thunk.thunk_p) fprintf (dump_file, "Marking all lattices of %s/%i as %s\n", cgraph_node_name (node), node->uid, disable ? "BOTTOM" : "VARIABLE");