Patchwork ipv6: xfrm6_mode_tunnel: Fix warning

login
register
mail settings
Submitter Fabio Estevam
Date Feb. 18, 2013, 2:15 p.m.
Message ID <1361196930-25531-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/221398/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Fabio Estevam - Feb. 18, 2013, 2:15 p.m.
Fix the following warning:

net/ipv6/xfrm6_mode_tunnel.c:72:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses]

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 net/ipv6/xfrm6_mode_tunnel.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

diff --git a/net/ipv6/xfrm6_mode_tunnel.c b/net/ipv6/xfrm6_mode_tunnel.c
index 93c41a8..9bf6a74 100644
--- a/net/ipv6/xfrm6_mode_tunnel.c
+++ b/net/ipv6/xfrm6_mode_tunnel.c
@@ -69,7 +69,8 @@  static int xfrm6_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)
 	if (!pskb_may_pull(skb, sizeof(struct ipv6hdr)))
 		goto out;
 
-	if (err = skb_unclone(skb, GFP_ATOMIC))
+	err = skb_unclone(skb, GFP_ATOMIC);
+	if (err)
 		goto out;
 
 	if (x->props.flags & XFRM_STATE_DECAP_DSCP)