Patchwork ipv4: xfrm4_mode_tunnel: Fix warning

login
register
mail settings
Submitter Fabio Estevam
Date Feb. 18, 2013, 1:45 p.m.
Message ID <1361195127-17889-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/221385/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Fabio Estevam - Feb. 18, 2013, 1:45 p.m.
Fix the following warning:

net/ipv4/xfrm4_mode_tunnel.c:145:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses]

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 net/ipv4/xfrm4_mode_tunnel.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
David Miller - Feb. 18, 2013, 5:42 p.m.
Stephen Hemminger already submitted the patches necessary to fix these
warnings.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv4/xfrm4_mode_tunnel.c b/net/ipv4/xfrm4_mode_tunnel.c
index 1162ace..fe5189e 100644
--- a/net/ipv4/xfrm4_mode_tunnel.c
+++ b/net/ipv4/xfrm4_mode_tunnel.c
@@ -142,7 +142,8 @@  static int xfrm4_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)
 	for_each_input_rcu(rcv_notify_handlers, handler)
 		handler->handler(skb);
 
-	if (err = skb_unclone(skb, GFP_ATOMIC))
+	err = skb_unclone(skb, GFP_ATOMIC);
+	if (err)
 		goto out;
 
 	if (x->props.flags & XFRM_STATE_DECAP_DSCP)