From patchwork Mon Feb 18 13:39:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 221384 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A000B2C0095 for ; Tue, 19 Feb 2013 00:40:22 +1100 (EST) Received: from localhost ([::1]:46637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7Qx7-0002e7-Aj for incoming@patchwork.ozlabs.org; Mon, 18 Feb 2013 08:40:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7Qwo-0002Xk-QV for qemu-devel@nongnu.org; Mon, 18 Feb 2013 08:40:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U7Qwm-0001jX-11 for qemu-devel@nongnu.org; Mon, 18 Feb 2013 08:39:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U7Qwl-0001jI-Pl for qemu-devel@nongnu.org; Mon, 18 Feb 2013 08:39:55 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1IDdmuq020098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Feb 2013 08:39:48 -0500 Received: from localhost (ovpn-112-30.ams2.redhat.com [10.36.112.30]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1IDdk9K007246; Mon, 18 Feb 2013 08:39:47 -0500 Date: Mon, 18 Feb 2013 14:39:46 +0100 From: Stefan Hajnoczi To: KONRAD =?iso-8859-1?Q?Fr=E9d=E9ric?= Message-ID: <20130218133946.GA10700@stefanha-thinkpad.redhat.com> References: <1360575449-10445-1-git-send-email-fred.konrad@greensocs.com> <512203B1.3070503@greensocs.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <512203B1.3070503@greensocs.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id r1IDdmuq020098 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, cornelia.huck@de.ibm.com, afaerber@suse.de Subject: Re: [Qemu-devel] [PATCH for-1.5 0/8] virtio-blk refactoring. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, Feb 18, 2013 at 11:34:25AM +0100, KONRAD Frédéric wrote: > On 11/02/2013 10:37, fred.konrad@greensocs.com wrote: > >From: KONRAD Frederic > > > >This is the next part of virtio-refactoring. > > > >I send it now to have it reviewed. > > > >Basically it creates virtio-blk device which extends virtio-device. > >Then a virtio-blk can be connected on a virtio-bus. > >virtio-blk-pci, virtio-blk-s390x, virtio-blk-ccw are created too, they extend > >respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a > >virtio-blk. > > > >It is on top of "virtio: make virtio device's structures public" I posted > >before, but you can checkout my branch here: > > > >git://git.greensocs.com/qemu_virtio.git virtio-blk-v4 > > > >I made basic tests (with linux guests) on: > > * qemu-system-i386 > > * qemu-system-s390x > > > >I didn't test dataplane as I don't know how it works? Depends on linux AIO? > > > >Stefan can you try launching dataplane with my tree? It works after I apply this small patch: diff --git a/hw/virtio-blk.h b/hw/virtio-blk.h index f281ac3..0f964a7 100644 --- a/hw/virtio-blk.h +++ b/hw/virtio-blk.h @@ -16,6 +16,7 @@ #include "virtio.h" #include "hw/block-common.h" +#include "hw/dataplane/virtio-blk.h" #define TYPE_VIRTIO_BLK "virtio-blk" #define VIRTIO_BLK(obj) \