Patchwork [for-1.5,0/8] virtio-blk refactoring.

login
register
mail settings
Submitter Stefan Hajnoczi
Date Feb. 18, 2013, 1:39 p.m.
Message ID <20130218133946.GA10700@stefanha-thinkpad.redhat.com>
Download mbox | patch
Permalink /patch/221384/
State New
Headers show

Comments

Stefan Hajnoczi - Feb. 18, 2013, 1:39 p.m.
On Mon, Feb 18, 2013 at 11:34:25AM +0100, KONRAD Frédéric wrote:
> On 11/02/2013 10:37, fred.konrad@greensocs.com wrote:
> >From: KONRAD Frederic <fred.konrad@greensocs.com>
> >
> >This is the next part of virtio-refactoring.
> >
> >I send it now to have it reviewed.
> >
> >Basically it creates virtio-blk device which extends virtio-device.
> >Then a virtio-blk can be connected on a virtio-bus.
> >virtio-blk-pci, virtio-blk-s390x, virtio-blk-ccw are created too, they extend
> >respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a
> >virtio-blk.
> >
> >It is on top of "virtio: make virtio device's structures public" I posted
> >before, but you can checkout my branch here:
> >
> >git://git.greensocs.com/qemu_virtio.git virtio-blk-v4
> >
> >I made basic tests (with linux guests) on:
> >  * qemu-system-i386
> >  * qemu-system-s390x
> >
> >I didn't test dataplane as I don't know how it works? Depends on linux AIO?
> >
> >Stefan can you try launching dataplane with my tree?

It works after I apply this small patch:

Patch

diff --git a/hw/virtio-blk.h b/hw/virtio-blk.h
index f281ac3..0f964a7 100644
--- a/hw/virtio-blk.h
+++ b/hw/virtio-blk.h
@@ -16,6 +16,7 @@ 
 
 #include "virtio.h"
 #include "hw/block-common.h"
+#include "hw/dataplane/virtio-blk.h"
 
 #define TYPE_VIRTIO_BLK "virtio-blk"
 #define VIRTIO_BLK(obj) \