From patchwork Mon Feb 18 12:48:31 2013
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: block: complete all IOs before .bdrv_truncate
Date: Mon, 18 Feb 2013 02:48:31 -0000
From: Peter Lieven <pl@dlhnet.de>
X-Patchwork-Id: 221299
Message-Id: <5122231F.8070309@dlhnet.de>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
 ronnie sahlberg <ronniesahlberg@gmail.com>

bdrv_truncate() invalidates the bdrv_check_request() result for
in-flight requests, so there should better be none.

Signed-off-by: Peter Lieven <pl@kamp.de>
Reported-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

---
block.c |    4 ++++
  1 file changed, 4 insertions(+)

diff --git a/block.c b/block.c
index 50dab8e..d8880e3 100644
--- a/block.c
+++ b/block.c
@@ -2427,6 +2427,10 @@ int bdrv_truncate(BlockDriverState *bs, int64_t offset)
          return -EACCES;
      if (bdrv_in_use(bs))
          return -EBUSY;
+
+    /* there should be better no IOs in flight when we truncate the device */
+    bdrv_drain_all();
+
      ret = drv->bdrv_truncate(bs, offset);
      if (ret == 0) {
          ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS);