| Message ID | 1361187031-3679-2-git-send-email-wni@nvidia.com |
|---|---|
| State | RFC, archived |
| Headers | show |
On 02/18/2013 08:30 PM, Wei Ni wrote: > Enable thermal sensor lm90 in the dts file. Acked-by: Alexandre Courbot <acourbot@nvidia.com> Btw, shouldn't this patch come last, after all the changes you did to lm90? If you keep the current order, you will need to ensure that the device performs as expected on Cardhu for each of the remaining patches of the series. It is probably safer to just move this one at the end to avoid trouble. Alex. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/19/2013 11:28 AM, Alex Courbot wrote: > On 02/18/2013 08:30 PM, Wei Ni wrote: >> Enable thermal sensor lm90 in the dts file. > > Acked-by: Alexandre Courbot <acourbot@nvidia.com> > > Btw, shouldn't this patch come last, after all the changes you did to > lm90? If you keep the current order, you will need to ensure that the > device performs as expected on Cardhu for each of the remaining patches > of the series. It is probably safer to just move this one at the end to > avoid trouble. I will try split this patch set into 3 separate sets in my next version, like Matthew's suggestion, so the patches will be clear. Wei. > > Alex. > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/18/2013 08:28 PM, Alex Courbot wrote: > On 02/18/2013 08:30 PM, Wei Ni wrote: >> Enable thermal sensor lm90 in the dts file. > > Acked-by: Alexandre Courbot <acourbot@nvidia.com> > > Btw, shouldn't this patch come last, after all the changes you did to > lm90? If you keep the current order, you will need to ensure that the > device performs as expected on Cardhu for each of the remaining patches > of the series. It is probably safer to just move this one at the end to > avoid trouble. Hmm. This patch on its own seems simple enough, and so I should really just apply it as soon as 3.9-rc1 is out. Note that we (and probably others) have many device trees for boards besides Cardhu that instantiate the LM90 driver. The driver has to continue to work perfectly for all the patches in the series. Not enabling the driver on Cardhu isn't enough to allow patches in the middle of the series to break the already-working driver. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi index bdb2a66..15ad1ad 100644 --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi @@ -273,6 +273,13 @@ }; }; }; + + nct1008: lm90@4c { + compatible = "lm90"; + reg = <0x4c>; + interrupt-parent = <&gpio>; + interrupts = <226 0x08>; /* gpio PCC2 */ + }; }; spi@7000da00 {
Enable thermal sensor lm90 in the dts file. Signed-off-by: Wei Ni <wni@nvidia.com> --- arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)