Patchwork [U-Boot,v3] Allow AM33xx boards to setup GPMC chipselects.

login
register
mail settings
Submitter Mark Jackson
Date Feb. 18, 2013, 10:08 a.m.
Message ID <5121FDAD.2060100@mimc.co.uk>
Download mbox | patch
Permalink /patch/221182/
State Superseded
Delegated to: Tom Rini
Headers show

Comments

Mark Jackson - Feb. 18, 2013, 10:08 a.m.
Expose the enable_gpmc_cs_config() function so AM33xx based boards can register GPMC chip selects.

Changes in V3:
- Fix line wrapping

Changes in V2:
- Indicate this is for AM33xx (not OMAP2)

Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
---
 arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
 1 file changed, 2 insertions(+)
Peter Korsgaard - Feb. 18, 2013, 11:01 a.m.
>>>>> "Mark" == Mark Jackson <mpfj-list@mimc.co.uk> writes:

 Mark> Expose the enable_gpmc_cs_config() function so AM33xx based boards can register GPMC chip selects.
 Mark> Changes in V3:
 Mark> - Fix line wrapping

 Mark> Changes in V2:
 Mark> - Indicate this is for AM33xx (not OMAP2)

 Mark> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
 Mark> ---
 Mark>  arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
 Mark>  1 file changed, 2 insertions(+)

 Mark> diff --git a/arch/arm/include/asm/arch-am33xx/sys_proto.h b/arch/arm/include/asm/arch-am33xx/sys_proto.h
 Mark> index 588d8de..97ab60d 100644
 Mark> --- a/arch/arm/include/asm/arch-am33xx/sys_proto.h
 Mark> +++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h
 Mark> @@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
 Mark>   void sdelay(unsigned long);
 Mark>  void gpmc_init(void);
 Mark> +void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
 Mark> +            u32 size);

Checkpatch still complains. How about wrapping after *cs, and properly
aligning the next line?
Mark Jackson - Feb. 18, 2013, 11:27 a.m.
On 18/02/13 11:01, Peter Korsgaard wrote:
>>>>>> "Mark" == Mark Jackson <mpfj-list@mimc.co.uk> writes:
> 
>  Mark> Expose the enable_gpmc_cs_config() function so AM33xx based boards can register GPMC chip selects.
>  Mark> Changes in V3:
>  Mark> - Fix line wrapping
> 
>  Mark> Changes in V2:
>  Mark> - Indicate this is for AM33xx (not OMAP2)
> 
>  Mark> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
>  Mark> ---
>  Mark>  arch/arm/include/asm/arch-am33xx/sys_proto.h |    2 ++
>  Mark>  1 file changed, 2 insertions(+)
> 
>  Mark> diff --git a/arch/arm/include/asm/arch-am33xx/sys_proto.h b/arch/arm/include/asm/arch-am33xx/sys_proto.h
>  Mark> index 588d8de..97ab60d 100644
>  Mark> --- a/arch/arm/include/asm/arch-am33xx/sys_proto.h
>  Mark> +++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h
>  Mark> @@ -35,5 +35,7 @@ void ddr_pll_config(unsigned int ddrpll_M);
>  Mark>   void sdelay(unsigned long);
>  Mark>  void gpmc_init(void);
>  Mark> +void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
>  Mark> +            u32 size);
> 
> Checkpatch still complains. How about wrapping after *cs, and properly
> aligning the next line?
> 

Grrrr ... stupid mailer programs !!

Hopefully v4 is now correct ...

Mark J.

Patch

diff --git a/arch/arm/include/asm/arch-am33xx/sys_proto.h b/arch/arm/include/asm/arch-am33xx/sys_proto.h
index 588d8de..97ab60d 100644
--- a/arch/arm/include/asm/arch-am33xx/sys_proto.h
+++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h
@@ -35,5 +35,7 @@  void ddr_pll_config(unsigned int ddrpll_M);
  void sdelay(unsigned long);
 void gpmc_init(void);
+void enable_gpmc_cs_config(const u32 *gpmc_config, struct gpmc_cs *cs, u32 base,
+            u32 size);
 void omap_nand_switch_ecc(int);
 #endif
-- 
1.7.9.5