Patchwork [U-Boot,v3] powerpc/usb: Fix usb device-tree fix-up

login
register
mail settings
Submitter ramneek mehresh
Date Feb. 18, 2013, 4:23 a.m.
Message ID <1361161412-11519-1-git-send-email-ramneek.mehresh@freescale.com>
Download mbox | patch
Permalink /patch/221144/
State Accepted
Delegated to: Marek Vasut
Headers show

Comments

ramneek mehresh - Feb. 18, 2013, 4:23 a.m.
Fix USB device-tree fixup to properly handle device-tree fixup and
print appropriate message when wrong/junk "dr_mode" or "phy_type"
are mentioned in hwconfig string

Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
---
Changes for v3:
        - used puts instead of printf
        - error message in one line

 arch/powerpc/cpu/mpc8xxx/fdt.c | 5 +++++
 1 file changed, 5 insertions(+)

Patch

diff --git a/arch/powerpc/cpu/mpc8xxx/fdt.c b/arch/powerpc/cpu/mpc8xxx/fdt.c
index 2847094..2db9045 100644
--- a/arch/powerpc/cpu/mpc8xxx/fdt.c
+++ b/arch/powerpc/cpu/mpc8xxx/fdt.c
@@ -167,6 +167,11 @@  void fdt_fixup_dr_usb(void *blob, bd_t *bd)
 				}
 			}
 
+			if (mode_idx < 0 || phy_idx < 0) {
+				puts("ERROR: wrong usb mode/phy defined!!\n");
+				return;
+			}
+
 			dr_mode_type = modes[mode_idx];
 			dr_phy_type = phys[phy_idx];