From patchwork Mon Feb 18 03:01:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 221137 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 18EF22C0085 for ; Mon, 18 Feb 2013 14:02:14 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754829Ab3BRDCJ (ORCPT ); Sun, 17 Feb 2013 22:02:09 -0500 Received: from mail-gh0-f169.google.com ([209.85.160.169]:55710 "EHLO mail-gh0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508Ab3BRDCH (ORCPT ); Sun, 17 Feb 2013 22:02:07 -0500 Received: by mail-gh0-f169.google.com with SMTP id r18so503902ghr.14 for ; Sun, 17 Feb 2013 19:02:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer; bh=JZUfXYll4lRqizaqfTAU55KecjOLqW2lHYpS0evBLtw=; b=mWPl1bnJgOt2mpTCDM7VbEqgf8kqVR0OkmzFN0ckwTuLHShElmjXq/LbrlCd0lfmml sOE3CCNxNpOGBiAXZ6HKNMaQO4+RTrz7gj/VcjGt3B+d5YcYXcqhBfLCkidsMMY6a+Js Q03mqgjNdzEpsqrRoKGTLb98IxchzNKRE9lMi8kH7wl6Nyg3Zv0ppu8P4eSg4oN0zLKl npXmNm0WBoEKCqhtbX/HimjwBg4eFeJz+BgWwnXkx0GRblY0fN09EwxXk5aMalwfjK4u /pcWlZ7YW8UbZWcziFrp/vsbyaEHMGdC1hsWu+WQF6RveVOGJ5y8cCsNoV3Abluwjtxe 5Wcw== X-Received: by 10.236.147.166 with SMTP id t26mr18182671yhj.0.1361156494820; Sun, 17 Feb 2013 19:01:34 -0800 (PST) Received: from linux-2liw.lan (CPE-75-81-36-228.kc.res.rr.com. [75.81.36.228]) by mx.google.com with ESMTPS id m59sm21006983yhi.2.2013.02.17.19.01.32 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 17 Feb 2013 19:01:33 -0800 (PST) From: Larry Finger To: linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, Larry Finger , netdev@vger.kernel.org, Bastian Bittorf , Stable Subject: [PATCH] b43: Increase number of RX DMA slots Date: Sun, 17 Feb 2013 21:01:20 -0600 Message-Id: <1361156480-32566-1-git-send-email-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 1.8.1.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bastian Bittorf reported that some of the silent freezes on a Linksys WRT54G were due to overflow of the RX DMA ring buffer, which was created with 64 slots. That finding reminded me that I was seeing similar crashed on a netbook, which also has a relatively slow processor. After increasing the number of slots to 128, runs on the netbook that previously failed now worked; however, I found that 109 slots had been used in one test. For that reason, the number of slots is being increased to 256. Signed-off-by: Larry Finger Cc: Bastian Bittorf Cc: Stable --- --- drivers/net/wireless/b43/dma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/b43/dma.h b/drivers/net/wireless/b43/dma.h index 315b96e..9fdd198 100644 --- a/drivers/net/wireless/b43/dma.h +++ b/drivers/net/wireless/b43/dma.h @@ -169,7 +169,7 @@ struct b43_dmadesc_generic { /* DMA engine tuning knobs */ #define B43_TXRING_SLOTS 256 -#define B43_RXRING_SLOTS 64 +#define B43_RXRING_SLOTS 256 #define B43_DMA0_RX_FW598_BUFSIZE (B43_DMA0_RX_FW598_FO + IEEE80211_MAX_FRAME_LEN) #define B43_DMA0_RX_FW351_BUFSIZE (B43_DMA0_RX_FW351_FO + IEEE80211_MAX_FRAME_LEN)