Patchwork [U-Boot,v3,02/10] mx23: Document the tRAS lockout setting in memory initialization

login
register
mail settings
Submitter Otavio Salvador
Date Feb. 17, 2013, 7:45 p.m.
Message ID <1361130325-5202-3-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/221092/
State Superseded
Headers show

Comments

Otavio Salvador - Feb. 17, 2013, 7:45 p.m.
Add a comment about the tRAS lockout setting of HW_DRAM_CTL08 to
enable the 'Fast Auto Pre-Charge' found in the memory chip. The
setting is applied after memory initialization and it is worth
document it.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- Extend code comment to be more verbose (Marek)

Changes in v2:
- Extend code comment to explicit say it needs to be there.

 arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch

diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
index f8392f6..4db9baa 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
@@ -119,6 +119,10 @@  static void initialize_dram_values(void)
 		writel(dram_vals[i], MXS_DRAM_BASE + (4 * i));
 
 #ifdef CONFIG_MX23
+	/*
+	 * Enable tRAS lockout in HW_DRAM_CTL08 ; it must be the last
+	 * element to be set
+	 */
 	writel((1 << 24), MXS_DRAM_BASE + (4 * 8));
 #endif
 }