Patchwork Adding a ModemManager package

login
register
mail settings
Submitter Shawn J. Goff
Date Feb. 17, 2013, 5:56 p.m.
Message ID <512119BB.9000200@gmail.com>
Download mbox | patch
Permalink /patch/221084/
State Superseded
Headers show

Comments

Shawn J. Goff - Feb. 17, 2013, 5:56 p.m.
On 02/17/2013 12:31 PM, Thomas Petazzoni wrote:
> Dear Shawn J. Goff,
>
> On Sun, 17 Feb 2013 12:07:59 -0500, Shawn J. Goff wrote:
>> I'm trying to add a ModemManager package. While building, I'm getting
>> this error during the installation step: "/usr/lib/libgcc_s.so: file not
>> recognized: File format not recognized". This looks like it's looking at
>> my host's libgcc_s.so instead of the target's version. If that's the
>> case I'm not sure why or how to fix it. I did have to use autogen.sh to
>> create the configure script and lots of other stuff; I did this on my
>> host system, so I'm not sure if that is affecting it.
> Could you post the in-progress patch you have to add the modem-manager
> package? This would allow us to check for potential suspicious things
> in the .mk file, and if nothing suspicious shows up, to try and
> reproduce the issue.
>
> Thanks!
>
> Thomas

Sure, here's a patch. udev was disabling gudev; for now, I had to remove 
that part because the default configuration of ModemManager seems to 
require it. I don't have a patch for the autogen-created files yet. I 
run make, then go to the build directory and run "NOCONFIGURE=yes 
./autogen.sh", then go back and continue running make.
Thomas Petazzoni - Feb. 17, 2013, 6:17 p.m.
Dear Shawn J. Goff,

On Sun, 17 Feb 2013 12:56:11 -0500, Shawn J. Goff wrote:

> Sure, here's a patch. udev was disabling gudev; for now, I had to remove 

If you read the udev.mk, you see that gudev is disabled unless
BR2_PACKAGE_UDEV_ALL_EXTRAS is enabled. And your package selects it, so
it should "just" work.

> that part because the default configuration of ModemManager seems to 
> require it. I don't have a patch for the autogen-created files yet. I 
> run make, then go to the build directory and run "NOCONFIGURE=yes 
> ./autogen.sh", then go back and continue running make.

Use MODEM_MANAGER_AUTORECONF = YES instead.

I don't have the time to try and reproduce the problem right now, but
hopefully someone else will have a look.

Best regards,

Thomas

Patch

From 2698bc2f7531cf00e435df7af254e43a48d4d149 Mon Sep 17 00:00:00 2001
From: "Shawn J. Goff" <shawn.goff@accelecon.com>
Date: Sun, 17 Feb 2013 12:52:08 -0500
Subject: [PATCH] ModemManager: initial package addition

---
 package/Config.in                      |  1 +
 package/modem-manager/Config.in        | 18 ++++++++++++++++++
 package/modem-manager/modem-manager.mk | 17 +++++++++++++++++
 package/udev/udev.mk                   |  3 ---
 4 files changed, 36 insertions(+), 3 deletions(-)
 create mode 100644 package/modem-manager/Config.in
 create mode 100644 package/modem-manager/modem-manager.mk

diff --git a/package/Config.in b/package/Config.in
index 4e8fe0f..730f478 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -615,6 +615,7 @@  source "package/netplug/Config.in"
 source "package/netsnmp/Config.in"
 source "package/netstat-nat/Config.in"
 source "package/network-manager/Config.in"
+source "package/modem-manager/Config.in"
 source "package/nfacct/Config.in"
 source "package/noip/Config.in"
 source "package/ngircd/Config.in"
diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
new file mode 100644
index 0000000..3df46ca
--- /dev/null
+++ b/package/modem-manager/Config.in
@@ -0,0 +1,18 @@ 
+config BR2_PACKAGE_MODEM_MANAGER
+	bool "ModemManager"
+	depends on BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
+	select BR2_PACKAGE_DBUS
+	depends on BR2_LARGEFILE # acl
+	depends on BR2_USE_WCHAR # libglib2 and gnutls
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
+	depends on BR2_USE_MMU # dbus
+	select BR2_PACKAGE_DBUS_GLIB
+	select BR2_PACKAGE_UDEV
+	select BR2_PACKAGE_UDEV_ALL_EXTRAS
+	help
+          ModemManager
+	  http://projects.gnome.org/NetworkManager/
+
+comment "ModemManager requires a toolchain with IPV6, LARGEFILE, WCHAR and thread support"
+	depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
new file mode 100644
index 0000000..7454584
--- /dev/null
+++ b/package/modem-manager/modem-manager.mk
@@ -0,0 +1,17 @@ 
+#############################################################
+#
+# ModemManager
+#
+#############################################################
+MODEM_MANAGER_VERSION = 0.7.990
+MODEM_MANAGER_SITE = git://anongit.freedesktop.org/ModemManager/ModemManager
+MODEM_MANAGER_SITE_METHOD = git
+MODEM_MANAGER_INSTALL_STAGING = NO
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev dbus-glib libqmi
+
+# uClibc by default doesn't have backtrace support, so don't use it
+ifeq ($(BR2_TOOLCHAIN_BUILDROOT)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC)$(BR2_TOOLCHAIN_CTNG_uClibc),y)
+MODEM_MANAGER_CONF_OPT += --disable-crashtrace
+endif
+
+$(eval $(autotools-package))
diff --git a/package/udev/udev.mk b/package/udev/udev.mk
index c55db71..d395d4a 100644
--- a/package/udev/udev.mk
+++ b/package/udev/udev.mk
@@ -30,9 +30,6 @@  ifeq ($(BR2_PACKAGE_UDEV_ALL_EXTRAS),y)
 UDEV_DEPENDENCIES += acl hwdata libglib2
 UDEV_CONF_OPT +=		\
 	--enable-udev_acl
-else
-UDEV_CONF_OPT +=		\
-	--disable-gudev
 endif
 
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
-- 
1.8.1.2