Patchwork [v2,2/2] net: fec: Improve logging

login
register
mail settings
Submitter Fabio Estevam
Date Feb. 17, 2013, 1:36 p.m.
Message ID <1361108204-9498-2-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/221060/
State Superseded
Delegated to: David Miller
Headers show

Comments

Fabio Estevam - Feb. 17, 2013, 1:36 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Replace pr_debug with dev_dbg to improve the logging style.
dev_dbg indicates the device name in the log, which is useful for debugging 
purposes when we have a dual FEC system, such as mx28. 

Also use "phy-reset-gpios" in the message to correlate with the device tree
property.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Use dev_dbg instead of dev_err
 drivers/net/ethernet/freescale/fec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index 5864a67..29d82cf 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
@@ -1695,7 +1695,7 @@  static void fec_reset_phy(struct platform_device *pdev)
 	err = devm_gpio_request_one(&pdev->dev, phy_reset,
 				    GPIOF_OUT_INIT_LOW, "phy-reset");
 	if (err) {
-		pr_debug("FEC: failed to get gpio phy-reset: %d\n", err);
+		dev_dbg(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);
 		return;
 	}
 	msleep(msec);