| Submitter | Jean-Christophe PLAGNIOL-VILLARD |
|---|---|
| Date | Feb. 16, 2013, 10:27 p.m. |
| Message ID | <1361053631-13811-1-git-send-email-plagnioj@jcrosoft.com> |
| Download | mbox | patch |
| Permalink | /patch/221046/ |
| State | New |
| Headers | show |
Comments
On 16 February 2013 22:27, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote: > at 0xfff3cf20 enable SATA, MMC, PCI This commit message is way too cryptic. > c: Rob Herring <rob.herring@calxeda.com> You typo'd "cc" here so git didn't auto-cc Rob; I've added him to the cc list by hand. > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> > --- > hw/highbank.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/highbank.c b/hw/highbank.c > index defcc09..64aef30 100644 > --- a/hw/highbank.c > +++ b/hw/highbank.c > @@ -143,6 +143,7 @@ static void highbank_regs_reset(DeviceState *dev) > s->regs[0x41] = 0x2; > s->regs[0x42] = 0x05F30121; > s->regs[0x43] = 0x05F40121; > + s->regs[0x3C8] = 0xE0000000; > } > > static int highbank_regs_init(SysBusDevice *dev) > @@ -153,6 +154,7 @@ static int highbank_regs_init(SysBusDevice *dev) > memory_region_init_io(s->iomem, &hb_mem_ops, s->regs, "highbank_regs", > 0x1000); > sysbus_init_mmio(dev, s->iomem); > + s->regs[0x3C8] = 0xE0000000; This line is definitely unnecessary -- the reset function will be called after init. > return 0; > } > -- > 1.7.10.4 > thanks -- PMM
Patch
diff --git a/hw/highbank.c b/hw/highbank.c index defcc09..64aef30 100644 --- a/hw/highbank.c +++ b/hw/highbank.c @@ -143,6 +143,7 @@ static void highbank_regs_reset(DeviceState *dev) s->regs[0x41] = 0x2; s->regs[0x42] = 0x05F30121; s->regs[0x43] = 0x05F40121; + s->regs[0x3C8] = 0xE0000000; } static int highbank_regs_init(SysBusDevice *dev) @@ -153,6 +154,7 @@ static int highbank_regs_init(SysBusDevice *dev) memory_region_init_io(s->iomem, &hb_mem_ops, s->regs, "highbank_regs", 0x1000); sysbus_init_mmio(dev, s->iomem); + s->regs[0x3C8] = 0xE0000000; return 0; }
at 0xfff3cf20 enable SATA, MMC, PCI c: Rob Herring <rob.herring@calxeda.com> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> --- hw/highbank.c | 2 ++ 1 file changed, 2 insertions(+)