From patchwork Sat Feb 16 22:53:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 221044 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DF6582C0080 for ; Sun, 17 Feb 2013 09:53:52 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754913Ab3BPWxs (ORCPT ); Sat, 16 Feb 2013 17:53:48 -0500 Received: from mail-gg0-f174.google.com ([209.85.161.174]:33145 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754905Ab3BPWxr (ORCPT ); Sat, 16 Feb 2013 17:53:47 -0500 Received: by mail-gg0-f174.google.com with SMTP id k5so343967ggd.5 for ; Sat, 16 Feb 2013 14:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=OUzFoNpy12/feKmz+Ltz4tNs1GuheEo/eUVsB8XSB0I=; b=WNLiAfREL9eW+ZiPR/NjOG7Q9f1B07WfrjeXrByhCeg0YUw2IIwpkZCHRA82IS19W9 VOrEQywtOlteGy++zTnZz78GXgC1P8cjKqJjNLJKU9SvQ3cnBT9SeAlZK5bCuBkrPD4x pi8AYOVFeimRfnyEt7CoyO0Ew+4ZB6pV+Jo4qBFByCoQA98qukrT+aedsw9imc/dEJO/ BNS2ALt8EEgHOOG3j2StIaqgjMRhrPlGHFeRfvxROrwdD1ipGgM1jzSS7tjRPk+4lvTN xzLPjNPDNhPhmCDI/bC0imnwLZcvw3DXysD3jnbi+1pPNjRG9bCPnVAYOEt5pAYFWUlD rgBQ== X-Received: by 10.236.124.73 with SMTP id w49mr11151464yhh.62.1361055226318; Sat, 16 Feb 2013 14:53:46 -0800 (PST) Received: from localhost.localdomain ([201.82.137.218]) by mx.google.com with ESMTPS id x16sm101516047yhj.6.2013.02.16.14.53.44 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Feb 2013 14:53:45 -0800 (PST) From: Fabio Estevam To: davem@davemloft.net Cc: s.hauer@pengutronix.de, shawn.guo@linaro.org, marex@denx.de, netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH 2/2] net: fec: Improve logging Date: Sat, 16 Feb 2013 20:53:27 -0200 Message-Id: <1361055207-22870-2-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1361055207-22870-1-git-send-email-festevam@gmail.com> References: <1361055207-22870-1-git-send-email-festevam@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam In case the request of the GPIO reset fails it is interesting to log such error even if DEBUG is not enabled, so promote the message to dev_err. Signed-off-by: Fabio Estevam Acked-by: Marek Vasut --- drivers/net/ethernet/freescale/fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c index 5864a67..29d82cf 100644 --- a/drivers/net/ethernet/freescale/fec.c +++ b/drivers/net/ethernet/freescale/fec.c @@ -1695,7 +1695,7 @@ static void fec_reset_phy(struct platform_device *pdev) err = devm_gpio_request_one(&pdev->dev, phy_reset, GPIOF_OUT_INIT_LOW, "phy-reset"); if (err) { - pr_debug("FEC: failed to get gpio phy-reset: %d\n", err); + dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err); return; } msleep(msec);