Patchwork [net-next] ip: fix warning in xfrm4_mode_tunnel_input

login
register
mail settings
Submitter stephen hemminger
Date Feb. 16, 2013, 5:40 p.m.
Message ID <20130216094029.4d2fc993@nehalam.linuxnetplumber.net>
Download mbox | patch
Permalink /patch/221013/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Feb. 16, 2013, 5:40 p.m.
Same problem as IPv6

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Feb. 18, 2013, 5:43 p.m.
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Sat, 16 Feb 2013 09:40:29 -0800

> Same problem as IPv6
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/ipv4/xfrm4_mode_tunnel.c	2013-02-16 09:09:41.388937316 -0800
+++ b/net/ipv4/xfrm4_mode_tunnel.c	2013-02-16 09:39:21.849910500 -0800
@@ -142,7 +142,8 @@  static int xfrm4_mode_tunnel_input(struc
 	for_each_input_rcu(rcv_notify_handlers, handler)
 		handler->handler(skb);
 
-	if (err = skb_unclone(skb, GFP_ATOMIC))
+	err = skb_unclone(skb, GFP_ATOMIC);
+	if (err)
 		goto out;
 
 	if (x->props.flags & XFRM_STATE_DECAP_DSCP)