Patchwork [RESEND] isa: Split off instance_init for ISADevice

login
register
mail settings
Submitter Andreas Färber
Date Feb. 16, 2013, 10:27 a.m.
Message ID <1361010446-1427-1-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/220956/
State New
Headers show

Comments

Andreas Färber - Feb. 16, 2013, 10:27 a.m.
Prepares for assigning IRQs before QOM realize.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/isa-bus.c |   12 +++++++++---
 1 Datei geändert, 9 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)
Anthony Liguori - Feb. 18, 2013, 4:02 p.m.
Applied.  Thanks.

Regards,

Anthony Liguori

Patch

diff --git a/hw/isa-bus.c b/hw/isa-bus.c
index fce311b..6dc34f0 100644
--- a/hw/isa-bus.c
+++ b/hw/isa-bus.c
@@ -124,9 +124,6 @@  static int isa_qdev_init(DeviceState *qdev)
     ISADevice *dev = ISA_DEVICE(qdev);
     ISADeviceClass *klass = ISA_DEVICE_GET_CLASS(dev);
 
-    dev->isairq[0] = -1;
-    dev->isairq[1] = -1;
-
     if (klass->init) {
         return klass->init(dev);
     }
@@ -134,6 +131,14 @@  static int isa_qdev_init(DeviceState *qdev)
     return 0;
 }
 
+static void isa_device_init(Object *obj)
+{
+    ISADevice *dev = ISA_DEVICE(obj);
+
+    dev->isairq[0] = -1;
+    dev->isairq[1] = -1;
+}
+
 ISADevice *isa_create(ISABus *bus, const char *name)
 {
     DeviceState *dev;
@@ -233,6 +238,7 @@  static const TypeInfo isa_device_type_info = {
     .name = TYPE_ISA_DEVICE,
     .parent = TYPE_DEVICE,
     .instance_size = sizeof(ISADevice),
+    .instance_init = isa_device_init,
     .abstract = true,
     .class_size = sizeof(ISADeviceClass),
     .class_init = isa_device_class_init,