Patchwork Add new debug_bb_range debugging function

login
register
mail settings
Submitter Dodji Seketeli
Date Feb. 16, 2013, 9:40 a.m.
Message ID <87a9r4a95w.fsf@redhat.com>
Download mbox | patch
Permalink /patch/220953/
State New
Headers show

Comments

Dodji Seketeli - Feb. 16, 2013, 9:40 a.m.
Hello,

In my first foray of debugging gimple stuff, I felt the need for a
function function to dump a range of basic block from number N to P to
stderr.  I find this a bit more handy than calling debug_bb_n on each
basic block instead.

I understand this is material for 4.9, so if you agree I'll stage it in
my queue of patches for when stage1 opens.

Is this OK, or is there a function that does this already (or something
else :))?

Thanks.

Tested on x86_64-unknown-linux-gnu against trunk.

gcc/

	* basic-block.h (debug_bb_range): Declare ...
	* cfg.c (debug_bb_range): ... new function.
---
 gcc/basic-block.h |  1 +
 gcc/cfg.c         | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
Jakub Jelinek - Feb. 16, 2013, 9:57 a.m.
On Sat, Feb 16, 2013 at 10:40:43AM +0100, Dodji Seketeli wrote:
> --- a/gcc/cfg.c
> +++ b/gcc/cfg.c
> @@ -663,6 +663,21 @@ debug_bb_n (int n)
>    return bb;
>  }
>  
> +/* Dumps cfg related information about basic blocks, from number 'S'
> +   to number E, to stderr.  */
> +
> +DEBUG_FUNCTION basic_block
> +debug_bb_range (int s, int e)
> +{
> +  basic_block bb =  NULL;
> +  for (int i = s; i <= e; ++i)
> +    {
> +      bb = BASIC_BLOCK (i);
> +      debug_bb (bb);

At some points after cfg changes, but before cfg cleanup there might be
gaps, so I think you want if (bb) debug_bb (bb);, otherwise it could crash
in that case.

	Jakub

Patch

diff --git a/gcc/basic-block.h b/gcc/basic-block.h
index 90eb57b..8407c4a 100644
--- a/gcc/basic-block.h
+++ b/gcc/basic-block.h
@@ -752,6 +752,7 @@  extern bool predictable_edge_p (edge);
 extern void init_flow (struct function *);
 extern void debug_bb (basic_block);
 extern basic_block debug_bb_n (int);
+extern basic_block debug_bb_range (int, int);
 extern void dump_flow_info (FILE *, int);
 extern void expunge_block (basic_block);
 extern void link_block (basic_block, basic_block);
diff --git a/gcc/cfg.c b/gcc/cfg.c
index 9e4380c..d34f27e 100644
--- a/gcc/cfg.c
+++ b/gcc/cfg.c
@@ -663,6 +663,21 @@  debug_bb_n (int n)
   return bb;
 }
 
+/* Dumps cfg related information about basic blocks, from number 'S'
+   to number E, to stderr.  */
+
+DEBUG_FUNCTION basic_block
+debug_bb_range (int s, int e)
+{
+  basic_block bb =  NULL;
+  for (int i = s; i <= e; ++i)
+    {
+      bb = BASIC_BLOCK (i);
+      debug_bb (bb);
+    }
+  return bb;
+}
+
 /* Dumps cfg related information about basic block BB to OUTF.
    If HEADER is true, dump things that appear before the instructions
    contained in BB.  If FOOTER is true, dump things that appear after.