Patchwork [U-Boot,v7,16/19] arm926ejs: Remove deprecated and now unused NAND SPL

login
register
mail settings
Submitter Benoît Thébaudeau
Date Feb. 15, 2013, 8:54 p.m.
Message ID <1360961665-10693-16-git-send-email-benoit.thebaudeau@advansee.com>
Download mbox | patch
Permalink /patch/220863/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Benoît Thébaudeau - Feb. 15, 2013, 8:54 p.m.
Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
---
Changes in v7: None
Changes in v6:
 - New patch.

Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 arch/arm/cpu/arm926ejs/start.S |   10 ----------
 1 file changed, 10 deletions(-)
Benoît Thébaudeau - Feb. 17, 2013, 3:51 p.m.
Hi Albert, Tom, Zhong,

On Friday, February 15, 2013 9:54:22 PM, Benoît Thébaudeau wrote:
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
> ---
> Changes in v7: None
> Changes in v6:
>  - New patch.
> 
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/cpu/arm926ejs/start.S |   10 ----------
>  1 file changed, 10 deletions(-)

I would like to get your feedback regarding the status of the Samsung SMDK6400
board:
 - It is not in boards.cfg, so, according to commit 1285a28, support for it
   should already have been removed a long time ago. It also seems to be the
   only board remaining in the main Makefile.
 - It uses the deprecated NAND SPL.
 - MAKEALL does not test its build, which has been broken for a while.
 - If it were removed or fixed, ARM1176's start.S' relocate_code() could be made
   identical to all the other implementations of this function, so all this
   duplicated code could be moved to a common location like crt0.S. Besides
   that, it would be possible to completely get rid of the legacy NAND SPL on
   ARM.

I have no intention of fixing this board, but dropping it and cleaning up ARM
after that would be easy.

Best regards,
Benoît
Albert ARIBAUD - Feb. 17, 2013, 4:04 p.m.
Hi Benoît,

On Sun, 17 Feb 2013 16:51:37 +0100 (CET), Benoît Thébaudeau
<benoit.thebaudeau@advansee.com> wrote:

> Hi Albert, Tom, Zhong,
> 
> On Friday, February 15, 2013 9:54:22 PM, Benoît Thébaudeau wrote:
> > Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
> > ---
> > Changes in v7: None
> > Changes in v6:
> >  - New patch.
> > 
> > Changes in v5: None
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2: None
> > 
> >  arch/arm/cpu/arm926ejs/start.S |   10 ----------
> >  1 file changed, 10 deletions(-)
> 
> I would like to get your feedback regarding the status of the Samsung SMDK6400
> board:
>  - It is not in boards.cfg, so, according to commit 1285a28, support for it
>    should already have been removed a long time ago. It also seems to be the
>    only board remaining in the main Makefile.
>  - It uses the deprecated NAND SPL.
>  - MAKEALL does not test its build, which has been broken for a while.
>  - If it were removed or fixed, ARM1176's start.S' relocate_code() could be made
>    identical to all the other implementations of this function, so all this
>    duplicated code could be moved to a common location like crt0.S. Besides
>    that, it would be possible to completely get rid of the legacy NAND SPL on
>    ARM.
> 
> I have no intention of fixing this board, but dropping it and cleaning up ARM
> after that would be easy.

Cc:ing the board maintainers, as they should be the first ones to be
asked whether they intend to bring the board into boards.cfg and fix
it, or whether it should be dropped.

> Best regards,
> Benoît

Amicalement,
Albert ARIBAUD - Feb. 17, 2013, 4:08 p.m.
Hi Albert,

On Sun, 17 Feb 2013 17:04:54 +0100, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:

> Hi Benoît,
> 
> On Sun, 17 Feb 2013 16:51:37 +0100 (CET), Benoît Thébaudeau
> <benoit.thebaudeau@advansee.com> wrote:
> 
> > Hi Albert, Tom, Zhong,
> > 
> > On Friday, February 15, 2013 9:54:22 PM, Benoît Thébaudeau wrote:
> > > Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
> > > ---
> > > Changes in v7: None
> > > Changes in v6:
> > >  - New patch.
> > > 
> > > Changes in v5: None
> > > Changes in v4: None
> > > Changes in v3: None
> > > Changes in v2: None
> > > 
> > >  arch/arm/cpu/arm926ejs/start.S |   10 ----------
> > >  1 file changed, 10 deletions(-)
> > 
> > I would like to get your feedback regarding the status of the Samsung SMDK6400
> > board:
> >  - It is not in boards.cfg, so, according to commit 1285a28, support for it
> >    should already have been removed a long time ago. It also seems to be the
> >    only board remaining in the main Makefile.
> >  - It uses the deprecated NAND SPL.
> >  - MAKEALL does not test its build, which has been broken for a while.
> >  - If it were removed or fixed, ARM1176's start.S' relocate_code() could be made
> >    identical to all the other implementations of this function, so all this
> >    duplicated code could be moved to a common location like crt0.S. Besides
> >    that, it would be possible to completely get rid of the legacy NAND SPL on
> >    ARM.
> > 
> > I have no intention of fixing this board, but dropping it and cleaning up ARM
> > after that would be easy.
> 
> Cc:ing the board maintainers, as they should be the first ones to be
> asked whether they intend to bring the board into boards.cfg and fix
> it, or whether it should be dropped.

Scratch this: correct maintainer CC:ed now (how about changing the
MAINTAINERS file format so that we can tell for sure without having to 
ceck the first entry?)

> > Best regards,
> > Benoît
> 
> Amicalement,


Amicalement,
Benoît Thébaudeau - Feb. 17, 2013, 4:25 p.m.
On Sunday, February 17, 2013 5:08:00 PM, Albert ARIBAUD wrote:
> Hi Albert,
> 
> On Sun, 17 Feb 2013 17:04:54 +0100, Albert ARIBAUD
> <albert.u.boot@aribaud.net> wrote:
> 
> > Hi Benoît,
> > 
> > On Sun, 17 Feb 2013 16:51:37 +0100 (CET), Benoît Thébaudeau
> > <benoit.thebaudeau@advansee.com> wrote:
> > 
> > > Hi Albert, Tom, Zhong,
> > > 
> > > On Friday, February 15, 2013 9:54:22 PM, Benoît Thébaudeau wrote:
> > > > Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
> > > > ---
> > > > Changes in v7: None
> > > > Changes in v6:
> > > >  - New patch.
> > > > 
> > > > Changes in v5: None
> > > > Changes in v4: None
> > > > Changes in v3: None
> > > > Changes in v2: None
> > > > 
> > > >  arch/arm/cpu/arm926ejs/start.S |   10 ----------
> > > >  1 file changed, 10 deletions(-)
> > > 
> > > I would like to get your feedback regarding the status of the Samsung
> > > SMDK6400
> > > board:
> > >  - It is not in boards.cfg, so, according to commit 1285a28, support for
> > >  it
> > >    should already have been removed a long time ago. It also seems to be
> > >    the
> > >    only board remaining in the main Makefile.
> > >  - It uses the deprecated NAND SPL.
> > >  - MAKEALL does not test its build, which has been broken for a while.
> > >  - If it were removed or fixed, ARM1176's start.S' relocate_code() could
> > >  be made
> > >    identical to all the other implementations of this function, so all
> > >    this
> > >    duplicated code could be moved to a common location like crt0.S.
> > >    Besides
> > >    that, it would be possible to completely get rid of the legacy NAND
> > >    SPL on
> > >    ARM.
> > > 
> > > I have no intention of fixing this board, but dropping it and cleaning up
> > > ARM
> > > after that would be easy.
> > 
> > Cc:ing the board maintainers, as they should be the first ones to be
> > asked whether they intend to bring the board into boards.cfg and fix
> > it, or whether it should be dropped.
> 
> Scratch this: correct maintainer CC:ed now

Yes, I had already Cc'ed Zhong.

> (how about changing the
> MAINTAINERS file format so that we can tell for sure without having to
> ceck the first entry?)

That would be good. E.g., a colon could be added after the last e-mail address
of each group of board maintainers, or the empty line between the e-mail
addresses and the boards could be removed.

Best regards,
Benoît
Benoît Thébaudeau - Feb. 18, 2013, 12:24 p.m.
On Sunday, February 17, 2013 5:25:33 PM, Benoît Thébaudeau wrote:
> On Sunday, February 17, 2013 5:08:00 PM, Albert ARIBAUD wrote:
> > Hi Albert,
> > 
> > On Sun, 17 Feb 2013 17:04:54 +0100, Albert ARIBAUD
> > <albert.u.boot@aribaud.net> wrote:
> > 
> > > Hi Benoît,
> > > 
> > > On Sun, 17 Feb 2013 16:51:37 +0100 (CET), Benoît Thébaudeau
> > > <benoit.thebaudeau@advansee.com> wrote:
> > > 
> > > > Hi Albert, Tom, Zhong,
> > > > 
> > > > On Friday, February 15, 2013 9:54:22 PM, Benoît Thébaudeau wrote:
> > > > > Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
> > > > > ---
> > > > > Changes in v7: None
> > > > > Changes in v6:
> > > > >  - New patch.
> > > > > 
> > > > > Changes in v5: None
> > > > > Changes in v4: None
> > > > > Changes in v3: None
> > > > > Changes in v2: None
> > > > > 
> > > > >  arch/arm/cpu/arm926ejs/start.S |   10 ----------
> > > > >  1 file changed, 10 deletions(-)
> > > > 
> > > > I would like to get your feedback regarding the status of the Samsung
> > > > SMDK6400
> > > > board:
> > > >  - It is not in boards.cfg, so, according to commit 1285a28, support
> > > >  for
> > > >  it
> > > >    should already have been removed a long time ago. It also seems to
> > > >    be
> > > >    the
> > > >    only board remaining in the main Makefile.
> > > >  - It uses the deprecated NAND SPL.
> > > >  - MAKEALL does not test its build, which has been broken for a while.
> > > >  - If it were removed or fixed, ARM1176's start.S' relocate_code()
> > > >  could
> > > >  be made
> > > >    identical to all the other implementations of this function, so all
> > > >    this
> > > >    duplicated code could be moved to a common location like crt0.S.
> > > >    Besides
> > > >    that, it would be possible to completely get rid of the legacy NAND
> > > >    SPL on
> > > >    ARM.
> > > > 
> > > > I have no intention of fixing this board, but dropping it and cleaning
> > > > up
> > > > ARM
> > > > after that would be easy.
> > > 
> > > Cc:ing the board maintainers, as they should be the first ones to be
> > > asked whether they intend to bring the board into boards.cfg and fix
> > > it, or whether it should be dropped.
> > 
> > Scratch this: correct maintainer CC:ed now
> 
> Yes, I had already Cc'ed Zhong.

Adding Mike to Cc as he had been assigned the board migration job to boards.cfg,
due for v2012.03. Perhaps he got some information from the SMDK6400 maintainer.

Best regards,
Benoît
Tom Rini - Feb. 18, 2013, 4:40 p.m.
On Sun, Feb 17, 2013 at 04:51:37PM +0100, Beno??t Th??baudeau wrote:
> Hi Albert, Tom, Zhong,
> 
> On Friday, February 15, 2013 9:54:22 PM, Beno??t Th??baudeau wrote:
> > Signed-off-by: Beno??t Th??baudeau <benoit.thebaudeau@advansee.com>
> > ---
> > Changes in v7: None
> > Changes in v6:
> >  - New patch.
> > 
> > Changes in v5: None
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2: None
> > 
> >  arch/arm/cpu/arm926ejs/start.S |   10 ----------
> >  1 file changed, 10 deletions(-)
> 
> I would like to get your feedback regarding the status of the Samsung SMDK6400
> board:
>  - It is not in boards.cfg, so, according to commit 1285a28, support for it
>    should already have been removed a long time ago. It also seems to be the
>    only board remaining in the main Makefile.
>  - It uses the deprecated NAND SPL.
>  - MAKEALL does not test its build, which has been broken for a while.
>  - If it were removed or fixed, ARM1176's start.S' relocate_code() could be made
>    identical to all the other implementations of this function, so all this
>    duplicated code could be moved to a common location like crt0.S. Besides
>    that, it would be possible to completely get rid of the legacy NAND SPL on
>    ARM.
> 
> I have no intention of fixing this board, but dropping it and cleaning up ARM
> after that would be easy.

I'm in favor of removing and updating README.scrapyard, baring quick
attention from the maintainer to update it to not being using the
Makefile and fix the rest of the breakage.
Benoît Thébaudeau - Feb. 18, 2013, 8:39 p.m.
Hi Tom,

On Monday, February 18, 2013 5:40:21 PM, Tom Rini wrote:
> On Sun, Feb 17, 2013 at 04:51:37PM +0100, Beno??t Th??baudeau wrote:
> > Hi Albert, Tom, Zhong,
> > 
> > On Friday, February 15, 2013 9:54:22 PM, Beno??t Th??baudeau wrote:
> > > Signed-off-by: Beno??t Th??baudeau <benoit.thebaudeau@advansee.com>
> > > ---
> > > Changes in v7: None
> > > Changes in v6:
> > >  - New patch.
> > > 
> > > Changes in v5: None
> > > Changes in v4: None
> > > Changes in v3: None
> > > Changes in v2: None
> > > 
> > >  arch/arm/cpu/arm926ejs/start.S |   10 ----------
> > >  1 file changed, 10 deletions(-)
> > 
> > I would like to get your feedback regarding the status of the Samsung
> > SMDK6400
> > board:
> >  - It is not in boards.cfg, so, according to commit 1285a28, support for it
> >    should already have been removed a long time ago. It also seems to be
> >    the
> >    only board remaining in the main Makefile.
> >  - It uses the deprecated NAND SPL.
> >  - MAKEALL does not test its build, which has been broken for a while.
> >  - If it were removed or fixed, ARM1176's start.S' relocate_code() could be
> >  made
> >    identical to all the other implementations of this function, so all this
> >    duplicated code could be moved to a common location like crt0.S. Besides
> >    that, it would be possible to completely get rid of the legacy NAND SPL
> >    on
> >    ARM.
> > 
> > I have no intention of fixing this board, but dropping it and cleaning up
> > ARM
> > after that would be easy.
> 
> I'm in favor of removing and updating README.scrapyard, baring quick
> attention from the maintainer to update it to not being using the
> Makefile and fix the rest of the breakage.

OK. The s3c64xx SoC and all the drivers coming with it then become unused.
Should this be removed too? There may be out-of-tree users of this SoC.

Best regards,
Benoît
Tom Rini - Feb. 18, 2013, 8:56 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/18/2013 03:39 PM, Benoît Thébaudeau wrote:
> Hi Tom,
> 
> On Monday, February 18, 2013 5:40:21 PM, Tom Rini wrote:
>> On Sun, Feb 17, 2013 at 04:51:37PM +0100, Beno??t Th??baudeau 
>> wrote:
>>> Hi Albert, Tom, Zhong,
>>> 
>>> On Friday, February 15, 2013 9:54:22 PM, Beno??t Th??baudeau 
>>> wrote:
>>>> Signed-off-by: Beno??t Th??baudeau 
>>>> <benoit.thebaudeau@advansee.com> --- Changes in v7: None 
>>>> Changes in v6: - New patch.
>>>> 
>>>> Changes in v5: None Changes in v4: None Changes in v3: None 
>>>> Changes in v2: None
>>>> 
>>>> arch/arm/cpu/arm926ejs/start.S |   10 ---------- 1 file 
>>>> changed, 10 deletions(-)
>>> 
>>> I would like to get your feedback regarding the status of the 
>>> Samsung SMDK6400 board: - It is not in boards.cfg, so, 
>>> according to commit 1285a28, support for it should already
>>> have been removed a long time ago. It also seems to be the
>>> only board remaining in the main Makefile. - It uses the
>>> deprecated NAND SPL. - MAKEALL does not test its build, which
>>> has been broken for a while. - If it were removed or fixed,
>>> ARM1176's start.S' relocate_code() could be made identical to
>>> all the other implementations of this function, so all this
>>> duplicated code could be moved to a common location like
>>> crt0.S. Besides that, it would be possible to completely get
>>> rid of the legacy NAND SPL on ARM.
>>> 
>>> I have no intention of fixing this board, but dropping it and 
>>> cleaning up ARM after that would be easy.
>> 
>> I'm in favor of removing and updating README.scrapyard, baring 
>> quick attention from the maintainer to update it to not being 
>> using the Makefile and fix the rest of the breakage.
> 
> OK. The s3c64xx SoC and all the drivers coming with it then become 
> unused. Should this be removed too? There may be out-of-tree users 
> of this SoC.

Yes, it's what the scrapyard is for.  If an out-of-tree user exists
they can either support the reference board (and bring it back from
the dead) or their own board.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRIpWVAAoJENk4IS6UOR1W8LoP/AjswbJBzJX2HkrQ2My5LSsk
SIqktkdZw68IvwqYHWNzCYow/O693dV5l3Dz+KFKQXQ/Loz6wqTolrQSKrwl8CRq
OLKLD6vcNI3Z+buNsV3Bq9+3XXM2d8T5o3U8TV3eLKzgVo6SnfsgaDEzTqs1LgvD
A0tran0YMTPhTzcHDoB4SXutRFE+Hrv8rJaRjKzQL9118kGA21NRAz46HcB+FzRo
idew5fkjo88PMoAdaKm9V0cMavH5AOAxuffUJTGSHCOZwq9MPJ4B+iWSitDKN8/I
tu2cv7tCqv/MhCsJU9JVarco0I4t4sXcjPAWMqpg1vllBBgxazLGLfLlQ3B/cx0Q
KEaAkn8iU7fxPt+FbIau/beMyi6E/PBLJ4PcTa2gLPEayRpiMBYG7VrwnIXahwuI
RcFKCJLr2XN9aYgQSmXnL9/k8Tc9Hf6bYzamjA6/Zf27GcU0TipfSNRY4fgRuQno
5r8iWv6JCJEqWc0VQG/1Lqs/oRGQ9vl1py/zHQoCV5ChM+1G4XSU7eCeJZKRREE6
abKoVhj1BJ6THdtM+0B+cqVM+gr4uGN7+wqHCsNJibKgQl1HHXDps9v72q7vYjI+
bEAcqGMOpD1+RtHm6Xsjznmaj5REGgHUQ0eO1S898TdUQlML3AbkcgS0x83GHZHE
ziLexJiV0qKbTG3O/d80
=tKpl
-----END PGP SIGNATURE-----

Patch

diff --git a/arch/arm/cpu/arm926ejs/start.S b/arch/arm/cpu/arm926ejs/start.S
index 1db1152..60b0a67 100644
--- a/arch/arm/cpu/arm926ejs/start.S
+++ b/arch/arm/cpu/arm926ejs/start.S
@@ -120,15 +120,11 @@  _fiq:
 
 .globl _TEXT_BASE
 _TEXT_BASE:
-#ifdef CONFIG_NAND_SPL /* deprecated, use instead CONFIG_SPL_BUILD */
-	.word	CONFIG_SYS_TEXT_BASE
-#else
 #if defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_TEXT_BASE)
 	.word	CONFIG_SPL_TEXT_BASE
 #else
 	.word	CONFIG_SYS_TEXT_BASE
 #endif
-#endif
 
 /*
  * These are defined in the board-specific linker script.
@@ -152,12 +148,6 @@  _bss_end_ofs:
 _end_ofs:
 	.word _end - _start
 
-#ifdef CONFIG_NAND_U_BOOT
-.globl _end
-_end:
-	.word __bss_end__
-#endif
-
 #ifdef CONFIG_USE_IRQ
 /* IRQ stack memory (calculated at run-time) */
 .globl IRQ_STACK_START