Patchwork [qom-cpu-next] spapr_hcall: Replace open-coded CPU loop with qemu_get_cpu()

login
register
mail settings
Submitter Andreas Färber
Date Feb. 15, 2013, 3:49 p.m.
Message ID <1360943351-24806-1-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/220763/
State New
Headers show

Comments

Andreas Färber - Feb. 15, 2013, 3:49 p.m.
The helper functions all access ppc-specific fields only so don't bother
to change arguments to PowerPCCPU and use env_ptr instead.

No functional change.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/spapr_hcall.c |   11 +++--------
 1 Datei geändert, 3 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-)
Alexander Graf - Feb. 15, 2013, 4:44 p.m.
On 15.02.2013, at 16:49, Andreas Färber wrote:

> The helper functions all access ppc-specific fields only so don't bother
> to change arguments to PowerPCCPU and use env_ptr instead.
> 
> No functional change.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Acked-by: Alexander Graf <agraf@suse.de>


Alex

> ---
> hw/spapr_hcall.c |   11 +++--------
> 1 Datei geändert, 3 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-)
> 
> diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c
> index af1db6e..7b89594 100644
> --- a/hw/spapr_hcall.c
> +++ b/hw/spapr_hcall.c
> @@ -469,16 +469,11 @@ static target_ulong h_register_vpa(PowerPCCPU *cpu, sPAPREnvironment *spapr,
>     CPUPPCState *tenv;
>     CPUState *tcpu;
> 
> -    for (tenv = first_cpu; tenv; tenv = tenv->next_cpu) {
> -        tcpu = CPU(ppc_env_get_cpu(tenv));
> -        if (tcpu->cpu_index == procno) {
> -            break;
> -        }
> -    }
> -
> -    if (!tenv) {
> +    tcpu = qemu_get_cpu(procno);
> +    if (!tcpu) {
>         return H_PARAMETER;
>     }
> +    tenv = tcpu->env_ptr;
> 
>     switch (flags) {
>     case FLAGS_REGISTER_VPA:
> -- 
> 1.7.10.4
>
Andreas Färber - Feb. 15, 2013, 5:26 p.m.
Am 15.02.2013 17:44, schrieb Alexander Graf:
> 
> On 15.02.2013, at 16:49, Andreas Färber wrote:
> 
>> The helper functions all access ppc-specific fields only so don't bother
>> to change arguments to PowerPCCPU and use env_ptr instead.
>>
>> No functional change.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> Acked-by: Alexander Graf <agraf@suse.de>

Thanks, applied to qom-cpu-next:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-next

Andreas
David Gibson - Feb. 16, 2013, 11:47 p.m.
On Fri, Feb 15, 2013 at 05:44:16PM +0100, Alexander Graf wrote:
> 
> On 15.02.2013, at 16:49, Andreas Färber wrote:
> 
> > The helper functions all access ppc-specific fields only so don't bother
> > to change arguments to PowerPCCPU and use env_ptr instead.
> > 
> > No functional change.
> > 
> > Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> Acked-by: Alexander Graf <agraf@suse.de>
Acked-by: David Gibson <david@gibson.dropbear.id.au>

Patch

diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c
index af1db6e..7b89594 100644
--- a/hw/spapr_hcall.c
+++ b/hw/spapr_hcall.c
@@ -469,16 +469,11 @@  static target_ulong h_register_vpa(PowerPCCPU *cpu, sPAPREnvironment *spapr,
     CPUPPCState *tenv;
     CPUState *tcpu;
 
-    for (tenv = first_cpu; tenv; tenv = tenv->next_cpu) {
-        tcpu = CPU(ppc_env_get_cpu(tenv));
-        if (tcpu->cpu_index == procno) {
-            break;
-        }
-    }
-
-    if (!tenv) {
+    tcpu = qemu_get_cpu(procno);
+    if (!tcpu) {
         return H_PARAMETER;
     }
+    tenv = tcpu->env_ptr;
 
     switch (flags) {
     case FLAGS_REGISTER_VPA: