Patchwork ieee802154: at86rf230: Remove empty suspend/resume callbacks

login
register
mail settings
Submitter Lars-Peter Clausen
Date Feb. 15, 2013, 1:03 p.m.
Message ID <1360933409-2529-1-git-send-email-lars@metafoo.de>
Download mbox | patch
Permalink /patch/220743/
State Accepted
Delegated to: David Miller
Headers show

Comments

Lars-Peter Clausen - Feb. 15, 2013, 1:03 p.m.
There is no need to implement empty suspend/resume callbacks if there is nothing
to do during suspend/resume. The drivers will behave the same with no callbacks
or empty callbacks during suspend/resume.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/net/ieee802154/at86rf230.c | 12 ------------
 1 file changed, 12 deletions(-)
David Miller - Feb. 15, 2013, 8:35 p.m.
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Fri, 15 Feb 2013 14:03:29 +0100

> There is no need to implement empty suspend/resume callbacks if there is nothing
> to do during suspend/resume. The drivers will behave the same with no callbacks
> or empty callbacks during suspend/resume.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index a4a62e1..fc1687e 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -751,16 +751,6 @@  static int at86rf230_hw_init(struct at86rf230_local *lp)
 	return 0;
 }
 
-static int at86rf230_suspend(struct spi_device *spi, pm_message_t message)
-{
-	return 0;
-}
-
-static int at86rf230_resume(struct spi_device *spi)
-{
-	return 0;
-}
-
 static int at86rf230_fill_data(struct spi_device *spi)
 {
 	struct at86rf230_local *lp = spi_get_drvdata(spi);
@@ -948,8 +938,6 @@  static struct spi_driver at86rf230_driver = {
 	},
 	.probe      = at86rf230_probe,
 	.remove     = at86rf230_remove,
-	.suspend    = at86rf230_suspend,
-	.resume     = at86rf230_resume,
 };
 
 module_spi_driver(at86rf230_driver);