From patchwork Fri Feb 15 07:32:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220677 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yh0-x23e.google.com (mail-yh0-x23e.google.com [IPv6:2607:f8b0:4002:c01::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 918FB2C0082 for ; Fri, 15 Feb 2013 18:43:52 +1100 (EST) Received: by mail-yh0-f62.google.com with SMTP id w49sf1016649yhw.17 for ; Thu, 14 Feb 2013 23:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=2pAWhBSRGRNGPWwdEqVPVudyE/qYQ13NWUKLKXDnslY=; b=p9tlzD/U6+YDOrYogLdcHpE11qVLLL2VE3CvKZLPyMCUfWPEJ3AWMe/OnihT64mymk L3VH79PNah8m5wXOeuJFuHPYBSZh6JY/+Ex4bL3W/VolyT8I8garvvJg9BfXxElmg8jf zSV1zCTxFtpiS33m3urMTtPQ5u73QVCJflj5fC/vhUrNdatCSiRJfxOS/lFv7oSF7sDQ Vgp4rAsj8TnpzCs4g7qy+WDB5pAE3Tn7OwXqUyCw0SyAdqn8d09XYWEabJCbDTQ2ziyB LwYePsYMiIbG4tmhxBR+K7mOvKfq0VwZdm7ojwrlDLGZt/BLnnrBq4HDhDO0QCyeXnXr Yw4Q== X-Received: by 10.50.47.134 with SMTP id d6mr205745ign.0.1360913533333; Thu, 14 Feb 2013 23:32:13 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.57.193 with SMTP id k1ls330089igq.39.canary; Thu, 14 Feb 2013 23:32:13 -0800 (PST) X-Received: by 10.66.90.105 with SMTP id bv9mr985288pab.18.1360913532975; Thu, 14 Feb 2013 23:32:12 -0800 (PST) X-Received: by 10.66.90.105 with SMTP id bv9mr985287pab.18.1360913532964; Thu, 14 Feb 2013 23:32:12 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id wc12si633124pbc.1.2013.02.14.23.32.12; Thu, 14 Feb 2013 23:32:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI900C8S3LL35O0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:32:12 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id B1.70.06692.C74ED115; Fri, 15 Feb 2013 16:32:12 +0900 (KST) X-AuditID: cbfee691-b7f556d000001a24-94-511de47c92e8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 43.C1.03918.B74ED115; Fri, 15 Feb 2013 16:32:12 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI9007J13LNUN80@mmp2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:32:11 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> In-reply-to: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> Subject: [rtc-linux] [PATCH V3 11/11] rtc: rtc-cmos: use dev_warn()/dev_dbg() instead of printk()/pr_debug() Date: Fri, 15 Feb 2013 16:32:11 +0900 Message-id: <003501ce0b4e$919e0510$b4da0f30$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LTYY6VzXwCUtKTcq8t8M0FTt2HQAAPD0A X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t8zQ92aJ7KBBg9msVrs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxuZrf1gLlvNVXP30mqWBcQt3FyMnh4SAicTmhueMELaYxIV7 69m6GLk4hASWMUps3fKAHaZo+ZGnTBCJ6YwSr7ZPYodwZjJJPPw0gw2kik1ATeLLl8NACQ4O EQF9ibYWDZAaZoFeRokzvbvBJgkJ2EpM/f2NFcTmFLCTWD2pAywuLJAksbBxHguIzSKgKnHn /j6wk3iB6l//fckKYQtK/Jh8D6yGWUBLYvO2JlYIW15i85q3zCB7JQTUJR791QUJiwgYSXyY t4kZokREYt+Ld4wg90gIrGKXWHXiHzPELgGJb5MPsUD0ykpsOsAM8bCkxMEVN1gmMErMQrJ5 FpLNs5BsnoVkxQJGllWMoqkFyQXFSelFpnrFibnFpXnpesn5uZsYIdE1cQfj/QPWhxiTgdZP ZJYSTc4HRmdeSbyhsbGJmYmpibmlqbkpacJK4rzyl2QChQTSE0tSs1NTC1KL4otKc1KLDzEy cXBKNTDuz57Fdfav8sG8/psdLD+S7SN9gjg0GLyub2uwtg/RzHi3MXNOCYeH7Q79B5V2Ynu/ PrPc7nTuc+fWjSlFrg78c6ZZ2mUvsjA4/LmAdd/Gb6rhlTK8YfJctyd9lRN8e5nx5xn7w5dm ieQa23G++BH+j+eE1fvqOzuVre2Xe2iycKU0tG+7YarEUpyRaKjFXFScCADENiR/xAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xoG7NE9lAg9XLGS32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPztT+sBcv5Kq5+es3S wLiFu4uRk0NCwERi+ZGnTBC2mMSFe+vZuhi5OIQEpjNKvNo+iR3Cmckk8fDTDDaQKjYBNYkv Xw4DJTg4RAT0JdpaNEBqmAV6GSXO9O5mB6kRErCVmPr7GyuIzSlgJ7F6UgdYXFggSWJh4zwW EJtFQFXizv19jCA2L1D9678vWSFsQYkfk++B1TALaEls3tbECmHLS2xe85YZZK+EgLrEo7+6 IGERASOJD/M2MUOUiEjse/GOcQKj0Cwkk2YhmTQLyaRZSFoWMLKsYhRNLUguKE5KzzXUK07M LS7NS9dLzs/dxAiO3WdSOxhXNlgcYhTgYFTi4RWQkA0UYk0sK67MPcQowcGsJMIrdwsoxJuS WFmVWpQfX1Sak1p8iDEZ6NGJzFKiyfnAtJJXEm9obGJmZGlkZmFkYm5OmrCSOC/jqScBQgLp iSWp2ampBalFMFuYODilGhiDL5dr8XpomzNPX7xL1lKQ++5XiU3/+fidpjippHrn8Nzb4SiR M3t20L4TLrrpMpWLkk5obT8kvoE5TKXhBU9YaBtHF/vX/6kC9TMrZJ6qGfQVuV+52Nx1cI7v rpmR9g0PXh3zmPvIUs7w0LwX79l05r4MP/BpzsWvt39ZMcr5WkgFW/k7TFViKc5INNRiLipO BADyo15OIQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- No changes since v1: No changes since v2: drivers/rtc/rtc-cmos.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 9deb9e4..af97c94 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -706,7 +706,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq) rtc_cmos_int_handler = hpet_rtc_interrupt; err = hpet_register_irq_handler(cmos_interrupt); if (err != 0) { - printk(KERN_WARNING "hpet_register_irq_handler " + dev_warn(dev, "hpet_register_irq_handler " " failed in rtc_init()."); goto cleanup1; } @@ -731,8 +731,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq) goto cleanup2; } - pr_info("%s: %s%s, %zd bytes nvram%s\n", - dev_name(&cmos_rtc.rtc->dev), + dev_info(dev, "%s%s, %zd bytes nvram%s\n", !is_valid_irq(rtc_irq) ? "no alarms" : cmos_rtc.mon_alrm ? "alarms up to one year" : cmos_rtc.day_alrm ? "alarms up to one month" : @@ -820,8 +819,7 @@ static int cmos_suspend(struct device *dev) enable_irq_wake(cmos->irq); } - pr_debug("%s: suspend%s, ctrl %02x\n", - dev_name(&cmos_rtc.rtc->dev), + dev_dbg(dev, "suspend%s, ctrl %02x\n", (tmp & RTC_AIE) ? ", alarm may wake" : "", tmp); @@ -876,9 +874,7 @@ static int cmos_resume(struct device *dev) spin_unlock_irq(&rtc_lock); } - pr_debug("%s: resume, ctrl %02x\n", - dev_name(&cmos_rtc.rtc->dev), - tmp); + dev_dbg(dev, "resume, ctrl %02x\n", tmp); return 0; }