| Submitter | Jingoo Han |
|---|---|
| Date | Feb. 15, 2013, 7:31 a.m. |
| Message ID | <003401ce0b4e$74137570$5c3a6050$%han@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/220676/ |
| State | New |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBS6I66EAKGQENI5Z2QA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x239.google.com (mail-ie0-x239.google.com [IPv6:2607:f8b0:4001:c03::239]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 973462C0085 for <incoming@patchwork.ozlabs.org>; Fri, 15 Feb 2013 18:43:10 +1100 (EST) Received: by mail-ie0-f185.google.com with SMTP id c11sf1039458ieb.2 for <incoming@patchwork.ozlabs.org>; Thu, 14 Feb 2013 23:43:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=kwiTLSO36upKIJocV2GFS+Rw8wefMeoP1G9LWnzHqIo=; b=ACfKUoVz0H5i3J6eBOpphu9Xj7QsN1KTvzLYi77lKowEeYvtoq4bl3ozZQyKaKQHJC QehDZ1N5YMrLo5boQdhTizqMTEApa9+TxRSVtJSMGi5iq0I6RnrotFKbwGmMXYZ5eMc0 uvKqnoYZTwZLptGX+huUK4vEfyV3TaUoVd4iORqVaiNWYG1hDvj/pmcJsjDNIoJHLZ+E 9rF5eMeB45/rAz1tRVM+ph+zXnvQamaXqKggkR5Wu/gKhGatWhNmpXcx3vUitAz86tGR gK8QgVW0GpIgeTwL6NGtl4+bKSg/uzBligLKxvAbkICP0C6NAl+rD51vNFlEyaS3oxFK IFMg== X-Received: by 10.50.214.36 with SMTP id nx4mr179739igc.6.1360913484168; Thu, 14 Feb 2013 23:31:24 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.100.234 with SMTP id fb10ls341761igb.41.gmail; Thu, 14 Feb 2013 23:31:23 -0800 (PST) X-Received: by 10.66.84.98 with SMTP id x2mr866144pay.10.1360913483717; Thu, 14 Feb 2013 23:31:23 -0800 (PST) X-Received: by 10.66.84.98 with SMTP id x2mr866143pay.10.1360913483664; Thu, 14 Feb 2013 23:31:23 -0800 (PST) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id ka10si632423pbb.2.2013.02.14.23.31.23; Thu, 14 Feb 2013 23:31:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI900KVL3KAO6N0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:31:22 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id CF.29.03448.A44ED115; Fri, 15 Feb 2013 16:31:22 +0900 (KST) X-AuditID: cbfee68f-b7f656d000000d78-a8-511de44af32b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 9C.4A.03880.A44ED115; Fri, 15 Feb 2013 16:31:22 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI9008M13KAQE20@mmp2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:31:22 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> In-reply-to: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> Subject: [rtc-linux] [PATCH V3 10/11] rtc: rtc-pcf8583: use dev_warn() instead of printk() Date: Fri, 15 Feb 2013 16:31:22 +0900 Message-id: <003401ce0b4e$74137570$5c3a6050$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LTYY6VzXwCUtKTcq8t8M0FTt2HQAANZ7g X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zI12vJ7KBBpubFSz2d3YwOjB67Jl4 ki2AMYrLJiU1J7MstUjfLoEr4+WF/8wFT9krenbsYG9gXMLWxcjJISFgIvF6+WMWCFtM4sK9 9UBxLg4hgWWMEk0HdrLDFE3q/MkKYgsJTGeU2H0pAqJoJpPEtKurmEASbAJqEl++HAZq4OAQ EdCXaGvRAKlhFuhllDjTu5sdotlWYurvb2CDOAXsJFZP6gCLCwv4SVw9+xwsziKgKrFk6lYw mxeoftP8CWwQtqDEj8n3wC5lFtCS2LytiRXClpfYvOYtM8heCQF1iUd/dUHCIgJGEv++vmeD KBGR2PfiHSPIPRICi9gl/h59ygixS0Di2+RDLBC9shKbDjBD/CspcXDFDZYJjBKzkGyehWTz LCSbZyFZsYCRZRWjaGpBckFxUnqRsV5xYm5xaV66XnJ+7iZGSGz172C8e8D6EGMy0PqJzFKi yfnA2MwriTc0NjYxMzE1Mbc0NTclTVhJnFf+kkygkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6p BsZtW5xbr1yt5Lrs9mnuj9Arp+4Iu/KzqM15ZHJYM/vDDMWsKxaOdrUOfh+EGs6s2reGd3Xh ixfnr4mExOdwrN4V4PQ44YPIll0FFXbz6+XYDk0Iuj9hw+1Hp9cd5zFaoVexZLrU/xXRfOu7 n+7V+Pxvb/OVtz5mxrKsc6fmmTovmDRtpcfNuFthSizFGYmGWsxFxYkAn8/KrMMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xoK7XE9lAg+ZGGYv9nR2MDoweeyae ZAtgjGpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB GqukUJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzHh54T9zwVP2ip4dO9gb GJewdTFyckgImEhM6vzJCmGLSVy4tx4sLiQwnVFi96WILkYuIHsmk8S0q6uYQBJsAmoSX74c Zu9i5OAQEdCXaGvRAKlhFuhllDjTu5sdotlWYurvb2BDOQXsJFZP6gCLCwv4SVw9+xwsziKg KrFk6lYwmxeoftP8CWwQtqDEj8n3WEBsZgEtic3bmlghbHmJzWveMoPslRBQl3j0VxckLCJg JPHv63s2iBIRiX0v3jFOYBSahWTSLCSTZiGZNAtJywJGllWMoqkFyQXFSem5RnrFibnFpXnp esn5uZsYwZH7THoH46oGi0OMAhyMSjy8AhKygUKsiWXFlbmHGCU4mJVEeOVuAYV4UxIrq1KL 8uOLSnNSiw8xJgM9OpFZSjQ5H5hU8kriDY1NzIwsjcwsjEzMzUkTVhLnZTz1JEBIID2xJDU7 NbUgtQhmCxMHp1QDY/+q/78NuoOe82my9MhnyNiEN7WIuUsIzrqs9npvse0fP9nTHlXX773J ni7k5H7Dui2Q9+O27+5vdNYe+/tXK3XqptdWTfdVnXsdnvS8TRAJmZp5OSX4nYOjucfbG/zP xIS+sJYIsu+eNX350q/WypqXffp9p4bKmxw/Ps3zfYNT6ek/vo5flFiKMxINtZiLihMB77g/ OyADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
Comments
Patch
diff --git a/drivers/rtc/rtc-pcf8583.c b/drivers/rtc/rtc-pcf8583.c index 3415b8f..5f97c61 100644 --- a/drivers/rtc/rtc-pcf8583.c +++ b/drivers/rtc/rtc-pcf8583.c @@ -185,8 +185,8 @@ static int pcf8583_rtc_read_time(struct device *dev, struct rtc_time *tm) if (ctrl & (CTRL_STOP | CTRL_HOLD)) { unsigned char new_ctrl = ctrl & ~(CTRL_STOP | CTRL_HOLD); - printk(KERN_WARNING "RTC: resetting control %02x -> %02x\n", - ctrl, new_ctrl); + dev_warn(dev, "resetting control %02x -> %02x\n", + ctrl, new_ctrl); if ((err = pcf8583_set_ctrl(client, &new_ctrl)) < 0) return err;
Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- No changes since v1: Changes since v2: - Remove redundant prefix drivers/rtc/rtc-pcf8583.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)