From patchwork Fri Feb 15 07:28:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220672 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ye0-f185.google.com (mail-ye0-f185.google.com [209.85.213.185]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 615D02C0085 for ; Fri, 15 Feb 2013 18:28:36 +1100 (EST) Received: by mail-ye0-f185.google.com with SMTP id l3sf1038010yen.22 for ; Thu, 14 Feb 2013 23:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-cr-hashedpuzzle:x-cr-puzzleid :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=1E+qTR2wvM8gc0TF6S1X2znvdsVzrf0tsDnsCRct56Q=; b=sL4umwzwB724fAd799eEQwkCSf92uSf7Ig+VBB8vGvpgaSrXf+01S/SIwSGz1yHSfv RqogLNFmsDHkHrQWwDFLpB+Ow+wKzLabRrTGGUcpn4Y9iklEyUCRFRimaxnnN4MKEIXP BS0uA3bqq4GNp0zbi9yWup5QNRxPN+x2pmvx/EADKpf1JMzDVFL/cDkkx9IST8Fh2exC bOZ9J4X0+kqLZakL6Y6ruXmSa66vAVNUrJJuPeTcaGbRY9Rw2laGkQMluS07PQ/qwPBt Mmy1Co+KjhqX5Jq/IdLURJNzrgvrU4b1TU0YRlZLgAD7TGCKAzDMLiKY7wz8G/annR8O P2DQ== X-Received: by 10.50.169.102 with SMTP id ad6mr81884igc.11.1360913313717; Thu, 14 Feb 2013 23:28:33 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.158.131 with SMTP id wu3ls338768igb.18.gmail; Thu, 14 Feb 2013 23:28:33 -0800 (PST) X-Received: by 10.66.82.137 with SMTP id i9mr942151pay.41.1360913313276; Thu, 14 Feb 2013 23:28:33 -0800 (PST) X-Received: by 10.66.82.137 with SMTP id i9mr942150pay.41.1360913313259; Thu, 14 Feb 2013 23:28:33 -0800 (PST) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id d9si96793paw.0.2013.02.14.23.28.32; Thu, 14 Feb 2013 23:28:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI900KNL3FE00G0@mailout2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:28:26 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 25.24.16905.A93ED115; Fri, 15 Feb 2013 16:28:26 +0900 (KST) X-AuditID: cbfee68d-b7f4f6d000004209-60-511de39a07a3 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id A1.99.03880.A93ED115; Fri, 15 Feb 2013 16:28:26 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI900BQR3FEYMS0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 16:28:26 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> In-reply-to: <002b01ce0b4d$865ca950$9315fbf0$%han@samsung.com> Subject: [rtc-linux] [PATCH V3 06/11] rtc: rtc-at91rm9200: use dev_dbg()/dev_err() instead of printk()/pr_debug() Date: Fri, 15 Feb 2013 16:28:26 +0900 Message-id: <003001ce0b4e$0b533480$21f99d80$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LTYY6VzXwCUtKTcq8t8M0FTt2HQAAGwCg x-cr-hashedpuzzle: BBnl C/IO DG51 Ibti I3y6 O2qK QaBX RcBC d4d6 f6Yi kxzc lZL6 ng8U rMD7 tVcB uIRq; 5; YQAuAHoAdQBtAG0AbwBAAHQAbwB3AGUAcgB0AGUAYwBoAC4AaQB0ADsAYQBrAHAAbQBAAGwAaQBuAHUAeAAtAGYAbwB1AG4AZABhAHQAaQBvAG4ALgBvAHIAZwA7AGoAZwAxAC4AaABhAG4AQABzAGEAbQBzAHUAbgBnAC4AYwBvAG0AOwBsAGkAbgB1AHgALQBrAGUAcgBuAGUAbABAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcgB0AGMALQBsAGkAbgB1AHgAQABnAG8AbwBnAGwAZQBnAHIAbwB1AHAAcwAuAGMAbwBtAA==; Sosha1_v1; 7; {4C2A983A-FE5A-4E4D-9FBC-AFA31AF592A0}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Fri, 15 Feb 2013 07:28:19 GMT; WwBQAEEAVABDAEgAIABWADMAIAAwADYALwAxADEAXQAgAHIAdABjADoAIAByAHQAYwAtAGEAdAA5ADEAcgBtADkAMgAwADAAOgAgAHUAcwBlACAAZABlAHYAXwBkAGIAZwAoACkALwBkAGUAdgBfAGUAcgByACgAKQAgAGkAbgBzAHQAZQBhAGQAIABvAGYAIABwAHIAaQBuAHQAawAoACkALwBwAHIAXwBkAGUAYgB1AGcAKAApAA== x-cr-puzzleid: {4C2A983A-FE5A-4E4D-9FBC-AFA31AF592A0} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t8zfd1Zj2UDDXqmGFrs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXRsPjacwFE6Qqfh4/xdTAeEm0i5GTQ0LARGLt8YmsELaYxIV7 69m6GLk4hASWMUr879nOClN0d+lVdojEIkaJKxueskI4M5kkfvfeYgGpYhNQk/jy5TBQFQeH iIC+RFuLBkgNs0Avo8SZ3t3sIDVCArYSU39/A5vKKWAnsXpSB1i9sEC6xM0+T5Awi4CqxKVV E8DKeYHKf0/tZIKwBSV+TL4HtopZQEti87YmVghbXmLzmrfMIGMkBNQlHv3VBQmLCBhJLOk8 B1UiIrHvxTtGiF+2sEn0bomGsE0lzn66wgRypoTALnaJKcuuMkHcICDxbfIhFoiZshKbDjBD 1EtKHFxxg2UCo9QsJBfNQnLRLCQXzUKyegEjyypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2M kFjs3cF4+4D1IcZkoPUTmaVEk/OBsZxXEm9obGxiZmJqYm5pam5KmrCSOK/cJZlAIYH0xJLU 7NTUgtSi+KLSnNTiQ4xMHJxSDYzZXmeDEu4/KrE6MuXgn2PTJjkH/8zgPNupdG7GJK1/xn8C VjobLhbTnxlz8H7VjWID/g8nb8/jf72t3EnyeoFcobLIu+wp28+0xe5z0POUX29XrZz+7qjf vtrOo1Wn5Nak1u7bFympwCywMIUzJZtn5bW7zpf7JvcFZV73/T+77H9jWtCcjVeUWIozEg21 mIuKEwEsvGq32wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsVy+t9jAd1Zj2UDDZr/6ljs7+xgdGD02DPx JFsAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY0bD42nMBROkKn4eP8XU wHhJtIuRk0NCwETi7tKr7BC2mMSFe+vZuhi5OIQEFjFKXNnwlBXCmckk8bv3FgtIFZuAmsSX L4eBOjg4RAT0JdpaNEBqmAV6GSXO9O4GmyQkYCsx9fc3VhCbU8BOYvWkDrB6YYF0iZt9niBh FgFViUurJoCV8wKV/57ayQRhC0r8mHwPbBWzgJbE5m1NrBC2vMTmNW+ZQcZICKhLPPqrCxIW ETCSWNJ5DqpERGLfi3eMEL9sYZPo3RINYZtKnP10hWkCo8gsJBtmIdkwC8mGWUhGLWBkWcUo mlqQXFCclJ5rpFecmFtcmpeul5yfu4kRHOnPpHcwrmqwOMQowMGoxMMrICEbKMSaWFZcmXuI UYKDWUmEV+4WUIg3JbGyKrUoP76oNCe1+BBjMjAAJjJLiSbnA5NQXkm8obGJmZGlkZmFkYm5 OWnCSuK8jKeeBAgJpCeWpGanphakFsFsYeLglGpgtJaa02ygxMnZ7DfnRtrlULUt06stlLST 3Lv3Faqs+e4juTeE13XNVfbVKn/6ctbfWupxgNdjW3zfuxf6BpvueSpkVvuYyp3deXMBh4Zq uy9fjqrP958Xgm9ufc5rI3T2XEXnJ9mjj5fseN/pk+P8b+XHrEO7xad8+L7q39eWpzfZrihv FXoZosRSnJFoqMVcVJwIAKuJljw4AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- No changes since v1: Changes since v2: - Remove redundant prefix drivers/rtc/rtc-at91rm9200.c | 17 ++++++++--------- 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index b6469e2..434ebc3 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@ -86,7 +86,7 @@ static int at91_rtc_readtime(struct device *dev, struct rtc_time *tm) tm->tm_yday = rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year); tm->tm_year = tm->tm_year - 1900; - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); @@ -100,7 +100,7 @@ static int at91_rtc_settime(struct device *dev, struct rtc_time *tm) { unsigned long cr; - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); @@ -145,7 +145,7 @@ static int at91_rtc_readalarm(struct device *dev, struct rtc_wkalrm *alrm) alrm->enabled = (at91_rtc_read(AT91_RTC_IMR) & AT91_RTC_ALARM) ? 1 : 0; - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); @@ -183,7 +183,7 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) at91_rtc_write(AT91_RTC_IER, AT91_RTC_ALARM); } - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, at91_alarm_year, tm.tm_mon, tm.tm_mday, tm.tm_hour, tm.tm_min, tm.tm_sec); @@ -192,7 +192,7 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) { - pr_debug("%s(): cmd=%08x\n", __func__, enabled); + dev_dbg(dev, "%s(): cmd=%08x\n", __func__, enabled); if (enabled) { at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM); @@ -240,7 +240,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id) rtc_update_irq(rtc, 1, events); - pr_debug("%s(): num=%ld, events=0x%02lx\n", __func__, + dev_dbg(&pdev->dev, "%s(): num=%ld, events=0x%02lx\n", __func__, events >> 8, events & 0x000000FF); return IRQ_HANDLED; @@ -296,8 +296,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) IRQF_SHARED, "at91_rtc", pdev); if (ret) { - printk(KERN_ERR "at91_rtc: IRQ %d already in use.\n", - irq); + dev_err(&pdev->dev, "IRQ %d already in use.\n", irq); return ret; } @@ -315,7 +314,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, rtc); - printk(KERN_INFO "AT91 Real Time Clock driver.\n"); + dev_info(&pdev->dev, "AT91 Real Time Clock driver.\n"); return 0; }