| Message ID | 002801ce0b48$714d1130$53e73390$%han@samsung.com |
|---|---|
| State | Superseded |
| Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBNVU66EAKGQEOLXRZSI@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-oa0-f64.google.com (mail-oa0-f64.google.com [209.85.219.64]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id AC7592C0082 for <incoming@patchwork.ozlabs.org>; Fri, 15 Feb 2013 17:48:24 +1100 (EST) Received: by mail-oa0-f64.google.com with SMTP id l20sf1059531oag.9 for <incoming@patchwork.ozlabs.org>; Thu, 14 Feb 2013 22:48:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=SOvtTyiOqMEBh9S6qgfwkrPO55VAGGJf+Cym8Upmfhg=; b=nQL8v4KIclG4M8Mg6o7MK1rHXDEAGV1Y62cBk3SuOWmZ9hL+Vl02lRwH2lgUz1gD4K Oq2+XM6QEHKe5NDd0GNDCm7TfnSXLYsuP6GweKE/JFfLtwlEjm0JLIKlQKTr8JFxAFUj lDfq2c24CVLmOkpxcjZlJgyp5mE6iuYqV68D17ah2GRYM4E3OQBO1sNT0FNjbVMnSpB/ dcb9TFcbTyXTlc42d19P19ZZ8Usm50KC7QLwOx6Kl6AF6ivssjng+axdscXWCHV+vFfm I2zfzV9V9Ydx640ZOj8vUPiDhtAL2EXX1N85xz4oQ4PbzUxxjRTH4Oem7Xl7awrEpqfa RwuA== X-Received: by 10.50.46.167 with SMTP id w7mr83927igm.9.1360910902689; Thu, 14 Feb 2013 22:48:22 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.10.200 with SMTP id k8ls318615igb.37.gmail; Thu, 14 Feb 2013 22:48:22 -0800 (PST) X-Received: by 10.66.90.67 with SMTP id bu3mr914670pab.45.1360910902467; Thu, 14 Feb 2013 22:48:22 -0800 (PST) X-Received: by 10.66.90.67 with SMTP id bu3mr914669pab.45.1360910902454; Thu, 14 Feb 2013 22:48:22 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id tj3si615087pbc.0.2013.02.14.22.48.22; Thu, 14 Feb 2013 22:48:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI900J081JOVHP0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:48:21 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id E6.7F.16905.53ADD115; Fri, 15 Feb 2013 15:48:21 +0900 (KST) X-AuditID: cbfee68d-b7f4f6d000004209-dc-511dda35c792 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F8.1E.03880.43ADD115; Fri, 15 Feb 2013 15:48:20 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI9006ZV1KKOT20@mmp2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:48:20 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> In-reply-to: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 10/11] rtc: rtc-pcf8583: use dev_warn() instead of printk() Date: Fri, 15 Feb 2013 15:48:20 +0900 Message-id: <002801ce0b48$714d1130$53e73390$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LR47AXgjtu6e1Qmq7gnKtv11nagAANFrQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t8zQ13TW7KBBh87pC32d3YwOjB67Jl4 ki2AMYrLJiU1J7MstUjfLoEr4/LqRtaCiewV/5dPY2lgfMbaxcjJISFgIrF4xgI2CFtM4sK9 9UA2F4eQwDJGiU33L7DDFD2bfJkVIjGdUWLB6x5mCGcmk8TNk/PA2tkE1CS+fDkM1MHBISKg L9HWogFSwyzQyyhxpnc3WFxIwFZi6m1nEJNTwE7i/XRTkE5hAT+JlV+6GUFsFgFViZ4P68Em 8gJVd+6bwA5hC0r8mHyPBcRmFtCS2LytiRXClpfYvOYtM8hICQF1iUd/dUHCIgJGErMmvmOD KBGR2PfiHSPINRICy9glZvYdZobYJSDxbfIhFoheWYlNB5gh3pWUOLjiBssERolZSDbPQrJ5 FpLNs5CsWMDIsopRNLUguaA4Kb3IUK84Mbe4NC9dLzk/dxMjJLJ6dzDePmB9iDEZaP1EZinR 5HxgZOaVxBsaG5uYmZiamFuampuSJqwkzit3SSZQSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dU AyPnvgun/67p0jTuXy0qs2eX89vSzefiFbdO6HzHwe5hualZ/M7N4FeOMhnX+4xn6ThZZh5b EPT5wG7/k/6VPhdXsp2U8f0SWfn3kcX1Z3Vbea8U6fLxZRxN8tZ8IqH6RuXpJdvAQ1v3p0+P rbhrdHT7zRfKHPviSuy+GgTMcr7a/HjygZjXm+cqsRRnJBpqMRcVJwIAoWbLbcICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42I5/e+xoK7JLdlAg0cX9C32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePy6kbWgonsFf+XT2Np YHzG2sXIySEhYCLxbPJlKFtM4sK99WxdjFwcQgLTGSUWvO5hhnBmMkncPDmPDaSKTUBN4suX w+xdjBwcIgL6Em0tGiA1zAK9jBJneneDxYUEbCWm3nYGMTkF7CTeTzcF6RQW8JNY+aWbEcRm EVCV6PmwHmwiL1B1574J7BC2oMSPyfdYQGxmAS2JzduaWCFseYnNa94yg4yUEFCXePRXFyQs ImAkMWviOzaIEhGJfS/eMU5gFJqFZNIsJJNmIZk0C0nLAkaWVYyiqQXJBcVJ6blGesWJucWl eel6yfm5mxjBcftMegfjqgaLQ4wCHIxKPLwCErKBQqyJZcWVuYcYJTiYlUR414QAhXhTEiur Uovy44tKc1KLDzEmAz06kVlKNDkfmFLySuINjU3MjCyNzCyMTMzNSRNWEudlPPUkQEggPbEk NTs1tSC1CGYLEwenVAPjVpNE+Z/3fQ7Pe6nfvueotZ7ZpAVVS0wvrDv8/8HBeXyeezb8yzP6 0KQYWNLa4xj6rT+vpfC13f37rEV+TFcsGxcYGG7dv9Tq+PN3LVHXvuxdta1nccKnWsm2CGnF fTs2pbfEfepjZDLg+NTO0+sXH8yd03fLTel37aQzj972MBRsjvi0fukMJZbijERDLeai4kQA p9mRyR8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
diff --git a/drivers/rtc/rtc-pcf8583.c b/drivers/rtc/rtc-pcf8583.c index 3415b8f..aa9bf2b 100644 --- a/drivers/rtc/rtc-pcf8583.c +++ b/drivers/rtc/rtc-pcf8583.c @@ -185,7 +185,7 @@ static int pcf8583_rtc_read_time(struct device *dev, struct rtc_time *tm) if (ctrl & (CTRL_STOP | CTRL_HOLD)) { unsigned char new_ctrl = ctrl & ~(CTRL_STOP | CTRL_HOLD); - printk(KERN_WARNING "RTC: resetting control %02x -> %02x\n", + dev_warn(dev, "RTC: resetting control %02x -> %02x\n", ctrl, new_ctrl); if ((err = pcf8583_set_ctrl(client, &new_ctrl)) < 0)
Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- No changes since v1: drivers/rtc/rtc-pcf8583.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)