From patchwork Fri Feb 15 06:46:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220661 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qc0-f190.google.com (mail-qc0-f190.google.com [209.85.216.190]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 9857C2C007A for ; Fri, 15 Feb 2013 17:46:46 +1100 (EST) Received: by mail-qc0-f190.google.com with SMTP id d10sf1061574qca.27 for ; Thu, 14 Feb 2013 22:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=aF4//UzNo4/U3JYnBpRTQtzdZK8IoWJ3qAUFj6SGkjk=; b=MCpZZHHiit+vEDGb5xv/UYQZGcgZLI8SiYqUYCbYvVR/0jgIrksPr/AEEawIE1wTwn ed2Kja7ElOhoVXQFI/7pgPQXqhVPBakrrJxz8L377ikjXH4fj+3M4bLFgxEWF/nGW7i4 E0VYW/4XTUVPp35HgIO2W7Xrhfx7m1zQZCWoC5iT9J/qjmi05me8HpKmajl4HDCdgq7V H+5luM4ZH3ZwoLtRJtM4EowzdygLloJrzoQv3Us3Y1NQwAYFgt7VDOMtkdiLph5O+sS8 hXOqNi3IGx1+H9uZf6cAAN8sCoKcUB/zqIAqqRfv+zm26TK9qRRdeiyiOkni9L75MzNm MHpg== X-Received: by 10.50.46.167 with SMTP id w7mr83416igm.9.1360910804076; Thu, 14 Feb 2013 22:46:44 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.150.141 with SMTP id ui13ls316719igb.14.canary; Thu, 14 Feb 2013 22:46:43 -0800 (PST) X-Received: by 10.66.52.17 with SMTP id p17mr827353pao.29.1360910803605; Thu, 14 Feb 2013 22:46:43 -0800 (PST) X-Received: by 10.66.52.17 with SMTP id p17mr827352pao.29.1360910803596; Thu, 14 Feb 2013 22:46:43 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id n8si11665812paz.2.2013.02.14.22.46.43; Thu, 14 Feb 2013 22:46:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI900N6O1HK4DJ0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:46:42 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 9F.F1.05791.2D9DD115; Fri, 15 Feb 2013 15:46:42 +0900 (KST) X-AuditID: cbfee690-b7f066d00000169f-dd-511dd9d240d1 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 3D.94.03918.2D9DD115; Fri, 15 Feb 2013 15:46:42 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI90072I1HUCBE1@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:46:42 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> In-reply-to: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk() Date: Fri, 15 Feb 2013 15:46:42 +0900 Message-id: <002501ce0b48$36cf28e0$a46d7aa0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LR47AXgjtu6e1Qmq7gnKtv11nagAAJeUA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t8zQ91LN2UDDX61aVvs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxo6nD1kLZnFUrHgymaWB8SJbFyMnh4SAicS8fw1MELaYxIV7 64HiXBxCAssYJXZ1vWDsYuQAK/rayAERX8Qo8ebrHkYIZyaTxPJVC9lButkE1CS+fDnMDtIg IqAv0daiAVLDLNDLKHGmdzdYXEjAVmLqbWcQk1PATuL9dFMQU1jAR2LdcheQISwCqhIXPy4C O40XqPjg85esELagxI/J91hAbGYBLYnN25pYIWx5ic1r3jJDXKku8eivLsR+I4k1/7QgKkQk 9r14B3avhMA8dol7G2ezQ6wSkPg2+RALRKusxKYDzJBAkJQ4uOIGywRGiVlIFs9CsngWksWz kKxYwMiyilE0tSC5oDgpvchErzgxt7g0L10vOT93EyMkpibsYLx3wPoQYzLQ+onMUqLJ+cCY zCuJNzQ2NjEzMTUxtzQ1NyVNWEmcV/6STKCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGRofu /62HZ+6Lm9gV/NuCXW3u4t5vvKncF68dtp7vMoeH+czmPau9/hV3Lal+4rPKOeyCoYv7lL7a hJPT5UT2v8h1n7ohoy1rwT4fe4UY155peb4Sb0rOzlxcqSH5/8kdiVW9od/kDCKaTW+lH1++ hktcuuyDgv+Lmf7b1rZdW/e+jWnXhfMre5RYijMSDbWYi4oTAf/5iyi/AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42I5/e+xgO6lm7KBBstWq1vs7+xgdGD02DPx JFsAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8aOpw9ZC2ZxVKx4Mpml gfEiWxcjB4eEgInE10aOLkZOIFNM4sK99UBhLg4hgUWMEm++7mGEcGYySSxftZAdpIpNQE3i y5fD7CDNIgL6Em0tGiA1zAK9jBJneneDxYUEbCWm3nYGMTkF7CTeTzcFMYUFfCTWLXcBGcIi oCpx8eMiNhCbF6j44POXrBC2oMSPyfdYQGxmAS2JzduaWCFseYnNa94yQ1ysLvHory7EfiOJ Nf+0ICpEJPa9eMc4gVFoFpJBs5AMmoVk0CwkLQsYWVYxiqYWJBcUJ6XnGuoVJ+YWl+al6yXn 525iBEfsM6kdjCsbLA4xCnAwKvHwCkjIBgqxJpYVV+YeYpTgYFYS4V0TAhTiTUmsrEotyo8v Ks1JLT7EmAz050RmKdHkfGAyySuJNzQ2MTOyNDKzMDIxNydNWEmcl/HUkwAhgfTEktTs1NSC 1CKYLUwcnFINjCrP2r9xiXqGbvD8JfDKzo9V98vh25fLSh4L/fa8w7aq4XP37+TDhlUs/fsK w4MdO1Z8Uk84L1gqs7/ZraCufj7zlr0Xbp+bUmRaOUVvESO/g/LuVqX31eH7bMOyg9n+v/u4 qLq5f5bRmqZTdXlLZ5uufWLFw/3WPKZYRaRL5UlH7YPrjTqGSizFGYmGWsxFxYkAk1GgRRwD AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- No changes since v1: drivers/rtc/rtc-rs5c313.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c index d1aee79..8ca55a6 100644 --- a/drivers/rtc/rtc-rs5c313.c +++ b/drivers/rtc/rtc-rs5c313.c @@ -39,6 +39,8 @@ * 1.13 Nobuhiro Iwamatsu: Updata driver. */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -352,8 +354,7 @@ static void rs5c313_check_xstp_bit(void) tm.tm_year = 2000 - 1900; rs5c313_rtc_set_time(NULL, &tm); - printk(KERN_ERR "RICHO RS5C313: invalid value, resetting to " - "1 Jan 2000\n"); + pr_err("RICHO RS5C313: invalid value, resetting to 1 Jan 2000\n"); } RS5C313_CEDISABLE; ndelay(700); /* CE:L */