From patchwork Fri Feb 15 06:44:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220658 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ia0-x23f.google.com (mail-ia0-x23f.google.com [IPv6:2607:f8b0:4001:c02::23f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 809332C0085 for ; Fri, 15 Feb 2013 17:45:05 +1100 (EST) Received: by mail-ia0-f191.google.com with SMTP id k10sf1015710iag.8 for ; Thu, 14 Feb 2013 22:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-cr-hashedpuzzle:x-cr-puzzleid :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=G6zADlbEXTJ1s1saaOqi4xWRUzHJTgYKNMRNkX0RkZk=; b=BVfHadObSD7sdWdqGP0CvDapwi1iB7+stwuYdopUqfclaqKjQlOw8YVdLaI1MkhG+o q86tCRKnCpaTxMxD9U5KX/OVplZxFl69CS64gD3ixGwT3SgY7FKFR3snYyC/HCGM9BVb 2OQYLWHPA0xZwgW84rKtTyJ1OFMk7sDEPw0LbXudz3Mlu8SUT30qUzjmmqYa5cEKehbL bMuqBZu5t+ybLFrt6ycR1Mtkd0ibSG+3ZH0WZf6cRgd/WtAoUkOayXMn/YmqDBKjaomP JYFtKLBKkmVH6ZRw59+5XDXa25alM/GI4t/maYojmGMYUbLsf+MkEwNowkjrynQshwMt w44Q== X-Received: by 10.50.152.232 with SMTP id vb8mr167134igb.16.1360910703081; Thu, 14 Feb 2013 22:45:03 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.36.168 with SMTP id r8ls327803igj.40.canary; Thu, 14 Feb 2013 22:45:02 -0800 (PST) X-Received: by 10.66.147.1 with SMTP id tg1mr972914pab.24.1360910702774; Thu, 14 Feb 2013 22:45:02 -0800 (PST) X-Received: by 10.66.147.1 with SMTP id tg1mr972913pab.24.1360910702742; Thu, 14 Feb 2013 22:45:02 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id tj3si614698pbc.0.2013.02.14.22.45.02; Thu, 14 Feb 2013 22:45:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI900CAB1EXEKL0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:45:01 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id EC.A6.06692.B69DD115; Fri, 15 Feb 2013 15:44:59 +0900 (KST) X-AuditID: cbfee691-b7f556d000001a24-ab-511dd96b3a80 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 0C.04.03918.B69DD115; Fri, 15 Feb 2013 15:44:59 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI900BD81EZYME0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:44:59 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> In-reply-to: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 04/11] rtc: rtc-ds2404: use dev_err() instead of printk() Date: Fri, 15 Feb 2013 15:44:59 +0900 Message-id: <002201ce0b47$f97aa0f0$ec6fe2d0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LR47AXgjtu6e1Qmq7gnKtv11nagAAFNtQ x-cr-hashedpuzzle: KtgU NFqx PPEw RHFj UqW4 XZmB X2W4 e3aM fbAK jFMD mTn/ nHNr onpB peK5 rPAp rkQw; 5; YQAuAHoAdQBtAG0AbwBAAHQAbwB3AGUAcgB0AGUAYwBoAC4AaQB0ADsAYQBrAHAAbQBAAGwAaQBuAHUAeAAtAGYAbwB1AG4AZABhAHQAaQBvAG4ALgBvAHIAZwA7AGoAZwAxAC4AaABhAG4AQABzAGEAbQBzAHUAbgBnAC4AYwBvAG0AOwBsAGkAbgB1AHgALQBrAGUAcgBuAGUAbABAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcgB0AGMALQBsAGkAbgB1AHgAQABnAG8AbwBnAGwAZQBnAHIAbwB1AHAAcwAuAGMAbwBtAA==; Sosha1_v1; 7; {66E5EEB7-8FCA-4646-BBB1-B9DB78992062}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Fri, 15 Feb 2013 06:44:52 GMT; WwBQAEEAVABDAEgAIABWADIAIAAwADQALwAxADEAXQAgAHIAdABjADoAIAByAHQAYwAtAGQAcwAyADQAMAA0ADoAIAB1AHMAZQAgAGQAZQB2AF8AZQByAHIAKAApACAAaQBuAHMAdABlAGEAZAAgAG8AZgAgAHAAcgBpAG4AdABrACgAKQA= x-cr-puzzleid: {66E5EEB7-8FCA-4646-BBB1-B9DB78992062} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t8zA93sm7KBBrsnGFrs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxuyPO9kKpnBW9HzqZm9gXMPexcjJISFgIjHr6x4mCFtM4sK9 9WxdjFwcQgLLGCVm/rnFBFP04uJ7RojEIkaJ4xe/QlXNZJI4f+UYK0gVm4CaxJcvh4HGcnCI COhLtLVogNQwC/QySpzp3Q0WFxKwlZh62xnE5BSwk3g/3RSkU1jAR+LZ2Xlgu1gEVCX6+ncz g5TwAlXPvygMEuYVEJT4MfkeC4jNLKAlsXlbEyuELS+xec1bsHIJAXWJR391QcIiAkYSTbPf Q5WLSOx78Y4R4pMPrBKTn7lB2KYS/8+uYwE5UkJgF7vEjr1nmSFOEJD4NvkQC8RMWYlNB5gh 6iUlDq64wTKBUWoWkotmIbloFpKLZiFZvYCRZRWjaGpBckFxUnqRqV5xYm5xaV66XnJ+7iZG SBxO3MF4/4D1IcZkoPUTmaVEk/OBcZxXEm9obGxiZmJqYm5pam5KmrCSOK/8JZlAIYH0xJLU 7NTUgtSi+KLSnNTiQ4xMHJxSDYyTp86bmbZNykJkkb6q2LJDe36kr3Jx/7z155aePylPfmTz PvvPETg9RPdIWSD7V5s+ObZrJue/vv/y7NKiHDN3ndjDuc7/Pq9TkCu4qXMwcdo3Bmf9NV++ SWitzU0RW1R502naCyHJhuyjXlHv7u7eY7x4etBf5y87j6WvaNv0el7nLR2Rz2UVSizFGYmG WsxFxYkA7OWvEtkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMKsWRmVeSWpSXmKPExsVy+t9jAd3sm7KBBjO26lrs7+xgdGD02DPx JFsAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8bsjzvZCqZwVvR86mZv YFzD3sXIySEhYCLx4uJ7RghbTOLCvfVsXYxcHEICixgljl/8CuXMZJI4f+UYK0gVm4CaxJcv h4G6OThEBPQl2lo0QGqYBXoZJc707gaLCwnYSky97QxicgrYSbyfbgrSKSzgI/Hs7DwmEJtF QFWir383M0gJL1D1/IvCIGFeAUGJH5PvsYDYzAJaEpu3NbFC2PISm9e8BSuXEFCXePRXFyQs ImAk0TT7PVS5iMS+F++gPvnAKjH5mRuEbSrx/+w6lgmMIrOQbJiFZMMsJBtmIRm1gJFlFaNo akFyQXFSeq6hXnFibnFpXrpecn7uJkZwlD+T2sG4ssHiEKMAB6MSD6+AhGygEGtiWXFl7iFG CQ5mJRHeNSFAId6UxMqq1KL8+KLSnNTiQ4zJQP9PZJYSTc4HJqC8knhDYxMzI0sjMwsjE3Nz 0oSVxHkZTz0JEBJITyxJzU5NLUgtgtnCxMEp1cBYHLfr4NXNfT/TMpLXvu70fysktKlE+89N GX3bR/EZeh/edzBapb9WOJF0P5Z3ntq6EOvlsXviJp88/UJ669NVHE57ZmevOnWLIW3Fk7Wv VdapXmWyk1WcLPRNe9HNmAnl03bttuN6wZ7HEaaXuTAwann7t2/LVgitUioQmSqXbGJ0dLL0 QRl1JZbijERDLeai4kQAdtkaWzYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- No changes since v1: drivers/rtc/rtc-ds2404.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 4539e37..b04fc42 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -70,7 +70,7 @@ static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev, for (i = 0; i < ARRAY_SIZE(ds2404_gpio); i++) { err = gpio_request(ds2404_gpio[i].gpio, ds2404_gpio[i].name); if (err) { - printk(KERN_ERR "error mapping gpio %s: %d\n", + dev_err(&pdev->dev, "error mapping gpio %s: %d\n", ds2404_gpio[i].name, err); goto err_request; } @@ -177,7 +177,7 @@ static void ds2404_write_memory(struct device *dev, u16 offset, for (i = 0; i < length; i++) { if (out[i] != ds2404_read_byte(dev)) { - printk(KERN_ERR "read invalid data\n"); + dev_err(dev, "read invalid data\n"); return; } }