From patchwork Fri Feb 15 06:03:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220644 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vc0-f187.google.com (mail-vc0-f187.google.com [209.85.220.187]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 703F12C0082 for ; Fri, 15 Feb 2013 17:03:36 +1100 (EST) Received: by mail-vc0-f187.google.com with SMTP id l6sf1023485vcl.4 for ; Thu, 14 Feb 2013 22:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=aLrmcnLk0dRDPedGeko0cW2vS3jtbLCpfAYv4fL3a9k=; b=ZXqtdySc7nJQrGr0Xq3aWhH97rscUH19KAegpBHbVtYhG1V1itTTkn2IGyYCew98lU H3FZHS/5Gynf8bix9IG+inqs4FqTXWYqhYARCblv/ujVZag8ct7mZprnIofTFQoTVq1U q4wjpzvfbnKn2YlU2owBsgBMZ5w9uemyZW15fQkuVnUh/hUlku3K2Hb3eo6q1OCUKrjx M7PMD0NiAuHQuTWKkIyLpVOUOUxgeeCpyhALwHuOh2U5IrYutyC7cTRrrnOvOEjslS2h 1d6D62J41bfocH2SGtLuYVl/Teyn8rpIFXAgVDzFLlzpEbB6h6DfkUTXzeOL61BAADNz Adkw== X-Received: by 10.50.53.232 with SMTP id e8mr169125igp.14.1360908213257; Thu, 14 Feb 2013 22:03:33 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.42.229 with SMTP id r5ls165677igl.27.canary; Thu, 14 Feb 2013 22:03:33 -0800 (PST) X-Received: by 10.66.172.36 with SMTP id az4mr931631pac.38.1360908213044; Thu, 14 Feb 2013 22:03:33 -0800 (PST) X-Received: by 10.66.172.36 with SMTP id az4mr931630pac.38.1360908213029; Thu, 14 Feb 2013 22:03:33 -0800 (PST) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id x3si11249449paw.1.2013.02.14.22.03.32; Thu, 14 Feb 2013 22:03:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI8008DEZHWVE50@mailout2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:03:32 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 7C.68.06456.4BFCD115; Fri, 15 Feb 2013 15:03:32 +0900 (KST) X-AuditID: cbfee68e-b7fc26d000001938-48-511dcfb48594 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 59.47.03918.3BFCD115; Fri, 15 Feb 2013 15:03:32 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI80072SZHVCBW0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:03:31 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> In-reply-to: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> Subject: [rtc-linux] [PATCH 10/11] rtc: rtc-pcf8583: use dev_warn() instead of printk() Date: Fri, 15 Feb 2013 15:03:31 +0900 Message-id: <001b01ce0b42$2ea49c50$8bedd4f0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LQUiQnZ5yIGDDRaO8BQe4Zm4AfgAAM0sg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t8zA90t52UDDT5MZLXY39nB6MDosWfi SbYAxigum5TUnMyy1CJ9uwSujMXr7jEW/GSrmHBwC1sD41XWLkZODgkBE4mDk05C2WISF+6t Z+ti5OIQEljGKPHu7jZmmKKLDVOhEosYJXYc+cwK4cxkkliy9TsbSBWbgJrEly+H2bsYOThE BPQl2lo0QGqYBXoZJc707mYHqRESsJWY8Gkd2FROATuJ738egvUKC3hLvJpyH8xmEVCVOLfu HJjNC1S/+uM2FghbUOLH5HtgNrOAlsTmbU2sELa8xOY1b5lB9koIqEs8+qsLEhYRMJL4uKCF CaJERGLfi3eMIPdICCxjl+i+dJkRYpeAxLfJh1ggemUlNh2AelhS4uCKGywTGCVmIdk8C8nm WUg2z0KyYgEjyypG0dSC5ILipPQiI73ixNzi0rx0veT83E2MkOjq28F484D1IcZkoPUTmaVE k/OB0ZlXEm9obGxiZmJqYm5pam5KmrCSOK/8JZlAIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxS DYwuK7Mu7eD8/Nz5zx/jt5xsf198EMtW796dassd+dtGSo9ly8oLMce3LdXrXLhP+eId+T3v EhYzWpucf766pu7WxNfrL35uXRThnrN8jUHWC8bO/uhDF4UEVRe9qNA0u6mgIsDtvHar4YV1 X9q6/iXJJZzsz+mSmXhCbfuBPyIRq7+znL60lTFUiaU4I9FQi7moOBEAvkJrxcQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xgO6W87KBBpcXMVrs7+xgdGD02DPx JFsAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8bidfcYC36yVUw4uIWt gfEqaxcjJ4eEgInExYapbBC2mMSFe+uBbC4OIYFFjBI7jnxmhXBmMkks2fodrIpNQE3iy5fD 7F2MHBwiAvoSbS0aIDXMAr2MEmd6d7OD1AgJ2EpM+LSOGcTmFLCT+P7nIVivsIC3xKsp98Fs FgFViXPrzoHZvED1qz9uY4GwBSV+TL4HZjMLaEls3tbECmHLS2xe85YZZK+EgLrEo7+6IGER ASOJjwtamCBKRCT2vXjHOIFRaBaSSbOQTJqFZNIsJC0LGFlWMYqmFiQXFCel5xrqFSfmFpfm pesl5+duYgTH7jOpHYwrGywOMQpwMCrx8ApIyAYKsSaWFVfmHmKU4GBWEuFdEwIU4k1JrKxK LcqPLyrNSS0+xJgM9OhEZinR5HxgWskriTc0NjEzsjQyszAyMTcnTVhJnJfx1JMAIYH0xJLU 7NTUgtQimC1MHJxSDYy+HGypi7ce+/q4/z5fluaOJ1unXM04s2iO7PSo4uWfGYUeNL1MkXv6 e/vijQFfRaOsUviW/l3VKTw9v/Gat9e90DdVbVbq8oXKd4sYYwvDEzO25J1RNj8f27O9SHrZ pviNKyfeZyw/KDFLpOfLtD8L5bNDmV8/EzXoDFthIRP8nNlHTZ7/1UQlluKMREMt5qLiRABl iiUdIQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- drivers/rtc/rtc-pcf8583.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-pcf8583.c b/drivers/rtc/rtc-pcf8583.c index 3415b8f..aa9bf2b 100644 --- a/drivers/rtc/rtc-pcf8583.c +++ b/drivers/rtc/rtc-pcf8583.c @@ -185,7 +185,7 @@ static int pcf8583_rtc_read_time(struct device *dev, struct rtc_time *tm) if (ctrl & (CTRL_STOP | CTRL_HOLD)) { unsigned char new_ctrl = ctrl & ~(CTRL_STOP | CTRL_HOLD); - printk(KERN_WARNING "RTC: resetting control %02x -> %02x\n", + dev_warn(dev, "RTC: resetting control %02x -> %02x\n", ctrl, new_ctrl); if ((err = pcf8583_set_ctrl(client, &new_ctrl)) < 0)